From: Greg Kurz <groug@kaod.org>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: <qemu-devel@nongnu.org>, <qemu-stable@nongnu.org>
Subject: Re: [PATCH 6/6] tests/9p: also check 'Tgetattr' in 'use-after-unlink' test
Date: Tue, 26 Nov 2024 18:02:16 +0100 [thread overview]
Message-ID: <20241126180216.0638d10e@bahia> (raw)
In-Reply-To: <7017658155c517b9665b75333a97c79aa2d4f3df.1732465720.git.qemu_oss@crudebyte.com>
On Sun, 24 Nov 2024 17:05:32 +0100
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> This verifies expected behaviour of previous bug fix patch.
>
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> tests/qtest/virtio-9p-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
> index f6d7400a87..ab3a12c816 100644
> --- a/tests/qtest/virtio-9p-test.c
> +++ b/tests/qtest/virtio-9p-test.c
> @@ -702,6 +702,7 @@ static void fs_use_after_unlink(void *obj, void *data,
> g_autofree char *real_file = virtio_9p_test_path("09/doa_file");
> g_autofree char *buf = g_malloc0(write_count);
> struct stat st_file;
> + struct v9fs_attr attr;
> uint32_t fid_file;
> uint32_t count;
>
> @@ -725,6 +726,10 @@ static void fs_use_after_unlink(void *obj, void *data,
> tunlinkat({ .client = v9p, .atPath = "09", .name = "doa_file" });
>
> /* file is removed, but we still have it open, so this should succeed */
> + tgetattr({
> + .client = v9p, .fid = fid_file, .request_mask = P9_GETATTR_BASIC,
> + .rgetattr.attr = &attr
> + });
> count = twrite({
> .client = v9p, .fid = fid_file, .offset = 0, .count = write_count,
> .data = buf
--
Greg
next prev parent reply other threads:[~2024-11-26 17:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 16:28 [PATCH 0/6] 9pfs: fix fstat() after unlink() (with a Linux guest) Christian Schoenebeck
2024-02-21 14:13 ` [PATCH 1/6] tests/9p: add 'use-after-unlink' test Christian Schoenebeck
2024-11-25 8:47 ` Greg Kurz
2024-11-25 9:34 ` Christian Schoenebeck
2024-11-24 13:34 ` [PATCH 2/6] tests/9p: fix Rreaddir response name Christian Schoenebeck
2024-11-24 19:41 ` Christian Schoenebeck
2024-11-25 8:48 ` Greg Kurz
2024-11-24 14:49 ` [PATCH 3/6] tests/9p: add missing Rgetattr " Christian Schoenebeck
2024-11-24 19:42 ` Christian Schoenebeck
2024-11-25 8:51 ` Greg Kurz
2024-11-24 15:06 ` [PATCH 4/6] 9pfs: remove obsolete comment in v9fs_getattr() Christian Schoenebeck
2024-11-24 19:43 ` Christian Schoenebeck
2024-11-25 8:54 ` Greg Kurz
2024-11-24 15:50 ` [PATCH 5/6] 9pfs: fix 'Tgetattr' after unlink Christian Schoenebeck
2024-11-24 19:44 ` Christian Schoenebeck
2024-11-26 16:03 ` Christian Schoenebeck
2024-11-26 16:58 ` Greg Kurz
2024-11-24 16:05 ` [PATCH 6/6] tests/9p: also check 'Tgetattr' in 'use-after-unlink' test Christian Schoenebeck
2024-11-26 17:02 ` Greg Kurz [this message]
2024-11-25 8:45 ` [PATCH 0/6] 9pfs: fix fstat() after unlink() (with a Linux guest) Greg Kurz
2024-11-25 9:05 ` Greg Kurz
2024-11-25 10:23 ` Christian Schoenebeck
2024-11-25 11:35 ` Greg Kurz
2024-11-25 14:11 ` Christian Schoenebeck
2024-11-27 9:58 ` Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126180216.0638d10e@bahia \
--to=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.