From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
Wei Yang <richard.weiyang@gmail.com>,
"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH 4/7] maple_tree: the return value of mast_spanning_rebalance() is not used
Date: Wed, 27 Nov 2024 01:27:50 +0000 [thread overview]
Message-ID: <20241127012753.3393-5-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241127012753.3393-1-richard.weiyang@gmail.com>
The return value is not used, change it to a void function.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
lib/maple_tree.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index f5606b4d0dba..6cabee1371ec 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2265,7 +2265,7 @@ static inline void mast_rebalance_prev(struct maple_subtree_state *mast)
* @mast: The maple_subtree_state.
*/
static inline
-bool mast_spanning_rebalance(struct maple_subtree_state *mast)
+void mast_spanning_rebalance(struct maple_subtree_state *mast)
{
struct ma_state r_tmp = *mast->orig_r;
struct ma_state l_tmp = *mast->orig_l;
@@ -2284,7 +2284,7 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
mast_rebalance_next(mast);
*mast->orig_l = l_tmp;
- return true;
+ return;
} else if (mast->orig_l->offset != 0) {
mast->orig_l->offset--;
do {
@@ -2295,13 +2295,13 @@ bool mast_spanning_rebalance(struct maple_subtree_state *mast)
mast_rebalance_prev(mast);
*mast->orig_r = r_tmp;
- return true;
+ return;
}
} while (!mte_is_root(mast->orig_r->node));
*mast->orig_r = r_tmp;
*mast->orig_l = l_tmp;
- return false;
+ return;
}
/*
--
2.34.1
next prev parent reply other threads:[~2024-11-27 1:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 1:27 [PATCH 0/7] spanning write related cleanup Wei Yang
2024-11-27 1:27 ` [PATCH 1/7] maple_tree: not necessary to check ahead if !content Wei Yang
2024-11-27 1:27 ` [PATCH 2/7] maple_tree: validate we won't split on NULL Wei Yang
2024-11-27 1:27 ` [PATCH 3/7] maple_tree: check mid_split only may have Wei Yang
2024-11-27 1:27 ` Wei Yang [this message]
2024-11-27 1:27 ` [PATCH 5/7] maple_tree: the type of left subtree is already saved in bnode->type Wei Yang
2024-11-27 1:27 ` [PATCH 6/7] maple_tree: always need to update max of new left node Wei Yang
2024-11-27 1:27 ` [PATCH 7/7] maple_tree: only ascend left subtree to get the old node for replacement Wei Yang
2024-11-27 13:31 ` [PATCH 0/7] spanning write related cleanup Liam R. Howlett
2024-11-28 1:11 ` Wei Yang
2025-01-17 5:49 ` Wei Yang
2025-01-23 17:52 ` Liam R. Howlett
2025-01-24 1:43 ` Wei Yang
2025-01-27 14:36 ` Liam R. Howlett
2025-01-28 1:36 ` Wei Yang
2025-01-28 2:11 ` Wei Yang
2025-01-31 16:46 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127012753.3393-5-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=maple-tree@lists.infradead.org \
--cc=sidhartha.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.