All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>,
	"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH 7/7] maple_tree: only ascend left subtree to get the old node for replacement
Date: Wed, 27 Nov 2024 01:27:53 +0000	[thread overview]
Message-ID: <20241127012753.3393-8-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241127012753.3393-1-richard.weiyang@gmail.com>

When we come to a new_root, we should go up the tree to get the old root
for replacement.

Instead of ascend both left/right subtree, we only ascend one of it is
enough. Let's use the left subtree as it dose now.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 lib/maple_tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 4ba9ae68c0a9..2c05919be168 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2920,7 +2920,7 @@ static void mas_spanning_rebalance(struct ma_state *mas,
 new_root:
 		mas_mn(mast->l)->parent = ma_parent_ptr(mas_tree_parent(mas));
 		while (!mte_is_root(mast->orig_l->node))
-			mast_ascend(mast);
+			mas_ascend(mast->orig_l);
 	} else {
 		mas_mn(&l_mas)->parent = mas_mn(mast->orig_l)->parent;
 	}
-- 
2.34.1



  parent reply	other threads:[~2024-11-27  1:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27  1:27 [PATCH 0/7] spanning write related cleanup Wei Yang
2024-11-27  1:27 ` [PATCH 1/7] maple_tree: not necessary to check ahead if !content Wei Yang
2024-11-27  1:27 ` [PATCH 2/7] maple_tree: validate we won't split on NULL Wei Yang
2024-11-27  1:27 ` [PATCH 3/7] maple_tree: check mid_split only may have Wei Yang
2024-11-27  1:27 ` [PATCH 4/7] maple_tree: the return value of mast_spanning_rebalance() is not used Wei Yang
2024-11-27  1:27 ` [PATCH 5/7] maple_tree: the type of left subtree is already saved in bnode->type Wei Yang
2024-11-27  1:27 ` [PATCH 6/7] maple_tree: always need to update max of new left node Wei Yang
2024-11-27  1:27 ` Wei Yang [this message]
2024-11-27 13:31 ` [PATCH 0/7] spanning write related cleanup Liam R. Howlett
2024-11-28  1:11   ` Wei Yang
2025-01-17  5:49   ` Wei Yang
2025-01-23 17:52     ` Liam R. Howlett
2025-01-24  1:43       ` Wei Yang
2025-01-27 14:36         ` Liam R. Howlett
2025-01-28  1:36           ` Wei Yang
2025-01-28  2:11           ` Wei Yang
2025-01-31 16:46           ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241127012753.3393-8-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maple-tree@lists.infradead.org \
    --cc=sidhartha.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.