From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haseeb Gani <hgani@marvell.com>,
Sathesh B Edara <sedara@marvell.com>,
Vimlesh Kumar <vimleshk@marvell.com>,
"thaller@redhat.com" <thaller@redhat.com>,
"wizhao@redhat.com" <wizhao@redhat.com>,
"kheib@redhat.com" <kheib@redhat.com>,
"egallen@redhat.com" <egallen@redhat.com>,
"konguyen@redhat.com" <konguyen@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"einstein.xue@synaxg.com" <einstein.xue@synaxg.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v3 RESEND] octeon_ep: add ndo ops for VFs in PF driver
Date: Thu, 5 Dec 2024 16:51:47 -0800 [thread overview]
Message-ID: <20241205165147.2f7a7ae8@kernel.org> (raw)
In-Reply-To: <PH0PR18MB47342ED76DCB583E62078808C7302@PH0PR18MB4734.namprd18.prod.outlook.com>
On Thu, 5 Dec 2024 15:47:29 +0000 Shinas Rasheed wrote:
> > I don't see it ever getting set to true, why track it if it's always
> > false?
>
> In case we need to support the api in the future, just added the
> corresponding data structure to track it. Perhaps if you think that’s
> warranted only 'when' we support it then, maybe I can remove it. The
> data structure was used to check for 'trusted' when vf tries to set
> its mac.
Yes, please remove it. We try to limit merging code that's of
no immediate use.
prev parent reply other threads:[~2024-12-06 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 18:32 [PATCH net-next v3 RESEND] octeon_ep: add ndo ops for VFs in PF driver Shinas Rasheed
2024-12-04 2:33 ` Jakub Kicinski
2024-12-05 15:47 ` [EXTERNAL] " Shinas Rasheed
2024-12-06 0:51 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205165147.2f7a7ae8@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.