All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Damien Le Moal <dlemoal@kernel.org>,
	linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@lists.linux.dev
Cc: oe-kbuild-all@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
	Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment
Date: Fri, 6 Dec 2024 14:10:41 +0800	[thread overview]
Message-ID: <202412061404.Utec5WgH-lkp@intel.com> (raw)
In-Reply-To: <20241206015240.6862-5-dlemoal@kernel.org>

Hi Damien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.13-rc1 next-20241205]
[cannot apply to device-mapper-dm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/block-Use-a-zone-write-plug-BIO-work-for-REQ_NOWAIT-BIOs/20241206-095452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20241206015240.6862-5-dlemoal%40kernel.org
patch subject: [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment
config: arc-randconfig-002-20241206 (https://download.01.org/0day-ci/archive/20241206/202412061404.Utec5WgH-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412061404.Utec5WgH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412061404.Utec5WgH-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> block/blk-zoned.c:1751: warning: Excess function parameter 'flags' description in 'blkdev_issue_zone_zeroout'


vim +1751 block/blk-zoned.c

  1735	
  1736	/**
  1737	 * blkdev_issue_zone_zeroout - zero-fill a block range in a zone
  1738	 * @bdev:	blockdev to write
  1739	 * @sector:	start sector
  1740	 * @nr_sects:	number of sectors to write
  1741	 * @gfp_mask:	memory allocation flags (for bio_alloc)
  1742	 * @flags:	controls detailed behavior
  1743	 *
  1744	 * Description:
  1745	 *  Zero-fill a block range in a zone (@sector must be equal to the zone write
  1746	 *  pointer), handling potential errors due to the (initially unknown) lack of
  1747	 *  hardware offload (See blkdev_issue_zeroout()).
  1748	 */
  1749	int blkdev_issue_zone_zeroout(struct block_device *bdev, sector_t sector,
  1750			sector_t nr_sects, gfp_t gfp_mask)
> 1751	{
  1752		int ret;
  1753	
  1754		if (WARN_ON_ONCE(!bdev_is_zoned(bdev)))
  1755			return -EIO;
  1756	
  1757		ret = blkdev_issue_zeroout(bdev, sector, nr_sects, gfp_mask,
  1758					   BLKDEV_ZERO_NOFALLBACK);
  1759		if (ret != -EOPNOTSUPP)
  1760			return ret;
  1761	
  1762		/*
  1763		 * The failed call to blkdev_issue_zeroout() advanced the zone write
  1764		 * pointer. Undo this using a report zone to update the zone write
  1765		 * pointer to the correct current value.
  1766		 */
  1767		ret = disk_zone_sync_wp_offset(bdev->bd_disk, sector);
  1768		if (ret != 1)
  1769			return ret < 0 ? ret : -EIO;
  1770	
  1771		/*
  1772		 * Retry without BLKDEV_ZERO_NOFALLBACK to force the fallback to a
  1773		 * regular write with zero-pages.
  1774		 */
  1775		return blkdev_issue_zeroout(bdev, sector, nr_sects, gfp_mask, 0);
  1776	}
  1777	EXPORT_SYMBOL(blkdev_issue_zone_zeroout);
  1778	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2024-12-06  6:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  1:52 [PATCH 0/4] Zone write plugging fixes Damien Le Moal
2024-12-06  1:52 ` [PATCH 1/4] block: Use a zone write plug BIO work for REQ_NOWAIT BIOs Damien Le Moal
2024-12-06  1:52 ` [PATCH 2/4] block: Ignore REQ_NOWAIT for zone reset and zone finish operations Damien Le Moal
2024-12-06  1:52 ` [PATCH 3/4] block: Prevent potential deadlocks in zone write plug error recovery Damien Le Moal
2024-12-06  1:52 ` [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment Damien Le Moal
2024-12-06  6:10   ` kernel test robot [this message]
2024-12-06  3:55 ` [PATCH 0/4] Zone write plugging fixes Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202412061404.Utec5WgH-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.