All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Mike Snitzer <snitzer@kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>,
	dm-devel@lists.linux.dev
Cc: Christoph Hellwig <hch@lst.de>, Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 0/4] Zone write plugging fixes
Date: Fri, 6 Dec 2024 12:55:25 +0900	[thread overview]
Message-ID: <2e94a099-51fd-4eb6-a463-53cebbc71413@kernel.org> (raw)
In-Reply-To: <20241206015240.6862-1-dlemoal@kernel.org>

On 12/6/24 10:52, Damien Le Moal wrote:
> Jens,
> 
> These patches address potential issues with zone write plugging.
> The first 2 patches fix handling of REQ_NOWAIT BIOs as these can be
> "failed" after going through the zone write plugging and changing the
> target zone plug zone write pointer offset.
> 
> Patch 3 is a bigger fix and address a potential deadlock issue due to
> the zone write plugging internally issuing zone report operations to
> recover from write errors. This zone report operation is removed by this
> patch and replaced with an automatic recovery when the BIO issuer
> execute a zone report. This change in behavior results in a problem with
> REQ_OP_WRITE_ZEROES handling and failures in the dm-zoned device mapper.
> That is fixed in patch 4.

I forgot to mention that I will followup these fixes with a cleanup of the
report zones API and its callback function interface to clean it up as patch 4
introduces an indirect user callback call that is not very pretty.

> 
> Damien Le Moal (4):
>   block: Use a zone write plug BIO work for REQ_NOWAIT BIOs
>   block: Ignore REQ_NOWAIT for zone reset and zone finish operations
>   block: Prevent potential deadlocks in zone write plug error recovery
>   dm: Fix dm-zoned-reclaim zone write pointer alignment
> 
>  block/blk-zoned.c             | 507 +++++++++++++++-------------------
>  drivers/md/dm-zoned-reclaim.c |   4 +-
>  include/linux/blkdev.h        |   5 +-
>  3 files changed, 229 insertions(+), 287 deletions(-)
> 


-- 
Damien Le Moal
Western Digital Research

      parent reply	other threads:[~2024-12-06  3:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  1:52 [PATCH 0/4] Zone write plugging fixes Damien Le Moal
2024-12-06  1:52 ` [PATCH 1/4] block: Use a zone write plug BIO work for REQ_NOWAIT BIOs Damien Le Moal
2024-12-06  1:52 ` [PATCH 2/4] block: Ignore REQ_NOWAIT for zone reset and zone finish operations Damien Le Moal
2024-12-06  1:52 ` [PATCH 3/4] block: Prevent potential deadlocks in zone write plug error recovery Damien Le Moal
2024-12-06  1:52 ` [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment Damien Le Moal
2024-12-06  6:10   ` kernel test robot
2024-12-06  3:55 ` Damien Le Moal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e94a099-51fd-4eb6-a463-53cebbc71413@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.