Re: [PATCH -next v5 20/22] entry: Add arch_ptrace_report_syscall_entry/exit()

[kernel test robot <lkp@intel.com>]

Hi Jinjie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20241205]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/arm64-ptrace-Replace-interrupts_enabled-with-regs_irqs_disabled/20241206-183134
base:   next-20241205
patch link:    https://lore.kernel.org/r/20241206101744.4161990-21-ruanjinjie%40huawei.com
patch subject: [PATCH -next v5 20/22] entry: Add arch_ptrace_report_syscall_entry/exit()
config: i386-buildonly-randconfig-002-20241206 (https://download.01.org/0day-ci/archive/20241206/202412062236.pcOqNdrI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412062236.pcOqNdrI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412062236.pcOqNdrI-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> kernel/entry/syscall-common.c:30: warning: Function parameter or struct member 'regs' not described in 'arch_ptrace_report_syscall_entry'
>> kernel/entry/syscall-common.c:116: warning: Function parameter or struct member 'regs' not described in 'arch_ptrace_report_syscall_exit'
>> kernel/entry/syscall-common.c:116: warning: Function parameter or struct member 'step' not described in 'arch_ptrace_report_syscall_exit'


vim +30 kernel/entry/syscall-common.c

    19	
    20	/**
    21	 * arch_ptrace_report_syscall_entry - Architecture specific
    22	 *				      ptrace_report_syscall_entry().
    23	 *
    24	 * Invoked from syscall_trace_enter() to wrap ptrace_report_syscall_entry().
    25	 * Defaults to ptrace_report_syscall_entry.
    26	 *
    27	 * The main purpose is to support arch-specific ptrace_report_syscall_entry()
    28	 * implementation.
    29	 */
  > 30	static inline int arch_ptrace_report_syscall_entry(struct pt_regs *regs);
    31	
    32	#ifndef arch_ptrace_report_syscall_entry
    33	static inline int arch_ptrace_report_syscall_entry(struct pt_regs *regs)
    34	{
    35		return ptrace_report_syscall_entry(regs);
    36	}
    37	#endif
    38	
    39	long syscall_trace_enter(struct pt_regs *regs, long syscall,
    40					unsigned long work)
    41	{
    42		long ret = 0;
    43	
    44		/*
    45		 * Handle Syscall User Dispatch.  This must comes first, since
    46		 * the ABI here can be something that doesn't make sense for
    47		 * other syscall_work features.
    48		 */
    49		if (work & SYSCALL_WORK_SYSCALL_USER_DISPATCH) {
    50			if (syscall_user_dispatch(regs))
    51				return -1L;
    52		}
    53	
    54		/* Handle ptrace */
    55		if (work & (SYSCALL_WORK_SYSCALL_TRACE | SYSCALL_WORK_SYSCALL_EMU)) {
    56			ret = arch_ptrace_report_syscall_entry(regs);
    57			if (ret || (work & SYSCALL_WORK_SYSCALL_EMU))
    58				return -1L;
    59		}
    60	
    61		/* Do seccomp after ptrace, to catch any tracer changes. */
    62		if (work & SYSCALL_WORK_SECCOMP) {
    63			ret = __secure_computing(NULL);
    64			if (ret == -1L)
    65				return ret;
    66		}
    67	
    68		/* Either of the above might have changed the syscall number */
    69		syscall = syscall_get_nr(current, regs);
    70	
    71		if (unlikely(work & SYSCALL_WORK_SYSCALL_TRACEPOINT)) {
    72			trace_sys_enter(regs, syscall);
    73			/*
    74			 * Probes or BPF hooks in the tracepoint may have changed the
    75			 * system call number as well.
    76			 */
    77			syscall = syscall_get_nr(current, regs);
    78		}
    79	
    80		syscall_enter_audit(regs, syscall);
    81	
    82		return ret ? : syscall;
    83	}
    84	
    85	noinstr void syscall_enter_from_user_mode_prepare(struct pt_regs *regs)
    86	{
    87		enter_from_user_mode(regs);
    88		instrumentation_begin();
    89		local_irq_enable();
    90		instrumentation_end();
    91	}
    92	
    93	/*
    94	 * If SYSCALL_EMU is set, then the only reason to report is when
    95	 * SINGLESTEP is set (i.e. PTRACE_SYSEMU_SINGLESTEP).  This syscall
    96	 * instruction has been already reported in syscall_enter_from_user_mode().
    97	 */
    98	static inline bool report_single_step(unsigned long work)
    99	{
   100		if (work & SYSCALL_WORK_SYSCALL_EMU)
   101			return false;
   102	
   103		return work & SYSCALL_WORK_SYSCALL_EXIT_TRAP;
   104	}
   105	
   106	/**
   107	 * arch_ptrace_report_syscall_exit - Architecture specific
   108	 *				     ptrace_report_syscall_exit.
   109	 *
   110	 * Invoked from syscall_exit_work() to wrap ptrace_report_syscall_exit().
   111	 *
   112	 * The main purpose is to support arch-specific ptrace_report_syscall_exit
   113	 * implementation.
   114	 */
   115	static inline void arch_ptrace_report_syscall_exit(struct pt_regs *regs,
 > 116							   int step);
   117	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki