* [PATCH] xtensa/simdisk: Use str_write_read() helper in simdisk_transfer()
@ 2024-12-10 11:09 Thorsten Blum
2024-12-10 11:27 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-12-10 11:09 UTC (permalink / raw)
To: Chris Zankel, Max Filippov, Jens Axboe, Damien Le Moal,
Hannes Reinecke, Himanshu Madhani, Dan Williams
Cc: Thorsten Blum, linux-kernel
Remove hard-coded strings by using the str_write_read() helper.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/xtensa/platforms/iss/simdisk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c
index d6d2b533a574..6ed009318d24 100644
--- a/arch/xtensa/platforms/iss/simdisk.c
+++ b/arch/xtensa/platforms/iss/simdisk.c
@@ -14,6 +14,7 @@
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/blkdev.h>
#include <linux/bio.h>
#include <linux/proc_fs.h>
@@ -75,7 +76,7 @@ static void simdisk_transfer(struct simdisk *dev, unsigned long sector,
if (offset > dev->size || dev->size - offset < nbytes) {
pr_notice("Beyond-end %s (%ld %ld)\n",
- write ? "write" : "read", offset, nbytes);
+ str_write_read(write), offset, nbytes);
return;
}
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xtensa/simdisk: Use str_write_read() helper in simdisk_transfer()
2024-12-10 11:09 [PATCH] xtensa/simdisk: Use str_write_read() helper in simdisk_transfer() Thorsten Blum
@ 2024-12-10 11:27 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2024-12-10 11:27 UTC (permalink / raw)
To: Thorsten Blum
Cc: Chris Zankel, Jens Axboe, Damien Le Moal, Hannes Reinecke,
Himanshu Madhani, Dan Williams, linux-kernel
On Tue, Dec 10, 2024 at 3:10 AM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> Remove hard-coded strings by using the str_write_read() helper.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> arch/xtensa/platforms/iss/simdisk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to my xtensa tree.
--
Thanks.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-12-10 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-10 11:09 [PATCH] xtensa/simdisk: Use str_write_read() helper in simdisk_transfer() Thorsten Blum
2024-12-10 11:27 ` Max Filippov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.