All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>, Brian Foster <bfoster@redhat.com>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: remove _supported_fs
Date: Tue, 10 Dec 2024 08:00:33 -0500	[thread overview]
Message-ID: <20241210130033.GA1839653@mit.edu> (raw)
In-Reply-To: <20241210065900.1235379-1-hch@lst.de>

On Tue, Dec 10, 2024 at 07:58:24AM +0100, Christoph Hellwig wrote:
> this series removes the remaining _supported_fs calls and replaces them
> with a new _exclude_fs call.
> 
> The first patch removes a _supported_fs for a relatively new test from
> Brian that fails on other file systems.  We should still run it so that
> people have a chance to fix the corruption, so I think this make sense.
> 
> Then the ext4 directory is split so that the shared extN tests have their
> own directory, and then it finally does the switch over now that now many
> _supported_fs calls are left.

Hmm, instead of doing this (would require hard-coding support for ext2
and ext3 file systems needing to use ext-common), why not just have
special-case code which causes ext2 and ext3 file systems to include
the ext4 group, and then we'll have _exclude_fs declaractions as
needed for ext2 and ext3?

After all, ext3 has been removed except for the very oldest LTS
kernels (and I dount anyone is actually testing ext3 using xfstests
these days), and ext2 is not used by most distributions (they use
CONFIG_EXT4_USE_EXT2) and the reason why we've kept it around is that
it's a realtively simple file system that still uses the more modern,
non-legacy vfs/mm interfaces.

So it might not be worth it to move a bunch of tests and creating a
new (somewhat ugly) group, ext4-common, IMO.

Cheers,

						- Ted

  parent reply	other threads:[~2024-12-10 13:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  6:58 remove _supported_fs Christoph Hellwig
2024-12-10  6:58 ` [PATCH 1/4] generic/363: remove _supported_fs xfs Christoph Hellwig
2024-12-10 13:15   ` Brian Foster
2024-12-10  6:58 ` [PATCH 2/4] common: remove the $FSYP check in _cleanup_dump Christoph Hellwig
2024-12-10  6:58 ` [PATCH 3/4] ext-common: create a new test directory for ext* common tests Christoph Hellwig
2024-12-18 15:59   ` Jan Kara
2024-12-23  8:38     ` Christoph Hellwig
2024-12-10  6:58 ` [PATCH 4/4] replace _supported_fs with _exclude_fs Christoph Hellwig
2024-12-10 13:00 ` Theodore Ts'o [this message]
2024-12-10 16:08   ` remove _supported_fs Christoph Hellwig
2024-12-19 17:02     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210130033.GA1839653@mit.edu \
    --to=tytso@mit.edu \
    --cc=bfoster@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-ext4@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.