All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
	Brian Foster <bfoster@redhat.com>,
	fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: remove _supported_fs
Date: Tue, 10 Dec 2024 17:08:27 +0100	[thread overview]
Message-ID: <20241210160827.GA26559@lst.de> (raw)
In-Reply-To: <20241210130033.GA1839653@mit.edu>

On Tue, Dec 10, 2024 at 08:00:33AM -0500, Theodore Ts'o wrote:
> Hmm, instead of doing this (would require hard-coding support for ext2
> and ext3 file systems needing to use ext-common), why not just have
> special-case code which causes ext2 and ext3 file systems to include
> the ext4 group, and then we'll have _exclude_fs declaractions as
> needed for ext2 and ext3?

That's what the current tree does and what I want to get away from.
I think the diffstat alone makes it pretty clear that moving away
form that is a benefit, and it's also a lot easier to understand than
that ext2 and ext3 magically run ext4 tests.

> After all, ext3 has been removed except for the very oldest LTS
> kernels (and I dount anyone is actually testing ext3 using xfstests
> these days),

The tests also cover using ext4 as the ext3 driver.

> So it might not be worth it to move a bunch of tests and creating a
> new (somewhat ugly) group, ext4-common, IMO.

І'll let Jan speak up, but the only thing cleaner would be to drop
the ext2/3 coverage, but І don't think the extra group is too bad,
and certainly much better than what we currently have.


  reply	other threads:[~2024-12-10 16:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-10  6:58 remove _supported_fs Christoph Hellwig
2024-12-10  6:58 ` [PATCH 1/4] generic/363: remove _supported_fs xfs Christoph Hellwig
2024-12-10 13:15   ` Brian Foster
2024-12-10  6:58 ` [PATCH 2/4] common: remove the $FSYP check in _cleanup_dump Christoph Hellwig
2024-12-10  6:58 ` [PATCH 3/4] ext-common: create a new test directory for ext* common tests Christoph Hellwig
2024-12-18 15:59   ` Jan Kara
2024-12-23  8:38     ` Christoph Hellwig
2024-12-10  6:58 ` [PATCH 4/4] replace _supported_fs with _exclude_fs Christoph Hellwig
2024-12-10 13:00 ` remove _supported_fs Theodore Ts'o
2024-12-10 16:08   ` Christoph Hellwig [this message]
2024-12-19 17:02     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241210160827.GA26559@lst.de \
    --to=hch@lst.de \
    --cc=bfoster@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.