From: Andrei Simion <andrei.simion@microchip.com>
To: <balakrishnan.s@microchip.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
alexandre.belloni@bootlin.com, robh@kernel.org,
linux-kernel@vger.kernel.org, claudiu.beznea@tuxon.dev,
linux-sound@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, andrei.simion@microchip.com,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema
Date: Wed, 11 Dec 2024 14:03:17 +0200 [thread overview]
Message-ID: <20241211120316.22494-1-andrei.simion@microchip.com> (raw)
In-Reply-To: <20241211-sound-atmel-at91sam9g20ek-v2-1-86a0e31e6af9@microchip.com>
Hi,
On 11.12.2024 11:46, Balakrishnan Sambath wrote:
> Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml
> based json-schema.Change file name to match json-scheme naming.
>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
> ---
> Changes in v2:
> - Add missing CODEC pin options to 'atmel,audio-routing' items.
> - Drop 'minItems' from 'atmel,audio-routing' since enum defines valid connections.
> - Add subsystem tag to subject.
> - Add blank line between properties and fix typo.
> - Add audio complex description.
> - Link to v1: https://lore.kernel.org/lkml/20240214-at91sam9g20ek-wm8731-yaml-v1-1-33333e17383b@microchip.com
> ---
> .../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 70 ++++++++++++++++++++++
> .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 --------
> 2 files changed, 70 insertions(+), 26 deletions(-)
I recommend you to remove from title the word 'sound'.
You can check the commit history of the Documentation/devicetree/bindings/sound/
before you write the commit title.
Best Regards,
Andrei Simion
WARNING: multiple messages have this Message-ID (diff)
From: Andrei Simion <andrei.simion@microchip.com>
To: <balakrishnan.s@microchip.com>
Cc: <alexandre.belloni@bootlin.com>, <andrei.simion@microchip.com>,
<broonie@kernel.org>, <claudiu.beznea@tuxon.dev>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<krzk+dt@kernel.org>, <lgirdwood@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
<nicolas.ferre@microchip.com>, <robh@kernel.org>
Subject: Re: [PATCH v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema
Date: Wed, 11 Dec 2024 14:03:17 +0200 [thread overview]
Message-ID: <20241211120316.22494-1-andrei.simion@microchip.com> (raw)
In-Reply-To: <20241211-sound-atmel-at91sam9g20ek-v2-1-86a0e31e6af9@microchip.com>
Hi,
On 11.12.2024 11:46, Balakrishnan Sambath wrote:
> Convert atmel-at91sam9g20ek-wm8731-audio DT binding to yaml
> based json-schema.Change file name to match json-scheme naming.
>
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@microchip.com>
> ---
> Changes in v2:
> - Add missing CODEC pin options to 'atmel,audio-routing' items.
> - Drop 'minItems' from 'atmel,audio-routing' since enum defines valid connections.
> - Add subsystem tag to subject.
> - Add blank line between properties and fix typo.
> - Add audio complex description.
> - Link to v1: https://lore.kernel.org/lkml/20240214-at91sam9g20ek-wm8731-yaml-v1-1-33333e17383b@microchip.com
> ---
> .../bindings/sound/atmel,at91sam9g20ek-wm8731.yaml | 70 ++++++++++++++++++++++
> .../sound/atmel-at91sam9g20ek-wm8731-audio.txt | 26 --------
> 2 files changed, 70 insertions(+), 26 deletions(-)
I recommend you to remove from title the word 'sound'.
You can check the commit history of the Documentation/devicetree/bindings/sound/
before you write the commit title.
Best Regards,
Andrei Simion
next prev parent reply other threads:[~2024-12-11 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 9:46 [PATCH v2] ASoC: dt-bindings: sound: atmel-at91sam9g20ek: convert to json-schema Balakrishnan Sambath
2024-12-11 11:21 ` Rob Herring (Arm)
2024-12-11 11:21 ` Rob Herring (Arm)
2024-12-11 11:29 ` Krzysztof Kozlowski
2024-12-12 6:29 ` Balakrishnan.S
2024-12-11 12:03 ` Andrei Simion [this message]
2024-12-11 12:03 ` Andrei Simion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211120316.22494-1-andrei.simion@microchip.com \
--to=andrei.simion@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=balakrishnan.s@microchip.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.