All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd: Require CONFIG_HOTPLUG_PCI_PCIE for BOCO
@ 2024-12-11 15:56 Mario Limonciello
  2024-12-11 20:08 ` Alex Deucher
  0 siblings, 1 reply; 8+ messages in thread
From: Mario Limonciello @ 2024-12-11 15:56 UTC (permalink / raw)
  To: amd-gfx; +Cc: Mario Limonciello, Gabriel Marcano

From: Mario Limonciello <mario.limonciello@amd.com>

If the kernel hasn't been compiled with PCIe hotplug support this
can lead to problems with dGPUs that use BOCO because they effectively
drop off the bus.

To prevent issues, disable BOCO support when compiled without PCIe hotplug.

Reported-by: Gabriel Marcano <gabemarcano@yahoo.com>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1707#note_2696862
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 764d41434a82f..7db796ebb967e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -419,6 +419,9 @@ bool amdgpu_device_supports_boco(struct drm_device *dev)
 {
 	struct amdgpu_device *adev = drm_to_adev(dev);
 
+	if (!IS_ENABLED(CONFIG_HOTPLUG_PCI_PCIE))
+		return false;
+
 	if (adev->has_pr3 ||
 	    ((adev->flags & AMD_IS_PX) && amdgpu_is_atpx_hybrid()))
 		return true;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-12-12 14:04 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 15:56 [PATCH] drm/amd: Require CONFIG_HOTPLUG_PCI_PCIE for BOCO Mario Limonciello
2024-12-11 20:08 ` Alex Deucher
2024-12-11 20:19   ` Mario Limonciello
2024-12-11 21:41     ` Alex Deucher
2024-12-11 21:43       ` Mario Limonciello
2024-12-11 22:03         ` Mario Limonciello
2024-12-11 22:16         ` Gabriel Marcano
2024-12-11 22:18           ` Mario Limonciello

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.