All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/gpu/drm/mediatek/mtk_drm_drv.c:1016 mtk_drm_of_ddp_path_build() error: uninitialized symbol 'ret'.
@ 2024-12-11 15:43 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-12-11 15:43 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>
CC: Dave Airlie <airlied@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   f92f4749861b06fed908d336b4dee1326003291b
commit: 9bed494cd627cecab1114ce0416c9ddb3ad66064 Merge tag 'mediatek-drm-next-6.13' of https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux into drm-next
date:   5 weeks ago
:::::: branch date: 13 hours ago
:::::: commit date: 5 weeks ago
config: microblaze-randconfig-r073-20241210 (https://download.01.org/0day-ci/archive/20241211/202412112300.L1cv0fpw-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 14.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412112300.L1cv0fpw-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/mediatek/mtk_drm_drv.c:1016 mtk_drm_of_ddp_path_build() error: uninitialized symbol 'ret'.

vim +/ret +1016 drivers/gpu/drm/mediatek/mtk_drm_drv.c

4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   991  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   992  static int mtk_drm_of_ddp_path_build(struct device *dev, struct device_node *node,
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   993  				     struct mtk_mmsys_driver_data *data)
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   994  {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   995  	struct device_node *ep_node;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   996  	struct of_endpoint of_ep;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   997  	bool output_present[MAX_CRTC] = { false };
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   998  	int ret;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17   999  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1000  	for_each_endpoint_of_node(node, ep_node) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1001  		ret = of_graph_parse_endpoint(ep_node, &of_ep);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1002  		if (ret) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1003  			dev_err_probe(dev, ret, "Cannot parse endpoint\n");
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1004  			break;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1005  		}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1006  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1007  		if (of_ep.id >= MAX_CRTC) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1008  			ret = dev_err_probe(dev, -EINVAL,
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1009  					    "Invalid endpoint%u number\n", of_ep.port);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1010  			break;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1011  		}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1012  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1013  		output_present[of_ep.id] = true;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1014  	}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1015  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17 @1016  	if (ret) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1017  		of_node_put(ep_node);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1018  		return ret;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1019  	}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1020  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1021  	if (output_present[CRTC_MAIN]) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1022  		ret = mtk_drm_of_ddp_path_build_one(dev, CRTC_MAIN,
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1023  						    &data->main_path, &data->main_len);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1024  		if (ret && ret != -ENODEV)
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1025  			return ret;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1026  	}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1027  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1028  	if (output_present[CRTC_EXT]) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1029  		ret = mtk_drm_of_ddp_path_build_one(dev, CRTC_EXT,
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1030  						    &data->ext_path, &data->ext_len);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1031  		if (ret && ret != -ENODEV)
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1032  			return ret;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1033  	}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1034  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1035  	if (output_present[CRTC_THIRD]) {
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1036  		ret = mtk_drm_of_ddp_path_build_one(dev, CRTC_THIRD,
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1037  						    &data->third_path, &data->third_len);
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1038  		if (ret && ret != -ENODEV)
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1039  			return ret;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1040  	}
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1041  
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1042  	return 0;
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1043  }
4c932840db1de4e AngeloGioacchino Del Regno 2024-10-17  1044  

:::::: The code at line 1016 was first introduced by commit
:::::: 4c932840db1de4ea9639eceaaf6d59415b8a7d59 drm/mediatek: Implement OF graphs support for display paths

:::::: TO: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
:::::: CC: Chun-Kuang Hu <chunkuang.hu@kernel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-12-11 15:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 15:43 drivers/gpu/drm/mediatek/mtk_drm_drv.c:1016 mtk_drm_of_ddp_path_build() error: uninitialized symbol 'ret' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.