From: Christoph Hellwig <hch@lst.de>
To: Keisuke Nishimura <keisuke.nishimura@inria.fr>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Allocate memory for xa_store in advance in nvme_get_effects_log
Date: Thu, 12 Dec 2024 07:27:49 +0100 [thread overview]
Message-ID: <20241212062749.GA5718@lst.de> (raw)
In-Reply-To: <20241202124239.49894-1-keisuke.nishimura@inria.fr>
On Mon, Dec 02, 2024 at 01:42:40PM +0100, Keisuke Nishimura wrote:
> + ret = xa_reserve(&ctrl->cels, csi, GFP_KERNEL);
> + if (ret) {
> + kfree(cel);
> + return ret;
> + }
> +
> ret = nvme_get_log(ctrl, 0x00, NVME_LOG_CMD_EFFECTS, 0, csi,
> cel, sizeof(*cel), 0);
There isn't really any point in doing a xa_reserve here vs simply
handling the xa_store error a bit below.
next prev parent reply other threads:[~2024-12-12 6:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 12:42 [PATCH] nvme: Allocate memory for xa_store in advance in nvme_get_effects_log Keisuke Nishimura
2024-12-12 6:27 ` Christoph Hellwig [this message]
2024-12-16 13:06 ` Keisuke Nishimura
2024-12-16 15:52 ` Christoph Hellwig
2024-12-20 11:50 ` Keisuke Nishimura
2024-12-20 12:00 ` [PATCH] nvme: Add error check for xa_store " Keisuke Nishimura
2024-12-24 10:11 ` Sagi Grimberg
2025-01-03 6:52 ` Christoph Hellwig
2025-01-07 16:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212062749.GA5718@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=keisuke.nishimura@inria.fr \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.