From: Christoph Hellwig <hch@lst.de>
To: Keisuke Nishimura <keisuke.nishimura@inria.fr>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: Allocate memory for xa_store in advance in nvme_get_effects_log
Date: Mon, 16 Dec 2024 16:52:29 +0100 [thread overview]
Message-ID: <20241216155229.GC23786@lst.de> (raw)
In-Reply-To: <d0b96f78-7538-4bf9-acec-711e3b0b912d@inria.fr>
On Mon, Dec 16, 2024 at 02:06:50PM +0100, Keisuke Nishimura wrote:
> Without this xa_reserve(), if xa_store() fails, we cannot store cel after
> calling nvme_get_log() which can have side effects. My intention is to
> ensure xa_store() succeeds first and, if not, return early before invoking
> nvme_get_log().
While reading various log pages can have side effects there shouldn't be
any for the Command Supported and Effects log page.
> But I am not very familiar with this code. If it is okay to check after the
> nvme_get_log(), I will send the patch soon.
I think it should be fine, but I'm happy to wait for more opinions.
next prev parent reply other threads:[~2024-12-16 15:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 12:42 [PATCH] nvme: Allocate memory for xa_store in advance in nvme_get_effects_log Keisuke Nishimura
2024-12-12 6:27 ` Christoph Hellwig
2024-12-16 13:06 ` Keisuke Nishimura
2024-12-16 15:52 ` Christoph Hellwig [this message]
2024-12-20 11:50 ` Keisuke Nishimura
2024-12-20 12:00 ` [PATCH] nvme: Add error check for xa_store " Keisuke Nishimura
2024-12-24 10:11 ` Sagi Grimberg
2025-01-03 6:52 ` Christoph Hellwig
2025-01-07 16:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216155229.GC23786@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=keisuke.nishimura@inria.fr \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.