From: Christoph Hellwig <hch@lst.de>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: use dev_err() to make message more useful
Date: Thu, 12 Dec 2024 08:29:18 +0100 [thread overview]
Message-ID: <20241212072918.GA7039@lst.de> (raw)
In-Reply-To: <551518fe326d5cff08aa2df1b7d69fcd689fdd96.1733988012.git.baruch@tkos.co.il>
On Thu, Dec 12, 2024 at 09:20:12AM +0200, Baruch Siach wrote:
> + req = nvme_find_rq(&anv->ctrl, apple_nvme_queue_tagset(anv, q), command_id);
Please avoid the overly long lines. Note that the nvme_ctrl has pointers
to the admin and io tagset, so you can actuall simply the second paramter
here by just passing a 'bool admin_queue' and remove the
apple_nvme_queue_tagset, nvme_queue_tagset, nvme_rdma_tagset and
nvme_loop_tagset helpers entirely. The TCP one still has other users
by might be worth looking into as a follow up.
next prev parent reply other threads:[~2024-12-12 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 7:20 [PATCH] nvme: use dev_err() to make message more useful Baruch Siach
2024-12-12 7:29 ` Christoph Hellwig [this message]
2024-12-16 16:50 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212072918.GA7039@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=baruch@tkos.co.il \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.