Re: [PATCH] nvme: use dev_err() to make message more useful

[Baruch Siach <baruch@tkos.co.il>]

Hi Christoph,

On Thu, Dec 12 2024, Christoph Hellwig wrote:
> On Thu, Dec 12, 2024 at 09:20:12AM +0200, Baruch Siach wrote:
>> +	req = nvme_find_rq(&anv->ctrl, apple_nvme_queue_tagset(anv, q), command_id);
>
> Please avoid the overly long lines.  Note that the nvme_ctrl has pointers
> to the admin and io tagset, so you can actuall simply the second paramter
> here by just passing a 'bool admin_queue' and remove the
> apple_nvme_queue_tagset, nvme_queue_tagset, nvme_rdma_tagset and
> nvme_loop_tagset helpers entirely.  The TCP one still has other users
> by might be worth looking into as a follow up.

Passing 'bool admin_queue' is not enough. You also need qid to select
blk_mq_tags in the tagset.tags[] array.

Is it worth it?

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -