* [PATCH] target/arm: remove redundant code
@ 2024-12-12 12:06 gerben
2024-12-12 13:26 ` Richard Henderson
2024-12-16 12:52 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: gerben @ 2024-12-12 12:06 UTC (permalink / raw)
To: peter.maydell, richard.henderson, qemu-devel; +Cc: sdl.qemu, Denis Rastyogin
From: Denis Rastyogin <gerben@altlinux.org>
This call is redundant as it only retrieves a value that is not used further.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Denis Rastyogin <gerben@altlinux.org>
---
target/arm/vfp_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c
index 62638d2b1f..f020c3c34b 100644
--- a/target/arm/vfp_helper.c
+++ b/target/arm/vfp_helper.c
@@ -1095,8 +1095,6 @@ float64 HELPER(rintd)(float64 x, void *fp_status)
ret = float64_round_to_int(x, fp_status);
- new_flags = get_float_exception_flags(fp_status);
-
/* Suppress any inexact exceptions the conversion produced */
if (!(old_flags & float_flag_inexact)) {
new_flags = get_float_exception_flags(fp_status);
--
2.42.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] target/arm: remove redundant code
2024-12-12 12:06 [PATCH] target/arm: remove redundant code gerben
@ 2024-12-12 13:26 ` Richard Henderson
2024-12-16 12:52 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-12-12 13:26 UTC (permalink / raw)
To: gerben, peter.maydell, qemu-devel; +Cc: sdl.qemu
On 12/12/24 06:06, gerben@altlinux.org wrote:
> From: Denis Rastyogin <gerben@altlinux.org>
>
> This call is redundant as it only retrieves a value that is not used further.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Rastyogin <gerben@altlinux.org>
> ---
> target/arm/vfp_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/arm/vfp_helper.c b/target/arm/vfp_helper.c
> index 62638d2b1f..f020c3c34b 100644
> --- a/target/arm/vfp_helper.c
> +++ b/target/arm/vfp_helper.c
> @@ -1095,8 +1095,6 @@ float64 HELPER(rintd)(float64 x, void *fp_status)
>
> ret = float64_round_to_int(x, fp_status);
>
> - new_flags = get_float_exception_flags(fp_status);
> -
> /* Suppress any inexact exceptions the conversion produced */
> if (!(old_flags & float_flag_inexact)) {
> new_flags = get_float_exception_flags(fp_status);
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/arm: remove redundant code
2024-12-12 12:06 [PATCH] target/arm: remove redundant code gerben
2024-12-12 13:26 ` Richard Henderson
@ 2024-12-16 12:52 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2024-12-16 12:52 UTC (permalink / raw)
To: gerben; +Cc: richard.henderson, qemu-devel, sdl.qemu
On Thu, 12 Dec 2024 at 12:06, <gerben@altlinux.org> wrote:
>
> From: Denis Rastyogin <gerben@altlinux.org>
>
> This call is redundant as it only retrieves a value that is not used further.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Denis Rastyogin <gerben@altlinux.org>
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-16 12:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-12 12:06 [PATCH] target/arm: remove redundant code gerben
2024-12-12 13:26 ` Richard Henderson
2024-12-16 12:52 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.