All of lore.kernel.org
 help / color / mirror / Atom feed
* drivers/acpi/numa/srat.c:178:5-41: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_RINTC_ENABLED ))
@ 2024-12-12  7:22 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-12-12  7:22 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Julia Lawall

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Haibo Xu <haibo1.xu@intel.com>
CC: Palmer Dabbelt <palmer@rivosinc.com>
CC: Sunil V L <sunilvl@ventanamicro.com>
CC: Hanjun Guo <guohanjun@huawei.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   231825b2e1ff6ba799c5eaf396d3ab2354e37c6b
commit: 39494aec8a0454f9e8a68d2422d3bd4e5c5ee0c7 ACPI: NUMA: Add handler for SRAT RINTC affinity structure
date:   5 months ago
:::::: branch date: 9 hours ago
:::::: commit date: 5 months ago
config: x86_64-randconfig-104-20241212 (https://download.01.org/0day-ci/archive/20241212/202412121554.ld4S90Hf-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202412121554.ld4S90Hf-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
   drivers/acpi/numa/srat.c:94:5-39: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_CPU_ENABLED ))
   drivers/acpi/numa/srat.c:123:5-39: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_CPU_ENABLED ))
   drivers/acpi/numa/srat.c:154:5-52: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED ))
   drivers/acpi/numa/srat.c:165:4-51: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED ))
   drivers/acpi/numa/srat.c:135:5-40: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_GICC_ENABLED ))
   drivers/acpi/numa/srat.c:107:5-39: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_MEM_ENABLED ))
>> drivers/acpi/numa/srat.c:178:5-41: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_RINTC_ENABLED ))

vim +178 drivers/acpi/numa/srat.c

762834e8bf46bf drivers/acpi/numa.c      Yasunori Goto       2006-06-23   82  
ae2c6dcf90c5a9 drivers/acpi/numa.c      David Rientjes      2007-07-21   83  static void __init
ae2c6dcf90c5a9 drivers/acpi/numa.c      David Rientjes      2007-07-21   84  acpi_table_print_srat_entry(struct acpi_subtable_header *header)
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   85  {
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   86  	switch (header->type) {
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   87  	case ACPI_SRAT_TYPE_CPU_AFFINITY:
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   88  		{
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   89  			struct acpi_srat_cpu_affinity *p =
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   90  			    (struct acpi_srat_cpu_affinity *)header;
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24   91  			pr_debug("SRAT Processor (id[0x%02x] eid[0x%02x]) in proximity domain %d %s\n",
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   92  				 p->apic_id, p->local_sapic_eid,
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   93  				 p->proximity_domain_lo,
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   94  				 (p->flags & ACPI_SRAT_CPU_ENABLED) ?
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24   95  				 "enabled" : "disabled");
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   96  		}
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   97  		break;
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16   98  
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02   99  	case ACPI_SRAT_TYPE_MEMORY_AFFINITY:
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  100  		{
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02  101  			struct acpi_srat_mem_affinity *p =
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02  102  			    (struct acpi_srat_mem_affinity *)header;
b9ced18acf68df drivers/acpi/numa.c      Chao Fan            2018-12-26  103  			pr_debug("SRAT Memory (0x%llx length 0x%llx) in proximity domain %d %s%s%s\n",
b9ced18acf68df drivers/acpi/numa.c      Chao Fan            2018-12-26  104  				 (unsigned long long)p->base_address,
b9ced18acf68df drivers/acpi/numa.c      Chao Fan            2018-12-26  105  				 (unsigned long long)p->length,
19d0cfe9ddfdf7 drivers/acpi/numa.c      Bob Moore           2008-06-10  106  				 p->proximity_domain,
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02  107  				 (p->flags & ACPI_SRAT_MEM_ENABLED) ?
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02  108  				 "enabled" : "disabled",
15a58ed1214293 drivers/acpi/numa.c      Alexey Starikovskiy 2007-02-02  109  				 (p->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) ?
208f6cc9e5f83c drivers/acpi/numa.c      Davidlohr Bueso     2013-01-09  110  				 " hot-pluggable" : "",
208f6cc9e5f83c drivers/acpi/numa.c      Davidlohr Bueso     2013-01-09  111  				 (p->flags & ACPI_SRAT_MEM_NON_VOLATILE) ?
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24  112  				 " non-volatile" : "");
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  113  		}
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  114  		break;
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  115  
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  116  	case ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY:
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  117  		{
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  118  			struct acpi_srat_x2apic_cpu_affinity *p =
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  119  			    (struct acpi_srat_x2apic_cpu_affinity *)header;
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24  120  			pr_debug("SRAT Processor (x2apicid[0x%08x]) in proximity domain %d %s\n",
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  121  				 p->apic_id,
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  122  				 p->proximity_domain,
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  123  				 (p->flags & ACPI_SRAT_CPU_ENABLED) ?
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24  124  				 "enabled" : "disabled");
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  125  		}
7237d3de78ff89 drivers/acpi/numa.c      Suresh Siddha       2009-03-30  126  		break;
3dda448189af1c drivers/acpi/numa.c      Hanjun Guo          2016-05-24  127  
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  128  	case ACPI_SRAT_TYPE_GICC_AFFINITY:
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  129  		{
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  130  			struct acpi_srat_gicc_affinity *p =
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  131  			    (struct acpi_srat_gicc_affinity *)header;
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  132  			pr_debug("SRAT Processor (acpi id[0x%04x]) in proximity domain %d %s\n",
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  133  				 p->acpi_processor_uid,
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  134  				 p->proximity_domain,
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  135  				 (p->flags & ACPI_SRAT_GICC_ENABLED) ?
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  136  				 "enabled" : "disabled");
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  137  		}
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  138  		break;
4bac6fa73db77d drivers/acpi/numa.c      Hanjun Guo          2016-06-17  139  
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  140  	case ACPI_SRAT_TYPE_GENERIC_AFFINITY:
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  141  	{
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  142  		struct acpi_srat_generic_affinity *p =
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  143  			(struct acpi_srat_generic_affinity *)header;
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  144  
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  145  		if (p->device_handle_type == 0) {
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  146  			/*
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  147  			 * For pci devices this may be the only place they
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  148  			 * are assigned a proximity domain
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  149  			 */
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  150  			pr_debug("SRAT Generic Initiator(Seg:%u BDF:%u) in proximity domain %d %s\n",
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  151  				 *(u16 *)(&p->device_handle[0]),
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  152  				 *(u16 *)(&p->device_handle[2]),
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  153  				 p->proximity_domain,
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  154  				 (p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED) ?
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  155  				"enabled" : "disabled");
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  156  		} else {
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  157  			/*
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  158  			 * In this case we can rely on the device having a
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  159  			 * proximity domain reference
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  160  			 */
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  161  			pr_debug("SRAT Generic Initiator(HID=%.8s UID=%.4s) in proximity domain %d %s\n",
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  162  				(char *)(&p->device_handle[0]),
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  163  				(char *)(&p->device_handle[8]),
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  164  				p->proximity_domain,
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  165  				(p->flags & ACPI_SRAT_GENERIC_AFFINITY_ENABLED) ?
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  166  				"enabled" : "disabled");
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  167  		}
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  168  	}
894c26a1c274b8 drivers/acpi/numa/srat.c Jonathan Cameron    2020-09-30  169  	break;
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  170  
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  171  	case ACPI_SRAT_TYPE_RINTC_AFFINITY:
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  172  		{
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  173  			struct acpi_srat_rintc_affinity *p =
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  174  			    (struct acpi_srat_rintc_affinity *)header;
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  175  			pr_debug("SRAT Processor (acpi id[0x%04x]) in proximity domain %d %s\n",
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  176  				 p->acpi_processor_uid,
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  177  				 p->proximity_domain,
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13 @178  				 (p->flags & ACPI_SRAT_RINTC_ENABLED) ?
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  179  				 "enabled" : "disabled");
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  180  		}
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  181  		break;
39494aec8a0454 drivers/acpi/numa/srat.c Haibo Xu            2024-06-13  182  
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  183  	default:
ac906a6d56b742 drivers/acpi/numa.c      Hanjun Guo          2016-05-24  184  		pr_warn("Found unsupported SRAT entry (type = 0x%x)\n",
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  185  			header->type);
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  186  		break;
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  187  	}
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  188  }
^1da177e4c3f41 drivers/acpi/numa.c      Linus Torvalds      2005-04-16  189  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-12-12  7:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-12  7:22 drivers/acpi/numa/srat.c:178:5-41: opportunity for str_enabled_disabled(( p -> flags & ACPI_SRAT_RINTC_ENABLED )) kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.