[Buildroot] [PATCH] package/gdb: add hash of licence files

[Buildroot] [PATCH] package/gdb: add hash of licence files

[Thomas Bonnefille via buildroot]

Adds sha512 hash of the license files for GDB.

Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
---
 package/gdb/gdb.hash | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/gdb/gdb.hash b/package/gdb/gdb.hash
index 6cf55a675dae3d373f9b32f795aec469049464f0..0fcfd314a01bef78b971a0fa52bf50e7c44a3dca 100644
--- a/package/gdb/gdb.hash
+++ b/package/gdb/gdb.hash
@@ -5,3 +5,9 @@ sha512  0217434073023a8b8316088bf3ee95d53a1b6a7897f6269095429016a8900f9a05e130c3
 
 # Locally calculated (fetched from Github)
 sha512  3518b47d5c11d1fb478ee152bde1719363f9391db73f3b9f5491217c17742bef8ebca6a51a40302dfaa9476c5a32a8b8f70a4bf64289422dea5f750ae53ab88d  gdb-arc-2023.09-release.tar.gz
+
+# Locally calculated (fetched from gcc.gnu.org)
+sha512 cb0a4f39c66d8d6bf668b2e989fc7741b5da50a48cf69921556e87c8d2ab648d23189628e5a26d7b86b9db47c8593e0e4bc6e9881ec03ca8d2ed62d8bd761e84  COPYING
+sha512 7633623b66b5e686bb94dd96a7cdb5a7e5ee00e87004fab416a5610d59c62badaf512a2e26e34e2455b7ed6b76690d2cd47464836d7d85d78b51d50f7e933d5c  COPYING3
+sha512 12291afdbc1daf063a0829e93fbd95fb8eac599cfb962408dd900ce261dc1117d3ae2b7fd27b90c3ed69e57c4398a0b678b0ffd1df8ba7c1ed02d0280825d3af  COPYING3.LIB
+sha512 85385eef52429877ad2fbf4cdffaad6e7e587aa030985c53ebbab329e3ba83dae5a72c3940941061f2160d506743abfef062b8d20ccd98d976edf8c94eccd77f  COPYING.LIB

---
base-commit: c12008448e6d0f78774b386fb0f66a14c3064eed
change-id: 20241211-add_gdb_hash-34bc5fddec5d

Best regards,
-- 
Thomas Bonnefille <thomas.bonnefille@bootlin.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/gdb: add hash of licence files

[Thomas Petazzoni via buildroot]

Hello Thomas,

Thanks for the patch! See some comments below.

On Wed, 11 Dec 2024 18:42:50 +0100
Thomas Bonnefille <thomas.bonnefille@bootlin.com> wrote:

> Adds sha512 hash of the license files for GDB.
> 
> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>

This patch triggers some "make check-package" warnings.

WARNING: package/gdb/gdb.hash:10: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:11: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:12: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)
WARNING: package/gdb/gdb.hash:13: separation does not match expectation (https://nightly.buildroot.org/#adding-packages-hash)

To help avoid such warnings, I have https://paste.ack.tf/0859f0
in .git/hooks/post-commit.

Also, we normally use sha256 for license files hashes, and in fact even
for locally calculated hashes in general. We only use sha512 when it's
what provided by upstream. I guess sha512 has been used here for the
special ARC version of GDB because sha512 was used for the other gdb
versions who hash is provided by upstream. But I believe for the
license file we should be consistent with what we do in other packages,
and use sha256.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot