From: Simon Horman <horms@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: netdev@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 2/3] ice: lower the latency of GNSS reads
Date: Fri, 13 Dec 2024 11:54:38 +0000 [thread overview]
Message-ID: <20241213115438.GP2110@kernel.org> (raw)
In-Reply-To: <20241212153417.165919-3-mschmidt@redhat.com>
On Thu, Dec 12, 2024 at 04:34:16PM +0100, Michal Schmidt wrote:
> The E810 is connected to the u-blox GNSS module over I2C. The ice driver
> periodically (every ~20ms) sends AdminQ commands to poll the u-blox for
> available data. Most of the time, there's no data. When the u-blox
> finally responds that data is available, usually it's around 800 bytes.
> It can be more or less, depending on how many NMEA messages were
> configured using ubxtool. ice then proceeds to read all the data.
> AdminQ and I2C are slow. The reading is performed in chunks of 15 bytes.
> ice reads all of the data before passing it to the kernel GNSS subsystem
> and onwards to userspace.
>
> Improve the NMEA message receiving latency. Pass each 15-bytes chunk to
> userspace as soon as it's received.
>
> Tested-by: Miroslav Lichvar <mlichvar@redhat.com>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Miroslav Lichvar <mlichvar@redhat.com>
Subject: Re: [PATCH iwl-next 2/3] ice: lower the latency of GNSS reads
Date: Fri, 13 Dec 2024 11:54:38 +0000 [thread overview]
Message-ID: <20241213115438.GP2110@kernel.org> (raw)
In-Reply-To: <20241212153417.165919-3-mschmidt@redhat.com>
On Thu, Dec 12, 2024 at 04:34:16PM +0100, Michal Schmidt wrote:
> The E810 is connected to the u-blox GNSS module over I2C. The ice driver
> periodically (every ~20ms) sends AdminQ commands to poll the u-blox for
> available data. Most of the time, there's no data. When the u-blox
> finally responds that data is available, usually it's around 800 bytes.
> It can be more or less, depending on how many NMEA messages were
> configured using ubxtool. ice then proceeds to read all the data.
> AdminQ and I2C are slow. The reading is performed in chunks of 15 bytes.
> ice reads all of the data before passing it to the kernel GNSS subsystem
> and onwards to userspace.
>
> Improve the NMEA message receiving latency. Pass each 15-bytes chunk to
> userspace as soon as it's received.
>
> Tested-by: Miroslav Lichvar <mlichvar@redhat.com>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-12-13 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 15:34 [Intel-wired-lan] [PATCH iwl-next 0/3] ice: GNSS reading improvements Michal Schmidt
2024-12-12 15:34 ` Michal Schmidt
2024-12-12 15:34 ` [Intel-wired-lan] [PATCH iwl-next 1/3] ice: downgrade warning about gnss_insert_raw to debug level Michal Schmidt
2024-12-12 15:34 ` Michal Schmidt
2024-12-13 11:54 ` [Intel-wired-lan] " Simon Horman
2024-12-13 11:54 ` Simon Horman
2024-12-18 13:04 ` [Intel-wired-lan] " Kolacinski, Karol
2024-12-18 13:04 ` Kolacinski, Karol
2024-12-12 15:34 ` [Intel-wired-lan] [PATCH iwl-next 2/3] ice: lower the latency of GNSS reads Michal Schmidt
2024-12-12 15:34 ` Michal Schmidt
2024-12-13 11:54 ` Simon Horman [this message]
2024-12-13 11:54 ` Simon Horman
2024-12-16 5:38 ` [Intel-wired-lan] " Przemek Kitszel
2024-12-16 5:38 ` Przemek Kitszel
2024-12-16 15:57 ` [Intel-wired-lan] " Michal Schmidt
2024-12-16 15:57 ` Michal Schmidt
2024-12-18 16:23 ` [Intel-wired-lan] " Kolacinski, Karol
2024-12-18 16:23 ` Kolacinski, Karol
2024-12-12 15:34 ` [Intel-wired-lan] [PATCH iwl-next 3/3] ice: remove special delay after processing a GNSS read batch Michal Schmidt
2024-12-12 15:34 ` Michal Schmidt
2024-12-13 11:55 ` [Intel-wired-lan] " Simon Horman
2024-12-13 11:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213115438.GP2110@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.