All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andreas Hindborg <a.hindborg@kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nicolas Schier" <nicolas@fjasle.eu>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Adam Bratschi-Kaye" <ark.email@gmail.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support
Date: Fri, 13 Dec 2024 12:43:40 +0100	[thread overview]
Message-ID: <2024121324-overdue-giggly-bdb8@gregkh> (raw)
In-Reply-To: <20241213-module-params-v3-v3-0-485a015ac2cf@kernel.org>

On Fri, Dec 13, 2024 at 12:30:45PM +0100, Andreas Hindborg wrote:
> This series extends the `module!` macro with support module parameters.

Eeek, why?

Module parameters are from the 1990's, back when we had no idea what we
were doing and thought that a simple "one variable for a driver that
controls multiple devices" was somehow a valid solution :)

Please only really add module parameters if you can prove that you
actually need a module parameter.

thanks,

greg k-h

  parent reply	other threads:[~2024-12-13 11:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <xK59-BGgPeRPn4PEeT498C5hexwXQ1H5sDle5WuMs3OtTzS0cA4NTRiBh1zLr_4p6o64eXKYOlEka_xzUHG5jA==@protonmail.internalid>
2024-12-13 11:30 ` [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support Andreas Hindborg
2024-12-13 11:30   ` [PATCH v3 1/4] rust: str: implement `PartialEq` for `BStr` Andreas Hindborg
2024-12-13 12:49     ` Alice Ryhl
2024-12-13 11:30   ` [PATCH v3 2/4] rust: str: implement `strip_prefix` " Andreas Hindborg
2024-12-13 11:30   ` [PATCH v3 3/4] rust: str: add radix prefixed integer parsing functions Andreas Hindborg
2024-12-13 11:30   ` [PATCH v3 4/4] rust: add parameter support to the `module!` macro Andreas Hindborg
2024-12-13 11:46     ` Greg KH
2024-12-13 12:42       ` Andreas Hindborg
2024-12-13 12:54     ` Miguel Ojeda
2024-12-13 13:17       ` Andreas Hindborg
2024-12-13 17:14         ` Miguel Ojeda
2025-01-08 12:45           ` Andreas Hindborg
2025-01-08 13:17             ` Alice Ryhl
2025-01-08 13:43             ` Miguel Ojeda
2025-01-08 14:20               ` Andreas Hindborg
2024-12-13 11:43   ` Greg KH [this message]
2024-12-13 12:24     ` [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support Andreas Hindborg
2024-12-13 12:48       ` Alice Ryhl
2024-12-13 12:57         ` Andreas Hindborg
2024-12-17 14:09           ` Simona Vetter
2024-12-13 14:23       ` Greg KH
2024-12-13 15:38         ` Andreas Hindborg
2024-12-13 16:05           ` Greg KH
2024-12-16  9:51             ` Andreas Hindborg
2024-12-16 12:14               ` Greg KH
2024-12-16 12:23                 ` Greg KH
2024-12-16 13:02                   ` Andreas Hindborg
2024-12-16 13:02                 ` Andreas Hindborg
2024-12-16 14:43                   ` Jens Axboe
2024-12-16 15:03                     ` Greg KH
2024-12-16 15:08                       ` Jens Axboe
2024-12-16 15:39                         ` Miguel Ojeda
2024-12-16 15:48                           ` Miguel Ojeda
2024-12-18  2:16                             ` Josh Triplett
2024-12-13 12:28   ` Andreas Hindborg
2024-12-13 19:41     ` Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024121324-overdue-giggly-bdb8@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=ark.email@gmail.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=gary@garyguo.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.