[PATCH] staging: gpib: Workaround for ppc build failure

[PATCH] staging: gpib: Workaround for ppc build failure

[Dave Penkler]

Make GPIB_FMH depend on !PPC

Reported_by: Stephen Rothwell <sfr@canb.auug.org.au>
Link: https://lore.kernel.org/all/20241015165538.634707e5@canb.auug.org.au/

Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
 drivers/staging/gpib/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gpib/Kconfig b/drivers/staging/gpib/Kconfig
index 95308d15a555..a9b811165f6b 100644
--- a/drivers/staging/gpib/Kconfig
+++ b/drivers/staging/gpib/Kconfig
@@ -128,7 +128,7 @@ config GPIB_FMH
        tristate "FMH FPGA based devices"
        select GPIB_COMMON
        select GPIB_NEC7210
-       depends on BROKEN
+       depends on !PPC
        depends on OF && PCI
        help
          GPIB driver for fmhess FPGA based devices
-- 
2.47.1

Re: [PATCH] staging: gpib: Workaround for ppc build failure

[Guenter Roeck]

On Wed, Dec 04, 2024 at 02:47:36PM +0100, Dave Penkler wrote:
> Make GPIB_FMH depend on !PPC
> 
> Reported_by: Stephen Rothwell <sfr@canb.auug.org.au>
> Link: https://lore.kernel.org/all/20241015165538.634707e5@canb.auug.org.au/
> 
> Signed-off-by: Dave Penkler <dpenkler@gmail.com>

This patch just exposes other build failures, for example
i386:allyesconfig or x86_64:allyesconfig.

Error log:
x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'

There are many more missing functions. FWIW, I don't know how this is
supposed to work in the first place, since pretty much all gpib Makefiles
say

obj-m += <object file>

meaning they won't be built with allyesconfig. fmh_gpib is the only
exception with

obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o

which means it _will_ be built with allyesconfig. So it is not surprising
that it fails to link allyesconfig builds. Actually, it will fail all builds
with CONFIG_GPIB_FMH=y.

Guenter

Re: [PATCH] staging: gpib: Workaround for ppc build failure

[Greg KH]

On Sun, Dec 15, 2024 at 03:23:55PM -0800, Guenter Roeck wrote:
> On Wed, Dec 04, 2024 at 02:47:36PM +0100, Dave Penkler wrote:
> > Make GPIB_FMH depend on !PPC
> > 
> > Reported_by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Link: https://lore.kernel.org/all/20241015165538.634707e5@canb.auug.org.au/
> > 
> > Signed-off-by: Dave Penkler <dpenkler@gmail.com>
> 
> This patch just exposes other build failures, for example
> i386:allyesconfig or x86_64:allyesconfig.
> 
> Error log:
> x86_64-linux-ld: vmlinux.o: in function `fmh_gpib_t1_delay':
> fmh_gpib.c:(.text+0xfd49dbd): undefined reference to `nec7210_t1_delay'
> 
> There are many more missing functions. FWIW, I don't know how this is
> supposed to work in the first place, since pretty much all gpib Makefiles
> say
> 
> obj-m += <object file>
> 
> meaning they won't be built with allyesconfig. fmh_gpib is the only
> exception with
> 
> obj-$(CONFIG_GPIB_FMH) += fmh_gpib.o
> 
> which means it _will_ be built with allyesconfig. So it is not surprising
> that it fails to link allyesconfig builds. Actually, it will fail all builds
> with CONFIG_GPIB_FMH=y.

Arnd has a patch for this that I'll be queueing up this week and getting
to Linus also this week.

thanks,

greg k-h

Re: [PATCH] staging: gpib: Workaround for ppc build failure

[kernel test robot]

In-Reply-To: <20241204134736.6660-1-dpenkler@gmail.com>
References: <20241204134736.6660-1-dpenkler@gmail.com>
TO: Dave Penkler <dpenkler@gmail.com>

Hi Dave,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Dave-Penkler/staging-gpib-Workaround-for-ppc-build-failure/20241204-220307
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20241204134736.6660-1-dpenkler%40gmail.com
patch subject: [PATCH] staging: gpib: Workaround for ppc build failure
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241205/202412050600.DxKMdqyT-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050600.DxKMdqyT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412050600.DxKMdqyT-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.c:15:
   In file included from drivers/staging/gpib/fmh_gpib/fmh_gpib.h:9:
   In file included from include/linux/dmaengine.h:8:
   In file included from include/linux/device.h:32:
   In file included from include/linux/device/driver.h:21:
   In file included from include/linux/module.h:19:
   In file included from include/linux/elf.h:6:
   In file included from arch/s390/include/asm/elf.h:181:
   In file included from arch/s390/include/asm/mmu_context.h:11:
   In file included from arch/s390/include/asm/pgalloc.h:18:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/gpib/fmh_gpib/fmh_gpib.c:162:45: warning: bitwise operation between different enumeration types ('enum fmh_gpib_auxmr_bits' and 'enum aux_reg_i_bits') [-Wenum-enum-conversion]
     162 |                 write_byte(&priv->nec7210_priv, AUX_I_REG | LOCAL_PPOLL_MODE_BIT, AUXMR);
         |                                                 ~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~
   5 warnings generated.


vim +162 drivers/staging/gpib/fmh_gpib/fmh_gpib.c

8e4841a0888c74 Dave Penkler 2024-09-18  156  
8e4841a0888c74 Dave Penkler 2024-09-18  157  static void fmh_gpib_local_parallel_poll_mode(gpib_board_t *board, int local)
8e4841a0888c74 Dave Penkler 2024-09-18  158  {
8e4841a0888c74 Dave Penkler 2024-09-18  159  	struct fmh_priv *priv = board->private_data;
8e4841a0888c74 Dave Penkler 2024-09-18  160  
8e4841a0888c74 Dave Penkler 2024-09-18  161  	if (local) {
8e4841a0888c74 Dave Penkler 2024-09-18 @162  		write_byte(&priv->nec7210_priv, AUX_I_REG | LOCAL_PPOLL_MODE_BIT, AUXMR);
8e4841a0888c74 Dave Penkler 2024-09-18  163  	} else	{
8e4841a0888c74 Dave Penkler 2024-09-18  164  		/* For fmh_gpib_core, remote parallel poll config mode is unaffected by the
8e4841a0888c74 Dave Penkler 2024-09-18  165  		 * state of the disable bit of the parallel poll register (unlike the tnt4882).
8e4841a0888c74 Dave Penkler 2024-09-18  166  		 * So, we don't need to worry about that.
8e4841a0888c74 Dave Penkler 2024-09-18  167  		 */
8e4841a0888c74 Dave Penkler 2024-09-18  168  		write_byte(&priv->nec7210_priv, AUX_I_REG | 0x0, AUXMR);
8e4841a0888c74 Dave Penkler 2024-09-18  169  	}
8e4841a0888c74 Dave Penkler 2024-09-18  170  }
8e4841a0888c74 Dave Penkler 2024-09-18  171  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki