Re: Patch "gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace" has been added to the 6.12-stable tree

Re: Patch "gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace" has been added to the 6.12-stable tree

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 2470 bytes --]

On Sun, Dec 15, 2024 at 11:54:56AM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace
> 
> to the 6.12-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      gpio-idio-16-actually-make-use-of-the-gpio_idio_16-s.patch
> and it can be found in the queue-6.12 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 8845b746c447c715080e448d62aeed25f73fb205
> Author: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Date:   Tue Dec 3 18:26:30 2024 +0100
> 
>     gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace
>     
>     [ Upstream commit 9ac4b58fcef0f9fc03fa6e126a5f53c1c71ada8a ]
>     
>     DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
>     is included. So move the define above the include block.
>     
>     Fixes: b9b1fc1ae119 ("gpio: idio-16: Introduce the ACCES IDIO-16 GPIO library module")
>     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>     Acked-by: William Breathitt Gray <wbg@kernel.org>
>     Link: https://lore.kernel.org/r/20241203172631.1647792-2-u.kleine-koenig@baylibre.com
>     Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>

Hmm, I don't think the advantages here are very relevant. The only
problem fixed here is that the symbols provided by the driver are not in
the expected namespace. So this is nothing a user would wail about as
everything works as intended. The big upside of dropping this patch is
that you can (I think) also drop the backport of commit ceb8bf2ceaa7
("module: Convert default symbol namespace to string literal").

Even if you want to fix the namespace issue in the gpio-idio-16 driver,
I'd suggest to just move the definition of DEFAULT_SYMBOL_NAMESPACE
without the quotes for stable as I think this is easy enough to not
justify taking the intrusive ceb8bf2ceaa7. Also ceb8bf2ceaa7 might be an
annoyance for out-of-tree code. I know we don't care much about these,
still I think not adding to their burden is another small argument for
not taking ceb8bf2ceaa7.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Patch "gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace" has been added to the 6.12-stable tree

[Greg KH]

On Mon, Dec 16, 2024 at 09:32:27AM +0100, Uwe Kleine-König wrote:
> On Sun, Dec 15, 2024 at 11:54:56AM -0500, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> >     gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace
> > 
> > to the 6.12-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      gpio-idio-16-actually-make-use-of-the-gpio_idio_16-s.patch
> > and it can be found in the queue-6.12 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> > 
> > 
> > commit 8845b746c447c715080e448d62aeed25f73fb205
> > Author: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> > Date:   Tue Dec 3 18:26:30 2024 +0100
> > 
> >     gpio: idio-16: Actually make use of the GPIO_IDIO_16 symbol namespace
> >     
> >     [ Upstream commit 9ac4b58fcef0f9fc03fa6e126a5f53c1c71ada8a ]
> >     
> >     DEFAULT_SYMBOL_NAMESPACE must already be defined when <linux/export.h>
> >     is included. So move the define above the include block.
> >     
> >     Fixes: b9b1fc1ae119 ("gpio: idio-16: Introduce the ACCES IDIO-16 GPIO library module")
> >     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> >     Acked-by: William Breathitt Gray <wbg@kernel.org>
> >     Link: https://lore.kernel.org/r/20241203172631.1647792-2-u.kleine-koenig@baylibre.com
> >     Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> Hmm, I don't think the advantages here are very relevant. The only
> problem fixed here is that the symbols provided by the driver are not in
> the expected namespace. So this is nothing a user would wail about as
> everything works as intended. The big upside of dropping this patch is
> that you can (I think) also drop the backport of commit ceb8bf2ceaa7
> ("module: Convert default symbol namespace to string literal").

Yes, as the previous commit that ceb8bf2ceaa7 fixes is not in the tree,
ceb8bf2ceaa7 should be removed, I'll go do that now, and drop this one
too, thanks.

greg k-h