All of lore.kernel.org
 help / color / mirror / Atom feed
* [chao:wip 19/20] fs/f2fs/segment.c:2891:25: error: implicit declaration of function 'reset_curseg_fields'; did you mean 'reset_curseg'?
@ 2024-12-16 18:55 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-12-16 18:55 UTC (permalink / raw)
  To: Chao Yu, Chao Yu; +Cc: oe-kbuild-all, Chao Yu, Chao Yu

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip
head:   99c1b937f7efd14347261f99e40036e481c6cbc0
commit: adf3b6b31460b800b74602a535414e50d1e761c5 [19/20] f2fs: fix to avoid panic once fallocation fails for pinfile
config: arm-randconfig-002-20241217 (https://download.01.org/0day-ci/archive/20241217/202412170256.GSAInfkZ-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241217/202412170256.GSAInfkZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412170256.GSAInfkZ-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   fs/f2fs/segment.c: In function 'new_curseg':
>> fs/f2fs/segment.c:2891:25: error: implicit declaration of function 'reset_curseg_fields'; did you mean 'reset_curseg'? [-Wimplicit-function-declaration]
    2891 |                         reset_curseg_fields(curseg);
         |                         ^~~~~~~~~~~~~~~~~~~
         |                         reset_curseg
   fs/f2fs/segment.c: At top level:
>> fs/f2fs/segment.c:3671:13: warning: conflicting types for 'reset_curseg_fields'; have 'void(struct curseg_info *)'
    3671 | static void reset_curseg_fields(struct curseg_info *curseg)
         |             ^~~~~~~~~~~~~~~~~~~
>> fs/f2fs/segment.c:3671:13: error: static declaration of 'reset_curseg_fields' follows non-static declaration
   fs/f2fs/segment.c:2891:25: note: previous implicit declaration of 'reset_curseg_fields' with type 'void(struct curseg_info *)'
    2891 |                         reset_curseg_fields(curseg);
         |                         ^~~~~~~~~~~~~~~~~~~


vim +2891 fs/f2fs/segment.c

  2872	
  2873	/*
  2874	 * Allocate a current working segment.
  2875	 * This function always allocates a free segment in LFS manner.
  2876	 */
  2877	static int new_curseg(struct f2fs_sb_info *sbi, int type, bool new_sec)
  2878	{
  2879		struct curseg_info *curseg = CURSEG_I(sbi, type);
  2880		unsigned int segno = curseg->segno;
  2881		bool pinning = type == CURSEG_COLD_DATA_PINNED;
  2882		int ret;
  2883	
  2884		if (curseg->inited)
  2885			write_sum_page(sbi, curseg->sum_blk, GET_SUM_BLOCK(sbi, segno));
  2886	
  2887		segno = __get_next_segno(sbi, type);
  2888		ret = get_new_segment(sbi, &segno, new_sec, pinning);
  2889		if (ret) {
  2890			if (ret == -ENOSPC)
> 2891				reset_curseg_fields(curseg);
  2892			return ret;
  2893		}
  2894	
  2895		curseg->next_segno = segno;
  2896		reset_curseg(sbi, type, 1);
  2897		curseg->alloc_type = LFS;
  2898		if (F2FS_OPTION(sbi).fs_mode == FS_MODE_FRAGMENT_BLK)
  2899			curseg->fragment_remained_chunk =
  2900					get_random_u32_inclusive(1, sbi->max_fragment_chunk);
  2901		return 0;
  2902	}
  2903	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-12-16 18:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 18:55 [chao:wip 19/20] fs/f2fs/segment.c:2891:25: error: implicit declaration of function 'reset_curseg_fields'; did you mean 'reset_curseg'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.