[PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

[PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

[Luca Ceresoli]

When devm_drm_of_get_bridge() fails, the probe fails silently. Use
dev_err_probe() instead to log an error or report the deferral reason,
whichever is applicable.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index 57a7ed13f9965db5a32b601a2a7ca92314c68f7d..60b9f14d769a5489acdfca6c2bb5744d02081315 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -606,7 +606,7 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model)
 
 	panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 2, 0);
 	if (IS_ERR(panel_bridge))
-		return PTR_ERR(panel_bridge);
+		return dev_err_probe(dev, PTR_ERR(panel_bridge), "Failed to get panel bridge\n");
 
 	ctx->panel_bridge = panel_bridge;
 

---
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
change-id: 20240808-ti-sn65dsi83-dev_err_probe-98daf0ddafb1

Best regards,
-- 
Luca Ceresoli <luca.ceresoli@bootlin.com>

Re: [PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

[Luca Ceresoli]

Hello,

On Tue, 17 Dec 2024 17:02:51 +0100
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> When devm_drm_of_get_bridge() fails, the probe fails silently. Use
> dev_err_probe() instead to log an error or report the deferral reason,
> whichever is applicable.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

This patch got a reviewed-by from Andi Shyti when I sent it the first
time [0], but b4 didn't keep it when resending. I think it is fair for
me to add it now, even though I'm not sure patchwork and b4 will catch
it:

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

[0] https://lore.kernel.org/all/ZrtuksiarZNS8L79@ashyti-mobl2.lan/

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

[Neil Armstrong]

Hi,

On 17/12/2024 17:06, Luca Ceresoli wrote:
> Hello,
> 
> On Tue, 17 Dec 2024 17:02:51 +0100
> Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> 
>> When devm_drm_of_get_bridge() fails, the probe fails silently. Use
>> dev_err_probe() instead to log an error or report the deferral reason,
>> whichever is applicable.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
> This patch got a reviewed-by from Andi Shyti when I sent it the first
> time [0], but b4 didn't keep it when resending. I think it is fair for
> me to add it now, even though I'm not sure patchwork and b4 will catch
> it:
> 
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> 
> [0] https://lore.kernel.org/all/ZrtuksiarZNS8L79@ashyti-mobl2.lan/
> 

Added it manually!

Thanks
Neil

Re: [PATCH RESEND] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge

[Neil Armstrong]

Hi,

On Tue, 17 Dec 2024 17:02:51 +0100, Luca Ceresoli wrote:
> When devm_drm_of_get_bridge() fails, the probe fails silently. Use
> dev_err_probe() instead to log an error or report the deferral reason,
> whichever is applicable.
> 
> 

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/4e358b57bbb3e35bf20faed697305cd97aa1a388

-- 
Neil