From: Peter Zijlstra <peterz@infradead.org>
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: mingo@redhat.com, namhyung@kernel.org, acme@kernel.org,
eranian@google.com, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
santosh.shukla@amd.com, ananth.narayan@amd.com,
sandipan.das@amd.com
Subject: Re: [PATCH v3 08/10] perf/core: Introduce pmu->adjust_period() callback
Date: Wed, 18 Dec 2024 14:52:29 +0100 [thread overview]
Message-ID: <20241218135229.GE2354@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241210093449.1662-9-ravi.bangoria@amd.com>
On Tue, Dec 10, 2024 at 09:34:47AM +0000, Ravi Bangoria wrote:
> Many hardware PMUs have constraints about sample period. For ex, minimum
> supported sample period for IBS Op PMU is 0x90, the sample period must
> be multiple of 0x10 for IBS Fetch and IBS Op.
>
> Add an optional callback adjust_period() to struct PMU to allow PMU
> specific drivers to adjust sample period calculated by generic code.
> This will ensure the sample_period value will always be valid and no
> additional code is required in PMU specific drivers to re-adjust the
> period.
And not a word about pmu::check_period() and x86_pmu::limit_period() :-(
Please explain why that can't be made to work nor adapted.
next prev parent reply other threads:[~2024-12-18 13:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 9:34 [PATCH v3 00/10] perf/amd/ibs: Fix sample period computations Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 01/10] perf/amd/ibs: Remove IBS_{FETCH|OP}_CONFIG_MASK macros Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 02/10] perf/amd/ibs: Remove pointless sample period check Ravi Bangoria
2024-12-18 13:35 ` Peter Zijlstra
2024-12-10 9:34 ` [PATCH v3 03/10] perf/amd/ibs: Fix ->config to sample period calculation for OP PMU Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 04/10] perf/amd/ibs: Fix perf_ibs_op.cnt_mask for CurCnt Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 05/10] perf/amd/ibs: Don't allow freq mode event creation through ->config interface Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 06/10] perf/amd/ibs: Add PMU specific minimum period Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 07/10] perf/amd/ibs: Add ->check_period() callback Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 08/10] perf/core: Introduce pmu->adjust_period() callback Ravi Bangoria
2024-12-18 13:52 ` Peter Zijlstra [this message]
2025-01-08 11:16 ` Ravi Bangoria
2024-12-10 9:34 ` [PATCH v3 09/10] perf test: Introduce DEFINE_SUITE_EXCLUSIVE() Ravi Bangoria
2024-12-13 19:55 ` Arnaldo Carvalho de Melo
2024-12-10 9:34 ` [PATCH v3 10/10] perf test amd ibs: Add sample period unit test Ravi Bangoria
2024-12-16 6:42 ` [PATCH v3 00/10] perf/amd/ibs: Fix sample period computations Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218135229.GE2354@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=ravi.bangoria@amd.com \
--cc=sandipan.das@amd.com \
--cc=santosh.shukla@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.