* [PATCH 1/1] input: touchscreen: ads7846: Use managed variant to get pendown GPIO
@ 2024-12-23 15:34 Markus Koch
0 siblings, 0 replies; only message in thread
From: Markus Koch @ 2024-12-23 15:34 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Marek Vasut, linux-input, Markus Koch
Removing and re-probing the driver failed with an error to request the
pendown GPIO because it is never released in the remove function.
This patch replaces the original gpiod_get function call with the
managed devm_gpiod_get variant, which automatically releases the GPIO
when the module is unloaded.
Signed-off-by: Markus Koch <markus@notsyncing.net>
---
Tested on an IMX53-based platform.
---
drivers/input/touchscreen/ads7846.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 607f18af7010..212dafa0bba2 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -1011,7 +1011,7 @@ static int ads7846_setup_pendown(struct spi_device *spi,
if (pdata->get_pendown_state) {
ts->get_pendown_state = pdata->get_pendown_state;
} else {
- ts->gpio_pendown = gpiod_get(&spi->dev, "pendown", GPIOD_IN);
+ ts->gpio_pendown = devm_gpiod_get(&spi->dev, "pendown", GPIOD_IN);
if (IS_ERR(ts->gpio_pendown)) {
dev_err(&spi->dev, "failed to request pendown GPIO\n");
return PTR_ERR(ts->gpio_pendown);
--
2.47.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-12-23 15:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-23 15:34 [PATCH 1/1] input: touchscreen: ads7846: Use managed variant to get pendown GPIO Markus Koch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.