* [openeuler:openEuler-1.0-LTS 1345/1345] drivers/acpi/pmic/tps68470_pmic.c:380:10: error: implicit declaration of function 'dev_err_probe'
@ 2024-12-24 16:20 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-12-24 16:20 UTC (permalink / raw)
To: kernel, Qi Xi; +Cc: oe-kbuild-all
tree: https://gitee.com/openeuler/kernel.git openEuler-1.0-LTS
head: 33267d4a7f512d371a3ea853568832174be4caba
commit: 24564bb891ae98786176f703d1addc5588dafe61 [1345/1345] ACPI: PMIC: Remove unneeded check in tps68470_pmic_opregion_probe()
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241225/202412250010.Z1qbx7TD-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241225/202412250010.Z1qbx7TD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412250010.Z1qbx7TD-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/acpi/pmic/tps68470_pmic.c:380:10: error: implicit declaration of function 'dev_err_probe' [-Werror,-Wimplicit-function-declaration]
380 | return dev_err_probe(dev, -EINVAL, "regmap is missing\n");
| ^
drivers/acpi/pmic/tps68470_pmic.c:380:10: note: did you mean 'device_reprobe'?
include/linux/device.h:1336:25: note: 'device_reprobe' declared here
1336 | extern int __must_check device_reprobe(struct device *dev);
| ^
1 error generated.
vim +/dev_err_probe +380 drivers/acpi/pmic/tps68470_pmic.c
370
371 static int tps68470_pmic_opregion_probe(struct platform_device *pdev)
372 {
373 struct regmap *tps68470_regmap = dev_get_drvdata(pdev->dev.parent);
374 acpi_handle handle = ACPI_HANDLE(pdev->dev.parent);
375 struct device *dev = &pdev->dev;
376 struct tps68470_pmic_opregion *opregion;
377 acpi_status status;
378
379 if (!tps68470_regmap)
> 380 return dev_err_probe(dev, -EINVAL, "regmap is missing\n");
381
382 if (!handle) {
383 dev_warn(dev, "acpi handle is NULL\n");
384 return -ENODEV;
385 }
386
387 opregion = devm_kzalloc(dev, sizeof(*opregion), GFP_KERNEL);
388 if (!opregion)
389 return -ENOMEM;
390
391 mutex_init(&opregion->lock);
392 opregion->regmap = tps68470_regmap;
393
394 status = acpi_install_address_space_handler(handle,
395 TI_PMIC_POWER_OPREGION_ID,
396 tps68470_pmic_pwr_handler,
397 NULL, opregion);
398 if (ACPI_FAILURE(status))
399 goto out_mutex_destroy;
400
401 status = acpi_install_address_space_handler(handle,
402 TI_PMIC_VR_VAL_OPREGION_ID,
403 tps68470_pmic_vrval_handler,
404 NULL, opregion);
405 if (ACPI_FAILURE(status))
406 goto out_remove_power_handler;
407
408 status = acpi_install_address_space_handler(handle,
409 TI_PMIC_CLOCK_OPREGION_ID,
410 tps68470_pmic_clk_handler,
411 NULL, opregion);
412 if (ACPI_FAILURE(status))
413 goto out_remove_vr_val_handler;
414
415 status = acpi_install_address_space_handler(handle,
416 TI_PMIC_CLKFREQ_OPREGION_ID,
417 tps68470_pmic_cfreq_handler,
418 NULL, opregion);
419 if (ACPI_FAILURE(status))
420 goto out_remove_clk_handler;
421
422 return 0;
423
424 out_remove_clk_handler:
425 acpi_remove_address_space_handler(handle, TI_PMIC_CLOCK_OPREGION_ID,
426 tps68470_pmic_clk_handler);
427 out_remove_vr_val_handler:
428 acpi_remove_address_space_handler(handle, TI_PMIC_VR_VAL_OPREGION_ID,
429 tps68470_pmic_vrval_handler);
430 out_remove_power_handler:
431 acpi_remove_address_space_handler(handle, TI_PMIC_POWER_OPREGION_ID,
432 tps68470_pmic_pwr_handler);
433 out_mutex_destroy:
434 mutex_destroy(&opregion->lock);
435 return -ENODEV;
436 }
437
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-12-24 16:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-24 16:20 [openeuler:openEuler-1.0-LTS 1345/1345] drivers/acpi/pmic/tps68470_pmic.c:380:10: error: implicit declaration of function 'dev_err_probe' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.