* [intel-lts:6.12/linux 1/1] net/core/rtnetlink.c:1593 rtnl_xdp_fill() warn: missing error code 'err'
@ 2024-12-26 9:11 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-26 9:11 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
CC: Kishor408 <kishorx.buchi@intel.com>
CC: Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>
tree: https://github.com/intel/linux-intel-lts.git 6.12/linux
head: af28adffb0fe876a7f6b55f145e6cae4861209a9
commit: d422faba40f2b00b944ed5ffa9c365bf904c950b [1/1] rtnetlink: Fix unchecked return value of dev_xdp_query_md_btf()
:::::: branch date: 6 days ago
:::::: commit date: 2 weeks ago
config: i386-randconfig-141-20241226 (https://download.01.org/0day-ci/archive/20241226/202412261741.KiMk9t5S-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412261741.KiMk9t5S-lkp@intel.com/
New smatch warnings:
net/core/rtnetlink.c:1593 rtnl_xdp_fill() warn: missing error code 'err'
Old smatch warnings:
net/core/rtnetlink.c:402 __rtnl_register_many() error: uninitialized symbol 'err'.
vim +/err +1593 net/core/rtnetlink.c
d67b9cd28c1d7f Daniel Borkmann 2017-05-12 1553
d1fdd9138682e0 Brenden Blanco 2016-07-19 1554 static int rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev)
d1fdd9138682e0 Brenden Blanco 2016-07-19 1555 {
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1556 u32 prog_id, md_btf_id;
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1557 u8 md_btf_enabled = 0;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1558 struct nlattr *xdp;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1559 int err;
4f91da26c81145 Jakub Kicinski 2018-07-11 1560 u8 mode;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1561
ae0be8de9a53cd Michal Kubecek 2019-04-26 1562 xdp = nla_nest_start_noflag(skb, IFLA_XDP);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1563 if (!xdp)
d1fdd9138682e0 Brenden Blanco 2016-07-19 1564 return -EMSGSIZE;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1565
a25717d2b60434 Jakub Kicinski 2018-07-11 1566 prog_id = 0;
a25717d2b60434 Jakub Kicinski 2018-07-11 1567 mode = XDP_ATTACHED_NONE;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1568 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_SKB,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1569 IFLA_XDP_SKB_PROG_ID, rtnl_xdp_prog_skb);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1570 if (err)
b5cdae3291f7be David S. Miller 2017-04-18 1571 goto err_cancel;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1572 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_DRV,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1573 IFLA_XDP_DRV_PROG_ID, rtnl_xdp_prog_drv);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1574 if (err)
a25717d2b60434 Jakub Kicinski 2018-07-11 1575 goto err_cancel;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1576 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_HW,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1577 IFLA_XDP_HW_PROG_ID, rtnl_xdp_prog_hw);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1578 if (err)
58038695e62b44 Martin KaFai Lau 2017-06-15 1579 goto err_cancel;
4f91da26c81145 Jakub Kicinski 2018-07-11 1580
a25717d2b60434 Jakub Kicinski 2018-07-11 1581 err = nla_put_u8(skb, IFLA_XDP_ATTACHED, mode);
b5cdae3291f7be David S. Miller 2017-04-18 1582 if (err)
b5cdae3291f7be David S. Miller 2017-04-18 1583 goto err_cancel;
d67b9cd28c1d7f Daniel Borkmann 2017-05-12 1584
a25717d2b60434 Jakub Kicinski 2018-07-11 1585 if (prog_id && mode != XDP_ATTACHED_MULTI) {
58038695e62b44 Martin KaFai Lau 2017-06-15 1586 err = nla_put_u32(skb, IFLA_XDP_PROG_ID, prog_id);
58038695e62b44 Martin KaFai Lau 2017-06-15 1587 if (err)
58038695e62b44 Martin KaFai Lau 2017-06-15 1588 goto err_cancel;
58038695e62b44 Martin KaFai Lau 2017-06-15 1589 }
58038695e62b44 Martin KaFai Lau 2017-06-15 1590
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1591 md_btf_id = dev_xdp_query_md_btf(dev, &md_btf_enabled);
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 1592 if (!md_btf_id)
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 @1593 goto err_cancel;
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 1594
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1595 nla_put_u32(skb, IFLA_XDP_MD_BTF_ID, md_btf_id);
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1596 nla_put_u8(skb, IFLA_XDP_MD_BTF_STATE, md_btf_enabled);
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1597
d1fdd9138682e0 Brenden Blanco 2016-07-19 1598 nla_nest_end(skb, xdp);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1599 return 0;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1600
d1fdd9138682e0 Brenden Blanco 2016-07-19 1601 err_cancel:
d1fdd9138682e0 Brenden Blanco 2016-07-19 1602 nla_nest_cancel(skb, xdp);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1603 return err;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1604 }
d1fdd9138682e0 Brenden Blanco 2016-07-19 1605
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [intel-lts:6.12/linux 1/1] net/core/rtnetlink.c:1593 rtnl_xdp_fill() warn: missing error code 'err'
@ 2025-01-06 10:37 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-01-06 10:37 UTC (permalink / raw)
To: oe-kbuild, Muhammad Husaini Zulkifli
Cc: lkp, oe-kbuild-all, Kishor408, Aravindhan Gunasekaran
tree: https://github.com/intel/linux-intel-lts.git 6.12/linux
head: af28adffb0fe876a7f6b55f145e6cae4861209a9
commit: d422faba40f2b00b944ed5ffa9c365bf904c950b [1/1] rtnetlink: Fix unchecked return value of dev_xdp_query_md_btf()
config: i386-randconfig-141-20241226 (https://download.01.org/0day-ci/archive/20241226/202412261741.KiMk9t5S-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202412261741.KiMk9t5S-lkp@intel.com/
New smatch warnings:
net/core/rtnetlink.c:1593 rtnl_xdp_fill() warn: missing error code 'err'
vim +/err +1593 net/core/rtnetlink.c
d1fdd9138682e0 Brenden Blanco 2016-07-19 1554 static int rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev)
d1fdd9138682e0 Brenden Blanco 2016-07-19 1555 {
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1556 u32 prog_id, md_btf_id;
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1557 u8 md_btf_enabled = 0;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1558 struct nlattr *xdp;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1559 int err;
4f91da26c81145 Jakub Kicinski 2018-07-11 1560 u8 mode;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1561
ae0be8de9a53cd Michal Kubecek 2019-04-26 1562 xdp = nla_nest_start_noflag(skb, IFLA_XDP);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1563 if (!xdp)
d1fdd9138682e0 Brenden Blanco 2016-07-19 1564 return -EMSGSIZE;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1565
a25717d2b60434 Jakub Kicinski 2018-07-11 1566 prog_id = 0;
a25717d2b60434 Jakub Kicinski 2018-07-11 1567 mode = XDP_ATTACHED_NONE;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1568 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_SKB,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1569 IFLA_XDP_SKB_PROG_ID, rtnl_xdp_prog_skb);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1570 if (err)
b5cdae3291f7be David S. Miller 2017-04-18 1571 goto err_cancel;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1572 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_DRV,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1573 IFLA_XDP_DRV_PROG_ID, rtnl_xdp_prog_drv);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1574 if (err)
a25717d2b60434 Jakub Kicinski 2018-07-11 1575 goto err_cancel;
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1576 err = rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_HW,
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1577 IFLA_XDP_HW_PROG_ID, rtnl_xdp_prog_hw);
202aabe84a8fd8 Jakub Kicinski 2018-07-16 1578 if (err)
58038695e62b44 Martin KaFai Lau 2017-06-15 1579 goto err_cancel;
4f91da26c81145 Jakub Kicinski 2018-07-11 1580
a25717d2b60434 Jakub Kicinski 2018-07-11 1581 err = nla_put_u8(skb, IFLA_XDP_ATTACHED, mode);
b5cdae3291f7be David S. Miller 2017-04-18 1582 if (err)
b5cdae3291f7be David S. Miller 2017-04-18 1583 goto err_cancel;
d67b9cd28c1d7f Daniel Borkmann 2017-05-12 1584
a25717d2b60434 Jakub Kicinski 2018-07-11 1585 if (prog_id && mode != XDP_ATTACHED_MULTI) {
58038695e62b44 Martin KaFai Lau 2017-06-15 1586 err = nla_put_u32(skb, IFLA_XDP_PROG_ID, prog_id);
58038695e62b44 Martin KaFai Lau 2017-06-15 1587 if (err)
58038695e62b44 Martin KaFai Lau 2017-06-15 1588 goto err_cancel;
58038695e62b44 Martin KaFai Lau 2017-06-15 1589 }
58038695e62b44 Martin KaFai Lau 2017-06-15 1590
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1591 md_btf_id = dev_xdp_query_md_btf(dev, &md_btf_enabled);
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 1592 if (!md_btf_id)
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 @1593 goto err_cancel;
Set err on this path?
d422faba40f2b0 Muhammad Husaini Zulkifli 2021-07-30 1594
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1595 nla_put_u32(skb, IFLA_XDP_MD_BTF_ID, md_btf_id);
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1596 nla_put_u8(skb, IFLA_XDP_MD_BTF_STATE, md_btf_enabled);
32bb8f64a1a821 Muhammad Husaini Zulkifli 2021-06-14 1597
d1fdd9138682e0 Brenden Blanco 2016-07-19 1598 nla_nest_end(skb, xdp);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1599 return 0;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1600
d1fdd9138682e0 Brenden Blanco 2016-07-19 1601 err_cancel:
d1fdd9138682e0 Brenden Blanco 2016-07-19 1602 nla_nest_cancel(skb, xdp);
d1fdd9138682e0 Brenden Blanco 2016-07-19 1603 return err;
d1fdd9138682e0 Brenden Blanco 2016-07-19 1604 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-06 10:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-26 9:11 [intel-lts:6.12/linux 1/1] net/core/rtnetlink.c:1593 rtnl_xdp_fill() warn: missing error code 'err' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-01-06 10:37 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.