Re: [PATCH 1/5] dt-bindings: platform: Add Huawei Matebook E Go EC

[Pengyu Luo <mitltlatltl@gmail.com>]

On Mon, Dec 30, 2024 at 3:28 PM Aiqun(Maria) Yu <quic_aiquny@quicinc.com> wrote:
> On 12/29/2024 6:12 PM, Pengyu Luo wrote:
> [...]
> >>>>> +      - const: huawei,gaokun-ec
> >>>>
> >>>> How did you get the name?
> >>>>
> >>>
> >>> From website of Huawei([1]), please search for 'gaokun' here, we can know
>
> Gaokun appears to be a code name from Huawei for the HUAWEI MateBook E
> Go devices.
>
> Could you please specify which EC functions are customized specifically
> for Gaokun and which EC functions are common features used in
> qcom,sc8180x and qcom,sc8280xp boards? For example, the upstreamed ones
> like sc8180x (Lenovo Flex 5G/Primus) and sc8280xp (CRD/Lenovo ThinkPad
> X13s/Microsoft Arcata).
>

Generally, pmic glink is a subset to this EC,
common functions(slightlg different in implementations):
- Battery and charger monitoring; (drivers/power/supply/qcom_battmgr.c)
- UCSI (drivers/usb/typec/ucsi/ucsi_glink.c)
- Altmodes (drivers/soc/qcom/pmic_glink_altmode.c)

EC extended:
- Charge control and smart charge;
- Fn_lock settings;
- Tablet lid status;
- Temperature sensors;
- many other thngs (watchdog, more WMI functions, it is hard to reverse for me)

If necessary, I will add them to dt-binding, it is a bit bloated.

> >>
> [...]
> >>
> >
> > Check the motherboard, https://postimg.cc/V5r4KCgx (Credit to Tianyu Gao <gty0622@gmail.com>)
>
> The link is not accessible from my end. Could you please help follow the
> document tips referenced by [1] if this content is important for the
> overall naming design?
>
> Here are some snippets for reference:
> "for 'volatile' documents, please create an entry in the kernel
> bugzilla https://bugzilla.kernel.org and attach a copy of these documents
> to the bugzilla entry. Finally, provide the URL of the bugzilla entry in
> the changelog."
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst
> [1]
>

I am an amateur, I have only read a small part of the documentation so
far. I will have a try in v2 after reading the doc.

Best wishes,
Pengyu