* [chrome-os:chromeos-6.6 99/99] drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast
@ 2024-12-30 12:11 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-12-30 12:11 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head: f5002a03972c582b24af87ac1e3c5ffecb07573f
commit: 71e4fcb288df366078213ba4fcf976f12a14d5e2 [99/99] FROMLIST: mailbox: Add power_get/power_put API to mbox_chan_ops
config: x86_64-buildonly-randconfig-003-20241230 (https://download.01.org/0day-ci/archive/20241230/202412302042.bAcoc56F-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241230/202412302042.bAcoc56F-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412302042.bAcoc56F-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/mailbox/mailbox.c: In function '__mbox_bind_client':
>> drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
382 | return ERR_PTR(ret);
| ^~~~~~~~~~~~
vim +382 drivers/mailbox/mailbox.c
355
356 static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl)
357 {
358 struct device *dev = cl->dev;
359 unsigned long flags;
360 int ret;
361
362 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) {
363 dev_dbg(dev, "%s: mailbox not free\n", __func__);
364 return -EBUSY;
365 }
366
367 spin_lock_irqsave(&chan->lock, flags);
368 chan->msg_free = 0;
369 chan->msg_count = 0;
370 chan->active_req = NULL;
371 chan->cl = cl;
372 init_completion(&chan->tx_complete);
373
374 if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone)
375 chan->txdone_method = TXDONE_BY_ACK;
376
377 spin_unlock_irqrestore(&chan->lock, flags);
378
379 if (chan->mbox->ops->power_get) {
380 ret = chan->mbox->ops->power_get(chan);
381 if (ret < 0)
> 382 return ERR_PTR(ret);
383 }
384
385 if (chan->mbox->ops->startup) {
386 ret = chan->mbox->ops->startup(chan);
387
388 if (ret) {
389 dev_err(dev, "Unable to startup the chan (%d)\n", ret);
390 mbox_free_channel(chan);
391 return ret;
392 }
393 }
394
395 return 0;
396 }
397
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [chrome-os:chromeos-6.6 99/99] drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast
@ 2025-01-03 4:09 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-01-03 4:09 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-6.6
head: 79ef5afd889ffc81ed98258b561e132e0d9d81a3
commit: 71e4fcb288df366078213ba4fcf976f12a14d5e2 [99/99] FROMLIST: mailbox: Add power_get/power_put API to mbox_chan_ops
config: x86_64-buildonly-randconfig-003-20241230 (https://download.01.org/0day-ci/archive/20250103/202501031100.VtKKrYUf-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501031100.VtKKrYUf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501031100.VtKKrYUf-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/mailbox/mailbox.c: In function '__mbox_bind_client':
>> drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
382 | return ERR_PTR(ret);
| ^~~~~~~~~~~~
vim +382 drivers/mailbox/mailbox.c
355
356 static int __mbox_bind_client(struct mbox_chan *chan, struct mbox_client *cl)
357 {
358 struct device *dev = cl->dev;
359 unsigned long flags;
360 int ret;
361
362 if (chan->cl || !try_module_get(chan->mbox->dev->driver->owner)) {
363 dev_dbg(dev, "%s: mailbox not free\n", __func__);
364 return -EBUSY;
365 }
366
367 spin_lock_irqsave(&chan->lock, flags);
368 chan->msg_free = 0;
369 chan->msg_count = 0;
370 chan->active_req = NULL;
371 chan->cl = cl;
372 init_completion(&chan->tx_complete);
373
374 if (chan->txdone_method == TXDONE_BY_POLL && cl->knows_txdone)
375 chan->txdone_method = TXDONE_BY_ACK;
376
377 spin_unlock_irqrestore(&chan->lock, flags);
378
379 if (chan->mbox->ops->power_get) {
380 ret = chan->mbox->ops->power_get(chan);
381 if (ret < 0)
> 382 return ERR_PTR(ret);
383 }
384
385 if (chan->mbox->ops->startup) {
386 ret = chan->mbox->ops->startup(chan);
387
388 if (ret) {
389 dev_err(dev, "Unable to startup the chan (%d)\n", ret);
390 mbox_free_channel(chan);
391 return ret;
392 }
393 }
394
395 return 0;
396 }
397
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-03 4:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-30 12:11 [chrome-os:chromeos-6.6 99/99] drivers/mailbox/mailbox.c:382:32: warning: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-01-03 4:09 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.