* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
@ 2024-12-31 10:44 kernel test robot
0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2024-12-31 10:44 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "low confidence static check first_new_problem: arch/arm/boot/dts/ti/omap/omap4-panda.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[117]], 'interrupts-extended': [[1, 0, 73, 4], [115, 220]], 'bluetooth': {'compatible': ['ti,wl1271-st'], 'pinctrl-names': ['default'], 'pinctrl-0': [[118]], 'enable-gpios': [[119, 14, 0]], 'clocks': [[120, 0]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}"
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241229230125.85787-3-andreas@kemnade.info>
References: <20241229230125.85787-3-andreas@kemnade.info>
TO: Andreas Kemnade <andreas@kemnade.info>
TO: Rob Herring <robh@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
TO: linux-omap@vger.kernel.org
TO: linux-kernel@vger.kernel.org
TO: Roger Quadros <rogerq@kernel.org>
TO: Aaro Koskinen <aaro.koskinen@iki.fi>
TO: Kevin Hilman <khilman@baylibre.com>
TO: devicetree@vger.kernel.org
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Tony Lindgren <tony@atomide.com>
CC: Andreas Kemnade <andreas@kemnade.info>
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.13-rc5 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/ARM-dts-omap4-panda-fix-resources-needed-for-Panda/20241230-070349
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20241229230125.85787-3-andreas%40kemnade.info
patch subject: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
:::::: branch date: 35 hours ago
:::::: commit date: 35 hours ago
config: arm-randconfig-052-20241230 (https://download.01.org/0day-ci/archive/20241231/202412311852.AflFNKba-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
dtschema version: 2024.12.dev5+gea243eb
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241231/202412311852.AflFNKba-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202412311852.AflFNKba-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000: failed to match any schema with compatible: ['ti,omap4-l4-per', 'simple-pm-bus']
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: segment@0: $nodename:0: 'segment@0' does not match '^bus(@[0-9a-f]+)?$'
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: segment@0: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 74, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 74, 4], [115, 260]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@60000/i2c@0/eeprom@50: failed to match any schema with compatible: ['ti,eeprom']
>> arch/arm/boot/dts/ti/omap/omap4-panda.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[117]], 'interrupts-extended': [[1, 0, 73, 4], [115, 220]], 'bluetooth': {'compatible': ['ti,wl1271-st'], 'pinctrl-names': ['default'], 'pinctrl-0': [[118]], 'enable-gpios': [[119, 14, 0]], 'clocks': [[120, 0]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 70, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 70, 4], [115, 284]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: twl@48: Unevaluated properties are not allowed ('pwm', 'pwmled', 'usb-comparator' were unexpected)
from schema $id: http://devicetree.org/schemas/mfd/ti,twl.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/usb-comparator: failed to match any schema with compatible: ['ti,twl6030-usb']
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwm: failed to match any schema with compatible: ['ti,twl6030-pwm']
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwmled: failed to match any schema with compatible: ['ti,twl6030-pwmled']
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@4b: failed to match any schema with compatible: ['ti,twl6040']
arch/arm/boot/dts/ti/omap/omap4-panda.dtb: /ocp/interconnect@48000000/segment@0/target-module@96000/mcbsp@0: failed to match any schema with compatible: ['ti,omap4-mcbsp']
--
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000: failed to match any schema with compatible: ['ti,omap4-l4-per', 'simple-pm-bus']
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: segment@0: $nodename:0: 'segment@0' does not match '^bus(@[0-9a-f]+)?$'
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: segment@0: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 74, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 74, 4], [115, 260]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@60000/i2c@0/eeprom@50: failed to match any schema with compatible: ['ti,eeprom']
>> arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[117]], 'interrupts-extended': [[1, 0, 73, 4], [115, 220]], 'bluetooth': {'compatible': ['ti,wl1271-st'], 'pinctrl-names': ['default'], 'pinctrl-0': [[118]], 'enable-gpios': [[119, 14, 0]], 'clocks': [[120, 0]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 70, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 70, 4], [115, 284]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: twl@48: Unevaluated properties are not allowed ('pwm', 'pwmled', 'usb-comparator' were unexpected)
from schema $id: http://devicetree.org/schemas/mfd/ti,twl.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/usb-comparator: failed to match any schema with compatible: ['ti,twl6030-usb']
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwm: failed to match any schema with compatible: ['ti,twl6030-pwm']
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwmled: failed to match any schema with compatible: ['ti,twl6030-pwmled']
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@4b: failed to match any schema with compatible: ['ti,twl6040']
arch/arm/boot/dts/ti/omap/omap4-panda-a4.dtb: /ocp/interconnect@48000000/segment@0/target-module@96000/mcbsp@0: failed to match any schema with compatible: ['ti,omap4-mcbsp']
--
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000: failed to match any schema with compatible: ['ti,omap4-l4-per', 'simple-pm-bus']
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: segment@0: $nodename:0: 'segment@0' does not match '^bus(@[0-9a-f]+)?$'
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: segment@0: 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'power-domains' is a required property
from schema $id: http://devicetree.org/schemas/bus/simple-pm-bus.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 74, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 74, 4], [117, 260]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@60000/i2c@0/eeprom@50: failed to match any schema with compatible: ['ti,eeprom']
>> arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 73, 4]], 'clock-frequency': 48000000, 'pinctrl-names': ['default'], 'pinctrl-0': [[119]], 'interrupts-extended': [[1, 0, 73, 4], [117, 220]], 'bluetooth': {'compatible': ['ti,wl1271-st'], 'pinctrl-names': ['default'], 'pinctrl-0': [[120]], 'enable-gpios': [[121, 14, 0]], 'clocks': [[122, 0]], 'clock-names': ['ext_clock']}, '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: serial@0: {'compatible': ['ti,omap4-uart'], 'reg': [[0, 256]], 'interrupts': [[0, 70, 4]], 'clock-frequency': 48000000, 'interrupts-extended': [[1, 0, 70, 4], [117, 284]], '$nodename': ['serial@0']} is valid under each of {'required': ['interrupts-extended']}, {'required': ['interrupts']}
from schema $id: http://devicetree.org/schemas/serial/8250_omap.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: twl@48: Unevaluated properties are not allowed ('pwm', 'pwmled', 'usb-comparator' were unexpected)
from schema $id: http://devicetree.org/schemas/mfd/ti,twl.yaml#
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/usb-comparator: failed to match any schema with compatible: ['ti,twl6030-usb']
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwm: failed to match any schema with compatible: ['ti,twl6030-pwm']
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@48/pwmled: failed to match any schema with compatible: ['ti,twl6030-pwmled']
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@70000/i2c@0/twl@4b: failed to match any schema with compatible: ['ti,twl6040']
arch/arm/boot/dts/ti/omap/omap4-panda-es.dtb: /ocp/interconnect@48000000/segment@0/target-module@96000/mcbsp@0: failed to match any schema with compatible: ['ti,omap4-mcbsp']
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements
@ 2024-12-29 23:01 Andreas Kemnade
2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Kemnade @ 2024-12-29 23:01 UTC (permalink / raw)
To: Rob Herring, Conor Dooley, linux-omap, linux-kernel,
Roger Quadros, Aaro Koskinen, Kevin Hilman, devicetree,
Krzysztof Kozlowski, Tony Lindgren
Cc: Andreas Kemnade
Add proper definitions for 32k clock and enable bluetooth
everywhere.
Andreas Kemnade (2):
ARM: dts: omap4: panda: fix resources needed for Panda
ARM: dts: omap4: panda: cleanup bluetooth
.../boot/dts/ti/omap/omap4-panda-common.dtsi | 38 ++++++++++++++++++-
arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 ----------------
2 files changed, 36 insertions(+), 34 deletions(-)
--
2.39.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade
@ 2024-12-29 23:01 ` Andreas Kemnade
2025-01-04 17:29 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Kemnade @ 2024-12-29 23:01 UTC (permalink / raw)
To: Rob Herring, Conor Dooley, linux-omap, linux-kernel,
Roger Quadros, Aaro Koskinen, Kevin Hilman, devicetree,
Krzysztof Kozlowski, Tony Lindgren
Cc: Andreas Kemnade
Bluetooth is available on the other Panda board versions, too, so move
stuff to common and specify the needed clock properly.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
.../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++--
arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 -------------------
2 files changed, 28 insertions(+), 34 deletions(-)
diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
index c860b590142a..c048ab9af053 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
+++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
@@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */
wl12xx_gpio: wl12xx-gpio-pins {
pinctrl-single,pins = <
OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
- OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */
OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
- OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */
>;
};
@@ -393,6 +391,22 @@ button_pins: button-pins {
OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */
>;
};
+
+ bt_pins: bt-pins {
+ pinctrl-single,pins = <
+ OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */
+ OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */
+ >;
+ };
+
+ uart2_pins: uart2-pins {
+ pinctrl-single,pins = <
+ OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts - HCI */
+ OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts */
+ OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx */
+ OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx */
+ >;
+ };
};
&omap4_pmx_wkup {
@@ -531,8 +545,20 @@ &twl_usb_comparator {
};
&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2_pins>;
+
interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
&omap4_pmx_core OMAP4_UART2_RX>;
+
+ bluetooth {
+ compatible = "ti,wl1271-st";
+ pinctrl-names = "default";
+ pinctrl-0 = <&bt_pins>;
+ enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */
+ clocks = <&twl 0>;
+ clock-names = "ext_clock";
+ };
};
&uart3 {
diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
index fe7b156d10ed..a933fe560834 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
@@ -49,22 +49,6 @@ button_pins: button-pins {
OMAP4_IOPAD(0x0fc, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_113 */
>;
};
-
- bt_pins: bt-pins {
- pinctrl-single,pins = <
- OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */
- OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */
- >;
- };
-
- uart2_pins: uart2-pins {
- pinctrl-single,pins = <
- OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts.uart2_cts - HCI */
- OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts.uart2_rts */
- OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx.uart2_rx */
- OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx.uart2_tx */
- >;
- };
};
&led_wkgpio_pins {
@@ -96,19 +80,3 @@ buttonS2 {
&gpio1_target {
ti,no-reset-on-init;
};
-
-&wl12xx_gpio {
- pinctrl-single,pins = <
- OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
- OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
- >;
-};
-
-&uart2 {
- pinctrl-names = "default";
- pinctrl-0 = <&uart2_pins &bt_pins>;
- bluetooth: tiwi {
- compatible = "ti,wl1271-st";
- enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */
- };
-};
--
2.39.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade
@ 2025-01-04 17:29 ` Roger Quadros
2025-01-04 18:41 ` Andreas Kemnade
0 siblings, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2025-01-04 17:29 UTC (permalink / raw)
To: Andreas Kemnade, Rob Herring, Conor Dooley, linux-omap,
linux-kernel, Aaro Koskinen, Kevin Hilman, devicetree,
Krzysztof Kozlowski, Tony Lindgren
Hello Andreas,
On 30/12/2024 01:01, Andreas Kemnade wrote:
> Bluetooth is available on the other Panda board versions, too, so move
> stuff to common and specify the needed clock properly.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++--
> arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 -------------------
> 2 files changed, 28 insertions(+), 34 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> index c860b590142a..c048ab9af053 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */
> wl12xx_gpio: wl12xx-gpio-pins {
> pinctrl-single,pins = <
> OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */
> - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */
> OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
This one is FM_EN and has nothing to do with WLAN.
> - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */
> >;
> };
>
> @@ -393,6 +391,22 @@ button_pins: button-pins {
> OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */
> >;
> };
> +
> + bt_pins: bt-pins {
> + pinctrl-single,pins = <
> + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */
> + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */
Could we please use comment style <pin name>.<pinmux name> - Function
OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */
OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */
> + >;
> + };
> +
> + uart2_pins: uart2-pins {
> + pinctrl-single,pins = <
> + OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts - HCI */
> + OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts */
> + OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx */
> + OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx */
Need to fix comment style to <pin name>.<pinmux name> - Function
> + >;
> + };
> };
>
> &omap4_pmx_wkup {
> @@ -531,8 +545,20 @@ &twl_usb_comparator {
> };
>
> &uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2_pins>;
> +
Unnecessary new line.
> interrupts-extended = <&wakeupgen GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH
> &omap4_pmx_core OMAP4_UART2_RX>;
> +
Here too?
> + bluetooth {
> + compatible = "ti,wl1271-st";
> + pinctrl-names = "default";
> + pinctrl-0 = <&bt_pins>;
> + enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */
> + clocks = <&twl 0>;
> + clock-names = "ext_clock";
> + };
> };
>
> &uart3 {
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
> index fe7b156d10ed..a933fe560834 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-es.dts
> @@ -49,22 +49,6 @@ button_pins: button-pins {
> OMAP4_IOPAD(0x0fc, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_113 */
> >;
> };
> -
> - bt_pins: bt-pins {
> - pinctrl-single,pins = <
> - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */
> - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */
> - >;
> - };
> -
> - uart2_pins: uart2-pins {
> - pinctrl-single,pins = <
> - OMAP4_IOPAD(0x118, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_cts.uart2_cts - HCI */
> - OMAP4_IOPAD(0x11a, PIN_OUTPUT | MUX_MODE0) /* uart2_rts.uart2_rts */
> - OMAP4_IOPAD(0x11c, PIN_INPUT_PULLUP | MUX_MODE0) /* uart2_rx.uart2_rx */
> - OMAP4_IOPAD(0x11e, PIN_OUTPUT | MUX_MODE0) /* uart2_tx.uart2_tx */
> - >;
> - };
> };
>
> &led_wkgpio_pins {
> @@ -96,19 +80,3 @@ buttonS2 {
> &gpio1_target {
> ti,no-reset-on-init;
> };
> -
> -&wl12xx_gpio {
> - pinctrl-single,pins = <
> - OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
> - OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
> - >;
> -};
> -
> -&uart2 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart2_pins &bt_pins>;
> - bluetooth: tiwi {
> - compatible = "ti,wl1271-st";
> - enable-gpios = <&gpio2 14 GPIO_ACTIVE_HIGH>; /* GPIO_46 */
> - };
> -};
--
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
2025-01-04 17:29 ` Roger Quadros
@ 2025-01-04 18:41 ` Andreas Kemnade
2025-01-07 12:33 ` Roger Quadros
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Kemnade @ 2025-01-04 18:41 UTC (permalink / raw)
To: Roger Quadros
Cc: Rob Herring, Conor Dooley, linux-omap, linux-kernel,
Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski,
Tony Lindgren
Hello Roger,
Am Sat, 4 Jan 2025 19:29:44 +0200
schrieb Roger Quadros <rogerq@kernel.org>:
> Hello Andreas,
>
> On 30/12/2024 01:01, Andreas Kemnade wrote:
> > Bluetooth is available on the other Panda board versions, too, so move
> > stuff to common and specify the needed clock properly.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++--
> > arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 -------------------
> > 2 files changed, 28 insertions(+), 34 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > index c860b590142a..c048ab9af053 100644
> > --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> > @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */
> > wl12xx_gpio: wl12xx-gpio-pins {
> > pinctrl-single,pins = <
> > OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
>
> We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */
>
This is about existing code, there is still a lot of room to cleanup
other stuff.
> > - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */
> > OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
>
> This one is FM_EN and has nothing to do with WLAN.
>
same here.
> > - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */
> > >;
> > };
> >
> > @@ -393,6 +391,22 @@ button_pins: button-pins {
> > OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */
> > >;
> > };
> > +
> > + bt_pins: bt-pins {
> > + pinctrl-single,pins = <
> > + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */
> > + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */
>
> Could we please use comment style <pin name>.<pinmux name> - Function
> OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */
> OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */
>
I was a bit lazy with checkpatch.pl. Your proposal generates a lot of
noise there, so I was too lazy to filter that noise, so I disabled that
noise. I had it first that way.
Regards,
Andreas
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth
2025-01-04 18:41 ` Andreas Kemnade
@ 2025-01-07 12:33 ` Roger Quadros
0 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2025-01-07 12:33 UTC (permalink / raw)
To: Andreas Kemnade
Cc: Rob Herring, Conor Dooley, linux-omap, linux-kernel,
Aaro Koskinen, Kevin Hilman, devicetree, Krzysztof Kozlowski,
Tony Lindgren
On 04/01/2025 20:41, Andreas Kemnade wrote:
> Hello Roger,
>
> Am Sat, 4 Jan 2025 19:29:44 +0200
> schrieb Roger Quadros <rogerq@kernel.org>:
>
>> Hello Andreas,
>>
>> On 30/12/2024 01:01, Andreas Kemnade wrote:
>>> Bluetooth is available on the other Panda board versions, too, so move
>>> stuff to common and specify the needed clock properly.
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>>> ---
>>> .../boot/dts/ti/omap/omap4-panda-common.dtsi | 30 +++++++++++++++--
>>> arch/arm/boot/dts/ti/omap/omap4-panda-es.dts | 32 -------------------
>>> 2 files changed, 28 insertions(+), 34 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
>>> index c860b590142a..c048ab9af053 100644
>>> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
>>> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
>>> @@ -368,9 +368,7 @@ OMAP4_IOPAD(0x130, PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */
>>> wl12xx_gpio: wl12xx-gpio-pins {
>>> pinctrl-single,pins = <
>>> OMAP4_IOPAD(0x066, PIN_OUTPUT | MUX_MODE3) /* gpmc_a19.gpio_43 */
>>
>> We could add function name in comment? e.g. /* gpmc_a19.gpio_43 - WLAN_EN */
>>
> This is about existing code, there is still a lot of room to cleanup
> other stuff.
>
>>> - OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 */
>>> OMAP4_IOPAD(0x070, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a24.gpio_48 */
>>
>> This one is FM_EN and has nothing to do with WLAN.
>>
> same here.
>>> - OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 */
>>> >;
>>> };
>>>
>>> @@ -393,6 +391,22 @@ button_pins: button-pins {
>>> OMAP4_IOPAD(0x114, PIN_INPUT_PULLUP | MUX_MODE3) /* gpio_121 */
>>> >;
>>> };
>>> +
>>> + bt_pins: bt-pins {
>>> + pinctrl-single,pins = <
>>> + OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* BTEN */
>>> + OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* BTWAKEUP */
>>
>> Could we please use comment style <pin name>.<pinmux name> - Function
>> OMAP4_IOPAD(0x06c, PIN_OUTPUT | MUX_MODE3) /* gpmc_a22.gpio_46 - BTEN */
>> OMAP4_IOPAD(0x072, PIN_OUTPUT_PULLUP | MUX_MODE3) /* gpmc_a25.gpio_49 - BTWAKEUP */
>>
> I was a bit lazy with checkpatch.pl. Your proposal generates a lot of
> noise there, so I was too lazy to filter that noise, so I disabled that
> noise. I had it first that way.
What noise? line length exceeded warnings? Those are harmless.
I'd prefer not to loose the pinmux/function information in the comment.
--
cheers,
-roger
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-07 12:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-31 10:44 [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-12-29 23:01 [PATCH 0/2] ARM: dts: omap4: panda: TiWilink improvements Andreas Kemnade
2024-12-29 23:01 ` [PATCH 2/2] ARM: dts: omap4: panda: cleanup bluetooth Andreas Kemnade
2025-01-04 17:29 ` Roger Quadros
2025-01-04 18:41 ` Andreas Kemnade
2025-01-07 12:33 ` Roger Quadros
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.