All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>
Cc: Ming Lei <ming.lei@redhat.com>, Nilay Shroff <nilay@linux.ibm.com>
Subject: [PATCH 0/3] Fix queue freeze and limit locking order
Date: Sat,  4 Jan 2025 22:25:19 +0900	[thread overview]
Message-ID: <20250104132522.247376-1-dlemoal@kernel.org> (raw)

Three patches to fix the ordering of freezing a queue with
blk_mq_freeze_queue() and obtaining a device queue limits lock with
queue_limits_start_update(). These changes ensure that a devie queue is
always frozen after the device limits lock is obtained to avoid
potential ABBA deadlocks in drivers that need to issue commands to probe
a device limits with the limits lock held (e.g. the SCSI sd driver).

Damien Le Moal (3):
  block: Fix sysfs queue freeze and limits lock order
  block: Fix __blk_mq_update_nr_hw_queues() queue freeze and limits lock
    order
  nvme: Fix queue freeze and limits lock order

 block/blk-mq.c           |  25 +++++---
 block/blk-sysfs.c        | 123 ++++++++++++++++++++-------------------
 drivers/nvme/host/core.c |   8 ++-
 3 files changed, 85 insertions(+), 71 deletions(-)

-- 
2.47.1


             reply	other threads:[~2025-01-04 13:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04 13:25 Damien Le Moal [this message]
2025-01-04 13:25 ` [PATCH 1/3] block: Fix sysfs queue freeze and limits lock order Damien Le Moal
2025-01-04 16:26   ` Nilay Shroff
2025-01-06  8:27     ` Christoph Hellwig
2025-01-06  3:31   ` Ming Lei
2025-01-06  3:35     ` Damien Le Moal
2025-01-06  3:40       ` Ming Lei
2025-01-06  8:29     ` Christoph Hellwig
2025-01-06 11:15       ` Ming Lei
2025-01-06 15:29         ` Christoph Hellwig
2025-01-07  0:45           ` Ming Lei
2025-01-07  6:18             ` Christoph Hellwig
2025-01-06  8:25   ` Christoph Hellwig
2025-01-04 13:25 ` [PATCH 2/3] block: Fix __blk_mq_update_nr_hw_queues() " Damien Le Moal
2025-01-06  8:30   ` Christoph Hellwig
2025-01-06  9:58     ` Damien Le Moal
2025-01-06 10:00       ` Christoph Hellwig
2025-01-04 13:25 ` [PATCH 3/3] nvme: Fix " Damien Le Moal
2025-01-06  8:31   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250104132522.247376-1-dlemoal@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=ming.lei@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.