From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Ming Lei <ming.lei@redhat.com>,
Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH 3/3] nvme: Fix queue freeze and limits lock order
Date: Mon, 6 Jan 2025 09:31:29 +0100 [thread overview]
Message-ID: <20250106083129.GE18408@lst.de> (raw)
In-Reply-To: <20250104132522.247376-4-dlemoal@kernel.org>
On Sat, Jan 04, 2025 at 10:25:22PM +0900, Damien Le Moal wrote:
> Modify the functions nvme_update_ns_info_generic(),
> nvme_update_ns_info_block() and nvme_update_ns_info() to freeze a
> namespace queue using blk_mq_freeze_queue() after starting the queue
> limits update with queue_limits_start_update() so that the queue
> freezing is always done after obtaining the device queue limits lock (as
> per the block layer convention for sysfs attributes).
FYI, there's a few more like this. In my WIP series I've basically
made the normal queue_limits_commit_update contain the freeze and add
a special version without the freeze, which makes a lot of this
more obvious. Let me dust it off even before sorting out the poll
flag so that we have a little more discussion material.
prev parent reply other threads:[~2025-01-06 8:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-04 13:25 [PATCH 0/3] Fix queue freeze and limit locking order Damien Le Moal
2025-01-04 13:25 ` [PATCH 1/3] block: Fix sysfs queue freeze and limits lock order Damien Le Moal
2025-01-04 16:26 ` Nilay Shroff
2025-01-06 8:27 ` Christoph Hellwig
2025-01-06 3:31 ` Ming Lei
2025-01-06 3:35 ` Damien Le Moal
2025-01-06 3:40 ` Ming Lei
2025-01-06 8:29 ` Christoph Hellwig
2025-01-06 11:15 ` Ming Lei
2025-01-06 15:29 ` Christoph Hellwig
2025-01-07 0:45 ` Ming Lei
2025-01-07 6:18 ` Christoph Hellwig
2025-01-06 8:25 ` Christoph Hellwig
2025-01-04 13:25 ` [PATCH 2/3] block: Fix __blk_mq_update_nr_hw_queues() " Damien Le Moal
2025-01-06 8:30 ` Christoph Hellwig
2025-01-06 9:58 ` Damien Le Moal
2025-01-06 10:00 ` Christoph Hellwig
2025-01-04 13:25 ` [PATCH 3/3] nvme: Fix " Damien Le Moal
2025-01-06 8:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106083129.GE18408@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.