All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Emil Tantilov <emil.s.tantilov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	larysa.zaremba@intel.com, decot@google.com, willemb@google.com,
	anthony.l.nguyen@intel.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	aleksander.lobakin@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix transaction timeouts on reset
Date: Mon, 6 Jan 2025 10:44:44 +0000	[thread overview]
Message-ID: <20250106104444.GB4068@kernel.org> (raw)
In-Reply-To: <20241220020932.32545-1-emil.s.tantilov@intel.com>

On Thu, Dec 19, 2024 at 06:09:32PM -0800, Emil Tantilov wrote:
> Restore the call to idpf_vc_xn_shutdown() at the beginning of
> idpf_vc_core_deinit() provided the function is not called on remove.
> In the reset path the mailbox is destroyed, leading to all transactions
> timing out.
> 
> Fixes: 09d0fb5cb30e ("idpf: deinit virtchnl transaction manager after vport and vectors")
> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> ---
> Changelog:
> v2:
> - Assigned the current state of REMOVE_IN_PROG flag to a boolean
>   variable, to be checked instead of reading the flag twice.
> - Updated the description to clarify the reason for the timeouts on
>   reset is due to the mailbox being destroyed.
> 
> v1:
> https://lore.kernel.org/intel-wired-lan/20241218014417.3786-1-emil.s.tantilov@intel.com/
> 
> Testing hints:
> echo 1 > /sys/class/net/<netif>/device/reset

Thanks for the update,

Reviewed-by: Simon Horman <horms@kernel.org>


WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Emil Tantilov <emil.s.tantilov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	larysa.zaremba@intel.com, decot@google.com, willemb@google.com,
	anthony.l.nguyen@intel.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	aleksander.lobakin@intel.com
Subject: Re: [PATCH iwl-net v2] idpf: fix transaction timeouts on reset
Date: Mon, 6 Jan 2025 10:44:44 +0000	[thread overview]
Message-ID: <20250106104444.GB4068@kernel.org> (raw)
In-Reply-To: <20241220020932.32545-1-emil.s.tantilov@intel.com>

On Thu, Dec 19, 2024 at 06:09:32PM -0800, Emil Tantilov wrote:
> Restore the call to idpf_vc_xn_shutdown() at the beginning of
> idpf_vc_core_deinit() provided the function is not called on remove.
> In the reset path the mailbox is destroyed, leading to all transactions
> timing out.
> 
> Fixes: 09d0fb5cb30e ("idpf: deinit virtchnl transaction manager after vport and vectors")
> Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> ---
> Changelog:
> v2:
> - Assigned the current state of REMOVE_IN_PROG flag to a boolean
>   variable, to be checked instead of reading the flag twice.
> - Updated the description to clarify the reason for the timeouts on
>   reset is due to the mailbox being destroyed.
> 
> v1:
> https://lore.kernel.org/intel-wired-lan/20241218014417.3786-1-emil.s.tantilov@intel.com/
> 
> Testing hints:
> echo 1 > /sys/class/net/<netif>/device/reset

Thanks for the update,

Reviewed-by: Simon Horman <horms@kernel.org>


  reply	other threads:[~2025-01-06 10:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  2:09 [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix transaction timeouts on reset Emil Tantilov
2024-12-20  2:09 ` Emil Tantilov
2025-01-06 10:44 ` Simon Horman [this message]
2025-01-06 10:44   ` Simon Horman
2025-01-14  6:57   ` [Intel-wired-lan] " Singh, Krishneil K
2025-01-14  6:57     ` Singh, Krishneil K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250106104444.GB4068@kernel.org \
    --to=horms@kernel.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=decot@google.com \
    --cc=edumazet@google.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=larysa.zaremba@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.