From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Intel-wired-lan] [RFC net-next 1/9] i40e: Deadcode i40e_aq_*
Date: Mon, 6 Jan 2025 11:43:03 +0000 [thread overview]
Message-ID: <20250106114303.GD4068@kernel.org> (raw)
In-Reply-To: <20241221184247.118752-2-linux@treblig.org>
On Sat, Dec 21, 2024 at 06:42:39PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> i40e_aq_add_mirrorrule(), i40e_aq_delete_mirrorrule() and
> i40e_aq_set_vsi_vlan_promisc() were added in 2016 by
> commit 7bd6875bef70 ("i40e: APIs to Add/remove port mirroring rules")
> but haven't been used.
>
> They were the last user of i40e_mirrorrule_op().
>
> i40e_aq_rearrange_nvm() was added in 2018 by
> commit f05798b4ff82 ("i40e: Add AQ command for rearrange NVM structure")
> but hasn't been used.
>
> i40e_aq_restore_lldp() was added in 2019 by
> commit c65e78f87f81 ("i40e: Further implementation of LLDP")
> but hasn't been used.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: linux@treblig.org
Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC net-next 1/9] i40e: Deadcode i40e_aq_*
Date: Mon, 6 Jan 2025 11:43:03 +0000 [thread overview]
Message-ID: <20250106114303.GD4068@kernel.org> (raw)
In-Reply-To: <20241221184247.118752-2-linux@treblig.org>
On Sat, Dec 21, 2024 at 06:42:39PM +0000, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> i40e_aq_add_mirrorrule(), i40e_aq_delete_mirrorrule() and
> i40e_aq_set_vsi_vlan_promisc() were added in 2016 by
> commit 7bd6875bef70 ("i40e: APIs to Add/remove port mirroring rules")
> but haven't been used.
>
> They were the last user of i40e_mirrorrule_op().
>
> i40e_aq_rearrange_nvm() was added in 2018 by
> commit f05798b4ff82 ("i40e: Add AQ command for rearrange NVM structure")
> but hasn't been used.
>
> i40e_aq_restore_lldp() was added in 2019 by
> commit c65e78f87f81 ("i40e: Further implementation of LLDP")
> but hasn't been used.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-01-06 11:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 18:42 [Intel-wired-lan] [RFC net-next 0/9] i40e deadcoding linux
2024-12-21 18:42 ` linux
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 1/9] i40e: Deadcode i40e_aq_* linux
2024-12-21 18:42 ` linux
2025-01-06 11:43 ` Simon Horman [this message]
2025-01-06 11:43 ` Simon Horman
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 2/9] i40e: Remove unused i40e_blink_phy_link_led linux
2024-12-21 18:42 ` linux
2024-12-23 3:13 ` [Intel-wired-lan] " Kalesh Anakkur Purayil
2024-12-23 3:13 ` Kalesh Anakkur Purayil
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 3/9] i40e: Remove unused i40e_(read|write)_phy_register linux
2024-12-21 18:42 ` linux
2025-01-06 11:43 ` [Intel-wired-lan] " Simon Horman
2025-01-06 11:43 ` Simon Horman
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 4/9] i40e: Deadcode profile code linux
2024-12-21 18:42 ` linux
2025-01-06 11:44 ` [Intel-wired-lan] " Simon Horman
2025-01-06 11:44 ` Simon Horman
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 5/9] i40e: Remove unused i40e_get_cur_guaranteed_fd_count linux
2024-12-21 18:42 ` linux
2024-12-23 3:11 ` [Intel-wired-lan] " Kalesh Anakkur Purayil
2024-12-23 3:11 ` Kalesh Anakkur Purayil
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 6/9] i40e: Remove unused i40e_del_filter linux
2024-12-21 18:42 ` linux
2025-01-06 11:44 ` [Intel-wired-lan] " Simon Horman
2025-01-06 11:44 ` Simon Horman
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 7/9] i40e: Remove unused i40e_commit_partition_bw_setting linux
2024-12-21 18:42 ` linux
2024-12-23 3:14 ` [Intel-wired-lan] " Kalesh Anakkur Purayil
2024-12-23 3:14 ` Kalesh Anakkur Purayil
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 8/9] i40e: Remove unused i40e_asq_send_command_v2 linux
2024-12-21 18:42 ` linux
2025-01-06 11:45 ` [Intel-wired-lan] " Simon Horman
2025-01-06 11:45 ` Simon Horman
2024-12-21 18:42 ` [Intel-wired-lan] [RFC net-next 9/9] i40e: Remove unused i40e_dcb_hw_get_num_tc linux
2024-12-21 18:42 ` linux
2024-12-23 3:10 ` [Intel-wired-lan] " Kalesh Anakkur Purayil
2024-12-23 3:10 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106114303.GD4068@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.