Re: Patch "watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs" has been added to the 6.6-stable tree

Re: Patch "watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs" has been added to the 6.6-stable tree

[Peter Griffin]

Hi Sasha,

+ cc stable@vger.kernel.org

On Fri, 3 Jan 2025 at 00:45, Sasha Levin <sashal@kernel.org> wrote:
>
> This is a note to let you know that I've just added the patch titled
>
>     watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs
>
> to the 6.6-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
>      watchdog-s3c2410_wdt-use-exynos_get_pmu_regmap_by_ph.patch
> and it can be found in the queue-6.6 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.

It doesn't make sense (to me at least) to add this patch and then also
add the revert of it to v6.6 stable tree, as it becomes a no-op. The
only reason I can think of is it somehow helps with your automated
tooling?

Additionally the hardware (Pixel 6 & gs101 SoC ) which these patches
and APIs were added for wasn't merged until v6.8. The revert is also
only applicable if the kernel has the corresponding enhancements made
to syscon driver to register custom regmaps. See 769cb63166d9 ("mfd:
syscon: Add of_syscon_register_regmap() API")

Thanks,

Peter

Re: Patch "watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs" has been added to the 6.6-stable tree

[Greg KH]

On Fri, Jan 03, 2025 at 04:46:54PM +0000, Peter Griffin wrote:
> Hi Sasha,
> 
> + cc stable@vger.kernel.org
> 
> On Fri, 3 Jan 2025 at 00:45, Sasha Levin <sashal@kernel.org> wrote:
> >
> > This is a note to let you know that I've just added the patch titled
> >
> >     watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs
> >
> > to the 6.6-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > The filename of the patch is:
> >      watchdog-s3c2410_wdt-use-exynos_get_pmu_regmap_by_ph.patch
> > and it can be found in the queue-6.6 subdirectory.
> >
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> 
> It doesn't make sense (to me at least) to add this patch and then also
> add the revert of it to v6.6 stable tree, as it becomes a no-op. The
> only reason I can think of is it somehow helps with your automated
> tooling?

This is exactly the reason.

> Additionally the hardware (Pixel 6 & gs101 SoC ) which these patches
> and APIs were added for wasn't merged until v6.8. The revert is also
> only applicable if the kernel has the corresponding enhancements made
> to syscon driver to register custom regmaps. See 769cb63166d9 ("mfd:
> syscon: Add of_syscon_register_regmap() API")

Ok, then we should just drop both, I can do that if you want me to.

thanks,

greg k-h

Re: Patch "watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs" has been added to the 6.6-stable tree

[Greg KH]

On Sat, Jan 04, 2025 at 09:05:37AM +0100, Greg KH wrote:
> On Fri, Jan 03, 2025 at 04:46:54PM +0000, Peter Griffin wrote:
> > Hi Sasha,
> > 
> > + cc stable@vger.kernel.org
> > 
> > On Fri, 3 Jan 2025 at 00:45, Sasha Levin <sashal@kernel.org> wrote:
> > >
> > > This is a note to let you know that I've just added the patch titled
> > >
> > >     watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs
> > >
> > > to the 6.6-stable tree which can be found at:
> > >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > The filename of the patch is:
> > >      watchdog-s3c2410_wdt-use-exynos_get_pmu_regmap_by_ph.patch
> > > and it can be found in the queue-6.6 subdirectory.
> > >
> > > If you, or anyone else, feels it should not be added to the stable tree,
> > > please let <stable@vger.kernel.org> know about it.
> > 
> > It doesn't make sense (to me at least) to add this patch and then also
> > add the revert of it to v6.6 stable tree, as it becomes a no-op. The
> > only reason I can think of is it somehow helps with your automated
> > tooling?
> 
> This is exactly the reason.
> 
> > Additionally the hardware (Pixel 6 & gs101 SoC ) which these patches
> > and APIs were added for wasn't merged until v6.8. The revert is also
> > only applicable if the kernel has the corresponding enhancements made
> > to syscon driver to register custom regmaps. See 769cb63166d9 ("mfd:
> > syscon: Add of_syscon_register_regmap() API")
> 
> Ok, then we should just drop both, I can do that if you want me to.

Now dropped.

Re: Patch "watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for PMU regs" has been added to the 6.6-stable tree

[Peter Griffin]

[..]
> >
> > Ok, then we should just drop both, I can do that if you want me to.
>
> Now dropped.

Thanks Greg