From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: remove XFS_ILOG_NONCORE
Date: Mon, 6 Jan 2025 19:10:48 +0100 [thread overview]
Message-ID: <20250106181048.GB31325@lst.de> (raw)
In-Reply-To: <20250106170953.GZ6174@frogsfrogsfrogs>
On Mon, Jan 06, 2025 at 09:09:53AM -0800, Darrick J. Wong wrote:
> > diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
> > index 15dec19b6c32..41e974d17ce2 100644
> > --- a/fs/xfs/libxfs/xfs_log_format.h
> > +++ b/fs/xfs/libxfs/xfs_log_format.h
>
> Technically this is part of the userspace ABI:
>
> $ grep NONCORE /usr/include/
> /usr/include/xfs/xfs_log_format.h:362:#define XFS_ILOG_NONCORE (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \
>
> But it makes no sense for userspace to try to use that symbol and
> Debian codesearch says there are no users, so:
In the past we've done plenty of refactoring of the format headers.
Locking us out of that would be rather painful.
next prev parent reply other threads:[~2025-01-06 18:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 9:50 trivial cleanups Christoph Hellwig
2025-01-06 9:50 ` [PATCH 1/3] xfs: mark xfs_dir_isempty static Christoph Hellwig
2025-01-06 17:07 ` Darrick J. Wong
2025-01-06 9:50 ` [PATCH 2/3] xfs: remove XFS_ILOG_NONCORE Christoph Hellwig
2025-01-06 17:09 ` Darrick J. Wong
2025-01-06 18:10 ` Christoph Hellwig [this message]
2025-01-06 9:50 ` [PATCH 3/3] xfs: remove the t_magic field in struct xfs_trans Christoph Hellwig
2025-01-06 17:11 ` Darrick J. Wong
2025-01-14 10:30 ` trivial cleanups Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250106181048.GB31325@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.