All of lore.kernel.org
 help / color / mirror / Atom feed
* [char-misc:char-misc-testing 34/74] drivers/pps/clients/pps-gpio.c:66:47: error: incompatible type for argument 1 of '_dev_warn'
@ 2025-01-07 19:37 kernel test robot
  2025-01-08 12:19 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2025-01-07 19:37 UTC (permalink / raw)
  To: Bastien Curutchet; +Cc: oe-kbuild-all, Greg Kroah-Hartman

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git char-misc-testing
head:   daec45916d68bc14406f20f547a8c39a3eab88b3
commit: 8aa0545f419e5bffbb27354e0221997cb6e87cbd [34/74] pps: clients: gpio: Bypass edge's direction check when not needed
config: arm-randconfig-001-20250108 (https://download.01.org/0day-ci/archive/20250108/202501080313.MmWpjmSe-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501080313.MmWpjmSe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501080313.MmWpjmSe-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/platform_device.h:13,
                    from drivers/pps/clients/pps-gpio.c:17:
   drivers/pps/clients/pps-gpio.c: In function 'pps_gpio_irq_handler':
>> drivers/pps/clients/pps-gpio.c:66:47: error: incompatible type for argument 1 of '_dev_warn'
      66 |                 dev_warn_ratelimited(info->pps->dev, "IRQ did not trigger any PPS event\n");
         |                                      ~~~~~~~~~^~~~~
         |                                               |
         |                                               struct device
   include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                         ^~~
   include/linux/dev_printk.h:215:17: note: in expansion of macro 'dev_warn'
     215 |                 dev_level(dev, fmt, ##__VA_ARGS__);                     \
         |                 ^~~~~~~~~
   include/linux/dev_printk.h:227:9: note: in expansion of macro 'dev_level_ratelimited'
     227 |         dev_level_ratelimited(dev_warn, dev, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~
   drivers/pps/clients/pps-gpio.c:66:17: note: in expansion of macro 'dev_warn_ratelimited'
      66 |                 dev_warn_ratelimited(info->pps->dev, "IRQ did not trigger any PPS event\n");
         |                 ^~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:52:37: note: expected 'const struct device *' but argument is of type 'struct device'
      52 | void _dev_warn(const struct device *dev, const char *fmt, ...);
         |                ~~~~~~~~~~~~~~~~~~~~~^~~


vim +/_dev_warn +66 drivers/pps/clients/pps-gpio.c

    39	
    40	/*
    41	 * Report the PPS event
    42	 */
    43	
    44	static irqreturn_t pps_gpio_irq_handler(int irq, void *data)
    45	{
    46		const struct pps_gpio_device_data *info;
    47		struct pps_event_time ts;
    48		int rising_edge;
    49	
    50		/* Get the time stamp first */
    51		pps_get_ts(&ts);
    52	
    53		info = data;
    54	
    55		/* Small trick to bypass the check on edge's direction when capture_clear is unset */
    56		rising_edge = info->capture_clear ?
    57			      gpiod_get_value(info->gpio_pin) : !info->assert_falling_edge;
    58		if ((rising_edge && !info->assert_falling_edge) ||
    59				(!rising_edge && info->assert_falling_edge))
    60			pps_event(info->pps, &ts, PPS_CAPTUREASSERT, data);
    61		else if (info->capture_clear &&
    62				((rising_edge && info->assert_falling_edge) ||
    63				(!rising_edge && !info->assert_falling_edge)))
    64			pps_event(info->pps, &ts, PPS_CAPTURECLEAR, data);
    65		else
  > 66			dev_warn_ratelimited(info->pps->dev, "IRQ did not trigger any PPS event\n");
    67	
    68		return IRQ_HANDLED;
    69	}
    70	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-08 13:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-07 19:37 [char-misc:char-misc-testing 34/74] drivers/pps/clients/pps-gpio.c:66:47: error: incompatible type for argument 1 of '_dev_warn' kernel test robot
2025-01-08 12:19 ` Greg Kroah-Hartman
2025-01-08 12:44   ` Bastien Curutchet
2025-01-08 13:18     ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.