[staging:staging-linus 11/11] (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

[staging:staging-linus 11/11] (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-linus
head:   84b172cea4a23016dc80a44eaa7ff8b7c97b04b3
commit: 84b172cea4a23016dc80a44eaa7ff8b7c97b04b3 [11/11] staging: gpib: refer to correct config symbol in tnt4882 Makefile
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202501081239.BAPhfAHJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   hppa-linux-ld: drivers/staging/gpib/tnt4882/mite.o: in function `mite_dma_disarm':
>> (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [staging:staging-linus 11/11] (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

[Lukas Bulwahn]

Hi Greg, hi Dave,

I have seen this kernel test robot report
(https://lore.kernel.org/all/Z34YDLM4zmg4cMpU@rli9-mobl/), as well as
the second report (see
https://lore.kernel.org/all/202501081213.5vHUhT8P-lkp@intel.com/).

I looked at the code and I am certain that the commit I submitted is
not the actual root cause. The change I made has enabled the driver to
be properly included in the build and hence, this is the first time
the driver is actually properly compiled, showing these linker errors
and warnings.

I assume Dave Penkler is going to fix these issues as he submitted the
driver and knows best how to address the issues before the next merge
window opens. If you think I should take care, I would probably just
submit a patch to mark this driver as broken.

In my humble opinion, reverting the patch I submitted is not a good
idea, but the forward path here is fixing the build issues or marking
it as broken, and with that, have it parked in a state where it is
clear that it is currently not being built and cannot be used.


Best regards,

Lukas


Lukas


On Wed, Jan 8, 2025 at 7:17 AM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-linus
> head:   84b172cea4a23016dc80a44eaa7ff8b7c97b04b3
> commit: 84b172cea4a23016dc80a44eaa7ff8b7c97b04b3 [11/11] staging: gpib: refer to correct config symbol in tnt4882 Makefile
> :::::: branch date: 14 hours ago
> :::::: commit date: 14 hours ago
> config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/r/202501081239.BAPhfAHJ-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    hppa-linux-ld: drivers/staging/gpib/tnt4882/mite.o: in function `mite_dma_disarm':
> >> (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>

Re: [staging:staging-linus 11/11] (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

[Greg Kroah-Hartman]

On Wed, Jan 08, 2025 at 10:17:22AM +0100, Lukas Bulwahn wrote:
> Hi Greg, hi Dave,
> 
> I have seen this kernel test robot report
> (https://lore.kernel.org/all/Z34YDLM4zmg4cMpU@rli9-mobl/), as well as
> the second report (see
> https://lore.kernel.org/all/202501081213.5vHUhT8P-lkp@intel.com/).
> 
> I looked at the code and I am certain that the commit I submitted is
> not the actual root cause. The change I made has enabled the driver to
> be properly included in the build and hence, this is the first time
> the driver is actually properly compiled, showing these linker errors
> and warnings.
> 
> I assume Dave Penkler is going to fix these issues as he submitted the
> driver and knows best how to address the issues before the next merge
> window opens. If you think I should take care, I would probably just
> submit a patch to mark this driver as broken.
> 
> In my humble opinion, reverting the patch I submitted is not a good
> idea, but the forward path here is fixing the build issues or marking
> it as broken, and with that, have it parked in a state where it is
> clear that it is currently not being built and cannot be used.

I've fixed one of these now:
	https://lore.kernel.org/r/2025010809-padding-survive-91b3@gregkh
the other one is odd so we can ignore that for now until I figure it
out as the variable is being used in the MODULE_DEVICE_TABLE() macro.

And yes, it's not your fault at all :)

thanks,

greg k-h

[staging:staging-linus 11/11] (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

[kernel test robot]

:::::: 
:::::: Manual check reason: "only suspicious fbc files changed"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: devel@driverdev.osuosl.org
TO: Lukas Bulwahn <lukas.bulwahn@redhat.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-linus
head:   84b172cea4a23016dc80a44eaa7ff8b7c97b04b3
commit: 84b172cea4a23016dc80a44eaa7ff8b7c97b04b3 [11/11] staging: gpib: refer to correct config symbol in tnt4882 Makefile
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: parisc-allyesconfig (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250108/202501081239.BAPhfAHJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202501081239.BAPhfAHJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   hppa-linux-ld: drivers/staging/gpib/tnt4882/mite.o: in function `mite_dma_disarm':
>> (.text+0x4e8): multiple definition of `mite_dma_disarm'; drivers/comedi/drivers/mite.o:(.text+0x1c4): first defined here

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki