From: "Darrick J. Wong" <djwong@kernel.org>
To: Joel Granados <joel.granados@kernel.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Kees Cook" <kees@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-crypto@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev,
codalist@coda.cs.cmu.edu, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev,
fsverity@lists.linux.dev, linux-xfs@vger.kernel.org,
io-uring@vger.kernel.org, bpf@vger.kernel.org,
kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable
Date: Thu, 9 Jan 2025 07:51:54 -0800 [thread overview]
Message-ID: <20250109155154.GP1306365@frogsfrogsfrogs> (raw)
In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org>
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote:
> Add the const qualifier to all the ctl_tables in the tree except the
> ones in ./net dir. The "net" sysctl code is special as it modifies the
> arrays before passing it on to the registration function.
>
> Constifying ctl_table structs will prevent the modification of
> proc_handler function pointers as the arrays would reside in .rodata.
> This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
> constify the ctl_table argument of proc_handlers") constified all the
> proc_handlers.
Sounds like a good idea,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> # xfs
--D
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <djwong@kernel.org>
To: Joel Granados <joel.granados@kernel.org>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Kees Cook" <kees@kernel.org>,
"Luis Chamberlain" <mcgrof@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-crypto@vger.kernel.org,
openipmi-developer@lists.sourceforge.net,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, linux-hyperv@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org,
xen-devel@lists.xenproject.org, linux-aio@kvack.org,
linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev,
codalist@coda.cs.cmu.edu, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, ocfs2-devel@lists.linux.dev,
fsverity@lists.linux.dev, linux-xfs@vger.kernel.org,
io-uring@vger.kernel.org, bpf@vger.kernel.org,
kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH] treewide: const qualify ctl_tables where applicable
Date: Thu, 9 Jan 2025 07:51:54 -0800 [thread overview]
Message-ID: <20250109155154.GP1306365@frogsfrogsfrogs> (raw)
In-Reply-To: <20250109-jag-ctl_table_const-v1-1-622aea7230cf@kernel.org>
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote:
> Add the const qualifier to all the ctl_tables in the tree except the
> ones in ./net dir. The "net" sysctl code is special as it modifies the
> arrays before passing it on to the registration function.
>
> Constifying ctl_table structs will prevent the modification of
> proc_handler function pointers as the arrays would reside in .rodata.
> This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
> constify the ctl_table argument of proc_handlers") constified all the
> proc_handlers.
Sounds like a good idea,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> # xfs
--D
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-01-09 15:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 13:16 [PATCH] treewide: const qualify ctl_tables where applicable Joel Granados
2025-01-09 13:16 ` Joel Granados
2025-01-09 14:50 ` Steven Rostedt
2025-01-09 14:50 ` Steven Rostedt
2025-01-09 14:58 ` Jani Nikula
2025-01-09 14:58 ` Jani Nikula
2025-01-09 15:00 ` Martin K. Petersen
2025-01-09 15:00 ` Martin K. Petersen
2025-01-09 15:08 ` ✗ Fi.CI.BUILD: failure for " Patchwork
2025-01-09 15:25 ` [PATCH] " Thomas Weißschuh
2025-01-09 16:55 ` Kees Cook
2025-01-10 14:12 ` Joel Granados
2025-01-09 15:45 ` Corey Minyard
2025-01-09 15:45 ` Corey Minyard
2025-01-09 15:51 ` Darrick J. Wong [this message]
2025-01-09 15:51 ` Darrick J. Wong
2025-01-09 16:10 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-09 16:11 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-10 11:40 ` Joel Granados
2025-01-09 16:12 ` ✓ CI.KUnit: success " Patchwork
2025-01-09 16:20 ` ✗ CI.Build: failure " Patchwork
2025-01-10 11:38 ` Joel Granados
2025-01-09 18:05 ` [PATCH] " Song Liu
2025-01-09 18:05 ` Song Liu
[not found] ` <501b718d1bd046bf3eb1932b11627e4cec6194f992124722840145bed109ac0a@mail.kernel.org>
[not found] ` <fnrup4bdfgoeiy3nfsl56juhqjrnstntf4fg5jrcdxv226ehqp@alrqzkyfw6sl>
2025-01-10 17:05 ` Daniel Xu
2025-01-13 8:44 ` Joel Granados
[not found] ` <Z4TnZXCjgCIGEfsR@pathway.suse.cz>
[not found] ` <42gh2e7ckwjcccorbrapeos42n4yr22koqotsu7qithb7cxl6x@ynn6yr5h7dtb>
2025-02-18 10:35 ` Joel Granados
2025-01-10 17:13 ` Dixit, Ashutosh
2025-01-10 17:13 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109155154.GP1306365@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=apparmor@lists.ubuntu.com \
--cc=bpf@vger.kernel.org \
--cc=codalist@coda.cs.cmu.edu \
--cc=dri-devel@lists.freedesktop.org \
--cc=fsverity@lists.linux.dev \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=io-uring@vger.kernel.org \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mcgrof@kernel.org \
--cc=netfs@lists.linux.dev \
--cc=ocfs2-devel@lists.linux.dev \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.