From: Simon Horman <horms@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org,
shayagr@amazon.com, kalesh-anakkur.purayil@broadcom.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: move ARFS rmap management to core
Date: Fri, 10 Jan 2025 11:59:24 +0000 [thread overview]
Message-ID: <20250110115924.GC7706@kernel.org> (raw)
In-Reply-To: <20250109233107.17519-2-ahmed.zaki@intel.com>
On Thu, Jan 09, 2025 at 04:31:02PM -0700, Ahmed Zaki wrote:
> Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should
> set the flag via netif_enable_cpu_rmap() and core will allocate and manage
> the ARFS rmap. Freeing the rmap is also done by core when the netdev is
> freed.
>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
...
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 1812564b5204..acf20191e114 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2398,6 +2398,9 @@ struct net_device {
> struct lock_class_key *qdisc_tx_busylock;
> bool proto_down;
> bool threaded;
> +#ifdef CONFIG_RFS_ACCEL
> + bool rx_cpu_rmap_auto;
> +#endif
nit: rx_cpu_rmap_auto should also be added to the Kernel doc for
struct net_device.
>
> /* priv_flags_slow, ungrouped to save space */
> unsigned long see_all_hwtstamp_requests:1;
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
jdamato@fastly.com, shayd@nvidia.com, akpm@linux-foundation.org,
shayagr@amazon.com, kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH net-next v4 1/6] net: move ARFS rmap management to core
Date: Fri, 10 Jan 2025 11:59:24 +0000 [thread overview]
Message-ID: <20250110115924.GC7706@kernel.org> (raw)
In-Reply-To: <20250109233107.17519-2-ahmed.zaki@intel.com>
On Thu, Jan 09, 2025 at 04:31:02PM -0700, Ahmed Zaki wrote:
> Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should
> set the flag via netif_enable_cpu_rmap() and core will allocate and manage
> the ARFS rmap. Freeing the rmap is also done by core when the netdev is
> freed.
>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
...
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 1812564b5204..acf20191e114 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -2398,6 +2398,9 @@ struct net_device {
> struct lock_class_key *qdisc_tx_busylock;
> bool proto_down;
> bool threaded;
> +#ifdef CONFIG_RFS_ACCEL
> + bool rx_cpu_rmap_auto;
> +#endif
nit: rx_cpu_rmap_auto should also be added to the Kernel doc for
struct net_device.
>
> /* priv_flags_slow, ungrouped to save space */
> unsigned long see_all_hwtstamp_requests:1;
...
next prev parent reply other threads:[~2025-01-10 11:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 23:31 [Intel-wired-lan] [PATCH net-next v4 0/6] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 1/6] net: move ARFS rmap management to core Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-10 11:59 ` Simon Horman [this message]
2025-01-10 11:59 ` Simon Horman
2025-01-10 15:13 ` [Intel-wired-lan] " Ahmed Zaki
2025-01-10 15:13 ` Ahmed Zaki
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 2/6] net: napi: add internal ARFS rmap management Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-10 11:55 ` [Intel-wired-lan] " Simon Horman
2025-01-10 11:55 ` Simon Horman
2025-01-10 15:16 ` [Intel-wired-lan] " Ahmed Zaki
2025-01-10 15:16 ` Ahmed Zaki
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 3/6] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-10 2:28 ` [Intel-wired-lan] " kernel test robot
2025-01-10 3:00 ` kernel test robot
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 4/6] bnxt: use napi's irq affinity Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 5/6] ice: " Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
2025-01-09 23:31 ` [Intel-wired-lan] [PATCH net-next v4 6/6] idpf: " Ahmed Zaki
2025-01-09 23:31 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110115924.GC7706@kernel.org \
--to=horms@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayagr@amazon.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.