From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Naladala Ramanaidu <ramanaidu.naladala@intel.com>,
Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t 1/8] data: Move PNG images to new data directory
Date: Sat, 11 Jan 2025 01:20:53 +0530 [thread overview]
Message-ID: <20250110195100.150301-2-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250110195100.150301-1-swati2.sharma@intel.com>
From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Placing png images inside "tests/" directory seems wrong, as these
are not source files. These images should ideally be in a directory
with other non-exec files, so creating a new "data/" directory to
store such non-exec files.
v2: Update commit message subject (Kamil)
Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
{tests => data}/1080p-left.png | Bin
{tests => data}/1080p-right.png | Bin
data/meson.build | 11 +++++++++++
{tests => data}/pass.png | Bin
lib/meson.build | 1 +
meson.build | 2 ++
tests/meson.build | 6 ------
7 files changed, 14 insertions(+), 6 deletions(-)
rename {tests => data}/1080p-left.png (100%)
rename {tests => data}/1080p-right.png (100%)
create mode 100644 data/meson.build
rename {tests => data}/pass.png (100%)
diff --git a/tests/1080p-left.png b/data/1080p-left.png
similarity index 100%
rename from tests/1080p-left.png
rename to data/1080p-left.png
diff --git a/tests/1080p-right.png b/data/1080p-right.png
similarity index 100%
rename from tests/1080p-right.png
rename to data/1080p-right.png
diff --git a/data/meson.build b/data/meson.build
new file mode 100644
index 000000000..9490d20ac
--- /dev/null
+++ b/data/meson.build
@@ -0,0 +1,11 @@
+image_files = [
+ '1080p-left.png',
+ '1080p-right.png',
+ 'pass.png',
+]
+
+foreach img : image_files
+ configure_file(output:img, input:img, copy:true)
+endforeach
+
+install_data(sources : image_files, install_dir : datadir)
diff --git a/tests/pass.png b/data/pass.png
similarity index 100%
rename from tests/pass.png
rename to data/pass.png
diff --git a/lib/meson.build b/lib/meson.build
index 1704ed1e1..afa09ae02 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -240,6 +240,7 @@ foreach f: lib_sources
'-DIGT_DATADIR="@0@"'.format(join_paths(prefix, datadir)),
'-DIGT_SRCDIR="@0@"'.format(srcdir),
'-DIGT_LOG_DOMAIN="@0@"'.format(f.split('.')[0]),
+ '-DIGT_IMGDIR="@0@"'.format(imgdir),
])
lib_intermediates += lib
diff --git a/meson.build b/meson.build
index 5eda2d582..2c2c304b1 100644
--- a/meson.build
+++ b/meson.build
@@ -293,6 +293,7 @@ vmwgfxdir = join_paths(libexecdir, 'vmwgfx')
mandir = get_option('mandir')
pkgconfigdir = join_paths(libdir, 'pkgconfig')
python3 = find_program('python3', required : true)
+imgdir = join_paths(build_root, 'data')
if get_option('use_rpath')
# Set up runpath for the test executables towards libigt.so.
@@ -388,6 +389,7 @@ endif
subdir('overlay')
subdir('man')
subdir('docs')
+subdir('data')
message('Build options')
message('=============')
diff --git a/tests/meson.build b/tests/meson.build
index 89bba6454..a8d875d36 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -510,11 +510,5 @@ if not meson.is_cross_build()
output : 'gem_stress.testlist')
endif
-image_files = [
- '1080p-left.png',
- '1080p-right.png',
- 'pass.png',
-]
-install_data(sources : image_files, install_dir : datadir)
subdir('intel-ci')
--
2.25.1
next prev parent reply other threads:[~2025-01-10 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 19:50 [PATCH i-g-t 0/8] New sharpness tool Swati Sharma
2025-01-10 19:50 ` Swati Sharma [this message]
2025-01-10 19:50 ` [PATCH i-g-t 2/8] runner/settings: Constify absolute_path parameter Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 3/8] runner/settings: Add function to set IGT_RUNNER_DATA environment variable Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 4/8] lib/igt_core: Enhance __igt_fopen_data to support additional directories Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 5/8] lib/igt_kms: Add "sharpness strength" as crtc property Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 6/8] tools: Add new sharpness tool Swati Sharma
2025-04-08 18:48 ` Naladala, Ramanaidu
2025-01-10 19:50 ` [PATCH i-g-t 7/8] data: Add image Swati Sharma
2025-01-10 19:51 ` [PATCH i-g-t 8/8] meson: Add sharpness tool Swati Sharma
2025-01-10 20:02 ` ✗ Fi.CI.BUILD: failure for New sharpness tool (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110195100.150301-2-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.