From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Subject: [PATCH i-g-t 2/8] runner/settings: Constify absolute_path parameter
Date: Sat, 11 Jan 2025 01:20:54 +0530 [thread overview]
Message-ID: <20250110195100.150301-3-swati2.sharma@intel.com> (raw)
In-Reply-To: <20250110195100.150301-1-swati2.sharma@intel.com>
From: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
Modified absolute_path to use const char* for input, updating the
corresponding declaration. This ensures the input path remains
unmodified, enhancing code safety and clarity.
v2: Update commit subject. (kmail)
Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
---
runner/settings.c | 2 +-
runner/settings.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/runner/settings.c b/runner/settings.c
index 92fd42ea6..bea0c3059 100644
--- a/runner/settings.c
+++ b/runner/settings.c
@@ -567,7 +567,7 @@ static char *_basename(const char *path)
return tmpname;
}
-char *absolute_path(char *path)
+char *absolute_path(const char *path)
{
char *result = NULL;
char *base, *dir;
diff --git a/runner/settings.h b/runner/settings.h
index f69f09778..7e6cd11e2 100644
--- a/runner/settings.h
+++ b/runner/settings.h
@@ -136,7 +136,7 @@ bool parse_options(int argc, char **argv,
bool validate_settings(struct settings *settings);
/* TODO: Better place for this */
-char *absolute_path(char *path);
+char *absolute_path(const char *path);
/**
* serialize_settings:
--
2.25.1
next prev parent reply other threads:[~2025-01-10 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 19:50 [PATCH i-g-t 0/8] New sharpness tool Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 1/8] data: Move PNG images to new data directory Swati Sharma
2025-01-10 19:50 ` Swati Sharma [this message]
2025-01-10 19:50 ` [PATCH i-g-t 3/8] runner/settings: Add function to set IGT_RUNNER_DATA environment variable Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 4/8] lib/igt_core: Enhance __igt_fopen_data to support additional directories Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 5/8] lib/igt_kms: Add "sharpness strength" as crtc property Swati Sharma
2025-01-10 19:50 ` [PATCH i-g-t 6/8] tools: Add new sharpness tool Swati Sharma
2025-04-08 18:48 ` Naladala, Ramanaidu
2025-01-10 19:50 ` [PATCH i-g-t 7/8] data: Add image Swati Sharma
2025-01-10 19:51 ` [PATCH i-g-t 8/8] meson: Add sharpness tool Swati Sharma
2025-01-10 20:02 ` ✗ Fi.CI.BUILD: failure for New sharpness tool (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110195100.150301-3-swati2.sharma@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ramanaidu.naladala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.