* [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
@ 2025-01-08 20:51 Andrew Davis
2025-01-10 18:06 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Davis @ 2025-01-08 20:51 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, meta-ti; +Cc: Andrew Davis
Like we do with GPU support, GC320 support is conditional on the
kernel we are building and so should be disabled here for kernels
on which it is not functional yet.
We can then remove these disabling lines as the driver is updated
for each supported kernel, instead of blanket disabling in the
distro layer as done currently.
Signed-off-by: Andrew Davis <afd@ti.com>
---
Changes for v2:
- Rebased on latest with new meta-beagle layer
meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc b/meta-beagle/conf/machine/include/beagle-bsp.inc
index 34889b41..06483ba9 100644
--- a/meta-beagle/conf/machine/include/beagle-bsp.inc
+++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
+
# ==========
# bb_org-6_6
# BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
+
+# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
index 4bbe7668..6773bb7a 100644
--- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
+++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
# in mainline, usually present in TI staging or derivative like BB.org
MACHINE_FEATURES:remove:bsp-mainline = "gpu"
+# GC320 support requires out-of-tree drivers not available in mainline
+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
+
# ==========
# next
# upcoming upstream/mainline kernel, u-boot
@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
# in next, usually present in TI staging or derivative like BB.org
MACHINE_FEATURES:remove:bsp-next = "gpu"
+# GC320 support requires out-of-tree drivers not available in next
+MACHINE_FEATURES:remove:bsp-next = "gc320"
+
# ==========
# ti-6_12
# TI staging kernel 6.12, u-boot 2024.10
@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
# in 6.12 yet
MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
+# GC320 support requires out-of-tree drivers not yet available in 6.12
+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
+
# ==========
# ti-6_6
# TI staging kernel 6.6, u-boot 2024.04
@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
+# GC320 support requires out-of-tree drivers not yet available in 6.6
+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
+
# ==========
# ti-6_1
# TI staging kernel 6.1, u-boot 2023.04
@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
+# GC320 support requires out-of-tree drivers not yet available in 6.1
+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
+
# ==========
# sane fallback defaults
# if specific values are not defined or bsp is set incorrectly
--
2.39.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
2025-01-08 20:51 [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version Andrew Davis
@ 2025-01-10 18:06 ` Denys Dmytriyenko
2025-01-10 19:30 ` Ryan Eatmon
[not found] ` <18196B9D6FC9E354.10803@lists.yoctoproject.org>
0 siblings, 2 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2025-01-10 18:06 UTC (permalink / raw)
To: afd; +Cc: Ryan Eatmon, meta-ti
On Wed, Jan 08, 2025 at 02:51:45PM -0600, Andrew Davis via lists.yoctoproject.org wrote:
> Like we do with GPU support, GC320 support is conditional on the
> kernel we are building and so should be disabled here for kernels
> on which it is not functional yet.
>
> We can then remove these disabling lines as the driver is updated
> for each supported kernel, instead of blanket disabling in the
> distro layer as done currently.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Changes for v2:
> - Rebased on latest with new meta-beagle layer
>
> meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
> 2 files changed, 21 insertions(+)
>
> diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc b/meta-beagle/conf/machine/include/beagle-bsp.inc
> index 34889b41..06483ba9 100644
> --- a/meta-beagle/conf/machine/include/beagle-bsp.inc
> +++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
> @@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
> BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
>
> +# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
> +MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
> +
> # ==========
> # bb_org-6_6
> # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
> @@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
> BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
> BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
> +
> +# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
> +MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> index 4bbe7668..6773bb7a 100644
> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
> # in mainline, usually present in TI staging or derivative like BB.org
> MACHINE_FEATURES:remove:bsp-mainline = "gpu"
>
> +# GC320 support requires out-of-tree drivers not available in mainline
> +MACHINE_FEATURES:remove:bsp-mainline = "gc320"
> +
> # ==========
> # next
> # upcoming upstream/mainline kernel, u-boot
> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
> # in next, usually present in TI staging or derivative like BB.org
> MACHINE_FEATURES:remove:bsp-next = "gpu"
>
> +# GC320 support requires out-of-tree drivers not available in next
> +MACHINE_FEATURES:remove:bsp-next = "gc320"
Andrew, Ryan,
Something went wrong here ^^^
Instead of removing "gc320" for bsp-next, like in the patch here, it got
committed removing it for bsp-ti-6_12 twice:
https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3
Was there any manual massaging involved?
> +
> # ==========
> # ti-6_12
> # TI staging kernel 6.12, u-boot 2024.10
> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
> # in 6.12 yet
> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
>
> +# GC320 support requires out-of-tree drivers not yet available in 6.12
> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
> +
> # ==========
> # ti-6_6
> # TI staging kernel 6.6, u-boot 2024.04
> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
>
> +# GC320 support requires out-of-tree drivers not yet available in 6.6
> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
> +
> # ==========
> # ti-6_1
> # TI staging kernel 6.1, u-boot 2023.04
> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
>
> +# GC320 support requires out-of-tree drivers not yet available in 6.1
> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
> +
> # ==========
> # sane fallback defaults
> # if specific values are not defined or bsp is set incorrectly
> --
> 2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
2025-01-10 18:06 ` Denys Dmytriyenko
@ 2025-01-10 19:30 ` Ryan Eatmon
[not found] ` <18196B9D6FC9E354.10803@lists.yoctoproject.org>
1 sibling, 0 replies; 6+ messages in thread
From: Ryan Eatmon @ 2025-01-10 19:30 UTC (permalink / raw)
To: Denys Dmytriyenko, afd; +Cc: meta-ti
On 1/10/2025 12:06 PM, Denys Dmytriyenko wrote:
> On Wed, Jan 08, 2025 at 02:51:45PM -0600, Andrew Davis via lists.yoctoproject.org wrote:
>> Like we do with GPU support, GC320 support is conditional on the
>> kernel we are building and so should be disabled here for kernels
>> on which it is not functional yet.
>>
>> We can then remove these disabling lines as the driver is updated
>> for each supported kernel, instead of blanket disabling in the
>> distro layer as done currently.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>>
>> Changes for v2:
>> - Rebased on latest with new meta-beagle layer
>>
>> meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
>> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
>> 2 files changed, 21 insertions(+)
>>
>> diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc b/meta-beagle/conf/machine/include/beagle-bsp.inc
>> index 34889b41..06483ba9 100644
>> --- a/meta-beagle/conf/machine/include/beagle-bsp.inc
>> +++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
>> @@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
>>
>> +# GC320 support requires out-of-tree drivers not yet available in bb.org 6.1
>> +MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
>> +
>> # ==========
>> # bb_org-6_6
>> # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
>> @@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 = "ti-img-rogue-driver"
>> BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
>> +
>> +# GC320 support requires out-of-tree drivers not yet available in bb.org 6.6
>> +MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
>> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>> index 4bbe7668..6773bb7a 100644
>> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
>> # in mainline, usually present in TI staging or derivative like BB.org
>> MACHINE_FEATURES:remove:bsp-mainline = "gpu"
>>
>> +# GC320 support requires out-of-tree drivers not available in mainline
>> +MACHINE_FEATURES:remove:bsp-mainline = "gc320"
>> +
>> # ==========
>> # next
>> # upcoming upstream/mainline kernel, u-boot
>> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
>> # in next, usually present in TI staging or derivative like BB.org
>> MACHINE_FEATURES:remove:bsp-next = "gpu"
>>
>> +# GC320 support requires out-of-tree drivers not available in next
>> +MACHINE_FEATURES:remove:bsp-next = "gc320"
>
> Andrew, Ryan,
>
> Something went wrong here ^^^
> Instead of removing "gc320" for bsp-next, like in the patch here, it got
> committed removing it for bsp-ti-6_12 twice:
>
> https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3
>
> Was there any manual massaging involved?
Yes. I did. Let me look at it.
>
>> +
>> # ==========
>> # ti-6_12
>> # TI staging kernel 6.12, u-boot 2024.10
>> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
>> # in 6.12 yet
>> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
>>
>> +# GC320 support requires out-of-tree drivers not yet available in 6.12
>> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
>> +
>> # ==========
>> # ti-6_6
>> # TI staging kernel 6.6, u-boot 2024.04
>> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
>> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
>>
>> +# GC320 support requires out-of-tree drivers not yet available in 6.6
>> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
>> +
>> # ==========
>> # ti-6_1
>> # TI staging kernel 6.1, u-boot 2023.04
>> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
>> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
>>
>> +# GC320 support requires out-of-tree drivers not yet available in 6.1
>> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
>> +
>> # ==========
>> # sane fallback defaults
>> # if specific values are not defined or bsp is set incorrectly
>> --
>> 2.39.2
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
[not found] ` <18196B9D6FC9E354.10803@lists.yoctoproject.org>
@ 2025-01-10 20:00 ` Ryan Eatmon
2025-01-11 0:45 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Eatmon @ 2025-01-10 20:00 UTC (permalink / raw)
To: Denys Dmytriyenko, afd; +Cc: meta-ti
On 1/10/2025 1:30 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>
>
> On 1/10/2025 12:06 PM, Denys Dmytriyenko wrote:
>> On Wed, Jan 08, 2025 at 02:51:45PM -0600, Andrew Davis via
>> lists.yoctoproject.org wrote:
>>> Like we do with GPU support, GC320 support is conditional on the
>>> kernel we are building and so should be disabled here for kernels
>>> on which it is not functional yet.
>>>
>>> We can then remove these disabling lines as the driver is updated
>>> for each supported kernel, instead of blanket disabling in the
>>> distro layer as done currently.
>>>
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>>
>>> Changes for v2:
>>> - Rebased on latest with new meta-beagle layer
>>>
>>> meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
>>> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
>>> 2 files changed, 21 insertions(+)
>>>
>>> diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc
>>> b/meta-beagle/conf/machine/include/beagle-bsp.inc
>>> index 34889b41..06483ba9 100644
>>> --- a/meta-beagle/conf/machine/include/beagle-bsp.inc
>>> +++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
>>> @@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
>>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
>>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
>>> +# GC320 support requires out-of-tree drivers not yet available in
>>> bb.org 6.1
>>> +MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
>>> +
>>> # ==========
>>> # bb_org-6_6
>>> # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
>>> @@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 =
>>> "ti-img-rogue-driver"
>>> BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
>>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
>>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
>>> +
>>> +# GC320 support requires out-of-tree drivers not yet available in
>>> bb.org 6.6
>>> +MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
>>> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>> b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>> index 4bbe7668..6773bb7a 100644
>>> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
>>> # in mainline, usually present in TI staging or derivative like BB.org
>>> MACHINE_FEATURES:remove:bsp-mainline = "gpu"
>>> +# GC320 support requires out-of-tree drivers not available in mainline
>>> +MACHINE_FEATURES:remove:bsp-mainline = "gc320"
>>> +
>>> # ==========
>>> # next
>>> # upcoming upstream/mainline kernel, u-boot
>>> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
>>> # in next, usually present in TI staging or derivative like BB.org
>>> MACHINE_FEATURES:remove:bsp-next = "gpu"
>>> +# GC320 support requires out-of-tree drivers not available in next
>>> +MACHINE_FEATURES:remove:bsp-next = "gc320"
>>
>> Andrew, Ryan,
>>
>> Something went wrong here ^^^
>> Instead of removing "gc320" for bsp-next, like in the patch here, it got
>> committed removing it for bsp-ti-6_12 twice:
>>
>> https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3
>>
>> Was there any manual massaging involved?
>
> Yes. I did. Let me look at it.
Fixed on master-wip, scarthgap-wip was correct.
>
>>
>>> +
>>> # ==========
>>> # ti-6_12
>>> # TI staging kernel 6.12, u-boot 2024.10
>>> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
>>> # in 6.12 yet
>>> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
>>> +# GC320 support requires out-of-tree drivers not yet available in 6.12
>>> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
>>> +
>>> # ==========
>>> # ti-6_6
>>> # TI staging kernel 6.6, u-boot 2024.04
>>> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
>>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
>>> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
>>> +# GC320 support requires out-of-tree drivers not yet available in 6.6
>>> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
>>> +
>>> # ==========
>>> # ti-6_1
>>> # TI staging kernel 6.1, u-boot 2023.04
>>> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
>>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
>>> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
>>> +# GC320 support requires out-of-tree drivers not yet available in 6.1
>>> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
>>> +
>>> # ==========
>>> # sane fallback defaults
>>> # if specific values are not defined or bsp is set incorrectly
>>> --
>>> 2.39.2
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#18179): https://lists.yoctoproject.org/g/meta-ti/message/18179
> Mute This Topic: https://lists.yoctoproject.org/mt/110504595/6551054
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [reatmon@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
2025-01-10 20:00 ` Ryan Eatmon
@ 2025-01-11 0:45 ` Denys Dmytriyenko
2025-01-12 20:15 ` Ryan Eatmon
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2025-01-11 0:45 UTC (permalink / raw)
To: Ryan Eatmon; +Cc: afd, meta-ti
On Fri, Jan 10, 2025 at 02:00:26PM -0600, Ryan Eatmon wrote:
>
>
> On 1/10/2025 1:30 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >
> >
> >On 1/10/2025 12:06 PM, Denys Dmytriyenko wrote:
> >>On Wed, Jan 08, 2025 at 02:51:45PM -0600, Andrew Davis via
> >>lists.yoctoproject.org wrote:
> >>>Like we do with GPU support, GC320 support is conditional on the
> >>>kernel we are building and so should be disabled here for kernels
> >>>on which it is not functional yet.
> >>>
> >>>We can then remove these disabling lines as the driver is updated
> >>>for each supported kernel, instead of blanket disabling in the
> >>>distro layer as done currently.
> >>>
> >>>Signed-off-by: Andrew Davis <afd@ti.com>
> >>>---
> >>>
> >>>Changes for v2:
> >>> - Rebased on latest with new meta-beagle layer
> >>>
> >>> meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
> >>> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
> >>> 2 files changed, 21 insertions(+)
> >>>
> >>>diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc
> >>>b/meta-beagle/conf/machine/include/beagle-bsp.inc
> >>>index 34889b41..06483ba9 100644
> >>>--- a/meta-beagle/conf/machine/include/beagle-bsp.inc
> >>>+++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
> >>>@@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
> >>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
> >>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
> >>>+# GC320 support requires out-of-tree drivers not yet
> >>>available in bb.org 6.1
> >>>+MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
> >>>+
> >>> # ==========
> >>> # bb_org-6_6
> >>> # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
> >>>@@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 =
> >>>"ti-img-rogue-driver"
> >>> BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
> >>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
> >>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
> >>>+
> >>>+# GC320 support requires out-of-tree drivers not yet
> >>>available in bb.org 6.6
> >>>+MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
> >>>diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> >>>b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> >>>index 4bbe7668..6773bb7a 100644
> >>>--- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> >>>+++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
> >>>@@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
> >>> # in mainline, usually present in TI staging or derivative like BB.org
> >>> MACHINE_FEATURES:remove:bsp-mainline = "gpu"
> >>>+# GC320 support requires out-of-tree drivers not available in mainline
> >>>+MACHINE_FEATURES:remove:bsp-mainline = "gc320"
> >>>+
> >>> # ==========
> >>> # next
> >>> # upcoming upstream/mainline kernel, u-boot
> >>>@@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
> >>> # in next, usually present in TI staging or derivative like BB.org
> >>> MACHINE_FEATURES:remove:bsp-next = "gpu"
> >>>+# GC320 support requires out-of-tree drivers not available in next
> >>>+MACHINE_FEATURES:remove:bsp-next = "gc320"
> >>
> >>Andrew, Ryan,
> >>
> >>Something went wrong here ^^^
> >>Instead of removing "gc320" for bsp-next, like in the patch here, it got
> >>committed removing it for bsp-ti-6_12 twice:
> >>
> >>https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3
> >>
> >>Was there any manual massaging involved?
> >
> >Yes. I did. Let me look at it.
>
> Fixed on master-wip, scarthgap-wip was correct.
bsp-ti-6_next ?
> >>>+
> >>> # ==========
> >>> # ti-6_12
> >>> # TI staging kernel 6.12, u-boot 2024.10
> >>>@@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
> >>> # in 6.12 yet
> >>> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
> >>>+# GC320 support requires out-of-tree drivers not yet available in 6.12
> >>>+MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
> >>>+
> >>> # ==========
> >>> # ti-6_6
> >>> # TI staging kernel 6.6, u-boot 2024.04
> >>>@@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
> >>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
> >>> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
> >>>+# GC320 support requires out-of-tree drivers not yet available in 6.6
> >>>+MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
> >>>+
> >>> # ==========
> >>> # ti-6_1
> >>> # TI staging kernel 6.1, u-boot 2023.04
> >>>@@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
> >>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
> >>> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
> >>>+# GC320 support requires out-of-tree drivers not yet available in 6.1
> >>>+MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
> >>>+
> >>> # ==========
> >>> # sane fallback defaults
> >>> # if specific values are not defined or bsp is set incorrectly
> >>>--
> >>>2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version
2025-01-11 0:45 ` Denys Dmytriyenko
@ 2025-01-12 20:15 ` Ryan Eatmon
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Eatmon @ 2025-01-12 20:15 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: afd, meta-ti
On 1/10/2025 6:45 PM, Denys Dmytriyenko wrote:
> On Fri, Jan 10, 2025 at 02:00:26PM -0600, Ryan Eatmon wrote:
>>
>>
>> On 1/10/2025 1:30 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>>>
>>>
>>> On 1/10/2025 12:06 PM, Denys Dmytriyenko wrote:
>>>> On Wed, Jan 08, 2025 at 02:51:45PM -0600, Andrew Davis via
>>>> lists.yoctoproject.org wrote:
>>>>> Like we do with GPU support, GC320 support is conditional on the
>>>>> kernel we are building and so should be disabled here for kernels
>>>>> on which it is not functional yet.
>>>>>
>>>>> We can then remove these disabling lines as the driver is updated
>>>>> for each supported kernel, instead of blanket disabling in the
>>>>> distro layer as done currently.
>>>>>
>>>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>>>> ---
>>>>>
>>>>> Changes for v2:
>>>>> - Rebased on latest with new meta-beagle layer
>>>>>
>>>>> meta-beagle/conf/machine/include/beagle-bsp.inc | 6 ++++++
>>>>> meta-ti-bsp/conf/machine/include/ti-bsp.inc | 15 +++++++++++++++
>>>>> 2 files changed, 21 insertions(+)
>>>>>
>>>>> diff --git a/meta-beagle/conf/machine/include/beagle-bsp.inc
>>>>> b/meta-beagle/conf/machine/include/beagle-bsp.inc
>>>>> index 34889b41..06483ba9 100644
>>>>> --- a/meta-beagle/conf/machine/include/beagle-bsp.inc
>>>>> +++ b/meta-beagle/conf/machine/include/beagle-bsp.inc
>>>>> @@ -23,6 +23,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_1 = "23%"
>>>>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_1 = "23%"
>>>>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_1 = "22%"
>>>>> +# GC320 support requires out-of-tree drivers not yet
>>>>> available in bb.org 6.1
>>>>> +MACHINE_FEATURES:remove:bsp-bb_org-6_1 = "gc320"
>>>>> +
>>>>> # ==========
>>>>> # bb_org-6_6
>>>>> # BeagleBoard.org kernel 6.6, Upstream u-boot 2024.07
>>>>> @@ -41,3 +44,6 @@ BSP_ROGUE_DRIVER_PROVIDER:bsp-bb_org-6_6 =
>>>>> "ti-img-rogue-driver"
>>>>> BSP_ROGUE_DRIVER_VERSION:bsp-bb_org-6_6 = "24%"
>>>>> BSP_ROGUE_UMLIBS_VERSION:bsp-bb_org-6_6 = "24%"
>>>>> BSP_MESA_PVR_VERSION:bsp-bb_org-6_6 = "23%"
>>>>> +
>>>>> +# GC320 support requires out-of-tree drivers not yet
>>>>> available in bb.org 6.6
>>>>> +MACHINE_FEATURES:remove:bsp-bb_org-6_6 = "gc320"
>>>>> diff --git a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>>>> b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>>>> index 4bbe7668..6773bb7a 100644
>>>>> --- a/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>>>> +++ b/meta-ti-bsp/conf/machine/include/ti-bsp.inc
>>>>> @@ -22,6 +22,9 @@ BSP_BOOTLOADER_VERSION:bsp-mainline = "%"
>>>>> # in mainline, usually present in TI staging or derivative like BB.org
>>>>> MACHINE_FEATURES:remove:bsp-mainline = "gpu"
>>>>> +# GC320 support requires out-of-tree drivers not available in mainline
>>>>> +MACHINE_FEATURES:remove:bsp-mainline = "gc320"
>>>>> +
>>>>> # ==========
>>>>> # next
>>>>> # upcoming upstream/mainline kernel, u-boot
>>>>> @@ -35,6 +38,9 @@ BSP_BOOTLOADER_VERSION:bsp-next = "%"
>>>>> # in next, usually present in TI staging or derivative like BB.org
>>>>> MACHINE_FEATURES:remove:bsp-next = "gpu"
>>>>> +# GC320 support requires out-of-tree drivers not available in next
>>>>> +MACHINE_FEATURES:remove:bsp-next = "gc320"
>>>>
>>>> Andrew, Ryan,
>>>>
>>>> Something went wrong here ^^^
>>>> Instead of removing "gc320" for bsp-next, like in the patch here, it got
>>>> committed removing it for bsp-ti-6_12 twice:
>>>>
>>>> https://git.yoctoproject.org/meta-ti/commit/?h=master-wip&id=fe0b35f5f135b98d1ee0f8fe2488b10fbe9a7bb3
>>>>
>>>> Was there any manual massaging involved?
>>>
>>> Yes. I did. Let me look at it.
>>
>> Fixed on master-wip, scarthgap-wip was correct.
>
> bsp-ti-6_next ?
Sigh... Fixed for real this time.
>
>>>>> +
>>>>> # ==========
>>>>> # ti-6_12
>>>>> # TI staging kernel 6.12, u-boot 2024.10
>>>>> @@ -48,6 +54,9 @@ BSP_BOOTLOADER_VERSION:bsp-ti-6_12 = "2024.10%"
>>>>> # in 6.12 yet
>>>>> MACHINE_FEATURES:remove:bsp-ti-6_12 = "gpu"
>>>>> +# GC320 support requires out-of-tree drivers not yet available in 6.12
>>>>> +MACHINE_FEATURES:remove:bsp-ti-6_12 = "gc320"
>>>>> +
>>>>> # ==========
>>>>> # ti-6_6
>>>>> # TI staging kernel 6.6, u-boot 2024.04
>>>>> @@ -65,6 +74,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_6 = "24%"
>>>>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_6 = "24%"
>>>>> BSP_MESA_PVR_VERSION:bsp-ti-6_6 = "23%"
>>>>> +# GC320 support requires out-of-tree drivers not yet available in 6.6
>>>>> +MACHINE_FEATURES:remove:bsp-ti-6_6 = "gc320"
>>>>> +
>>>>> # ==========
>>>>> # ti-6_1
>>>>> # TI staging kernel 6.1, u-boot 2023.04
>>>>> @@ -82,6 +94,9 @@ BSP_ROGUE_DRIVER_VERSION:bsp-ti-6_1 = "23%"
>>>>> BSP_ROGUE_UMLIBS_VERSION:bsp-ti-6_1 = "23%"
>>>>> BSP_MESA_PVR_VERSION:bsp-ti-6_1 = "22%"
>>>>> +# GC320 support requires out-of-tree drivers not yet available in 6.1
>>>>> +MACHINE_FEATURES:remove:bsp-ti-6_1 = "gc320"
>>>>> +
>>>>> # ==========
>>>>> # sane fallback defaults
>>>>> # if specific values are not defined or bsp is set incorrectly
>>>>> --
>>>>> 2.39.2
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-12 20:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 20:51 [meta-ti][scarthgap/master][PATCH v2] ti-bsp: Disable GC320 support conditionally on BSP version Andrew Davis
2025-01-10 18:06 ` Denys Dmytriyenko
2025-01-10 19:30 ` Ryan Eatmon
[not found] ` <18196B9D6FC9E354.10803@lists.yoctoproject.org>
2025-01-10 20:00 ` Ryan Eatmon
2025-01-11 0:45 ` Denys Dmytriyenko
2025-01-12 20:15 ` Ryan Eatmon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.