* [xilinx-xlnx:lkp_test 419/504] drivers/mtd/spi-nor/core.c:3434 spi_nor_quad_enable() error: uninitialized symbol 'err'.
@ 2025-01-11 15:36 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2025-01-11 15:36 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: git@amd.com
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
tree: https://github.com/Xilinx/linux-xlnx lkp_test
head: 9ac6b4acf9144465ac1408d4d799635dec0223a0
commit: 4797f25bec4d739b8b2153c950be2a9831c1d54a [419/504] spi: spi-zynqmp-gqspi: Increase timeout interval during data transfer
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: i386-randconfig-141-20250111 (https://download.01.org/0day-ci/archive/20250111/202501112307.AqokvCX3-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202501112307.AqokvCX3-lkp@intel.com/
smatch warnings:
drivers/mtd/spi-nor/core.c:3434 spi_nor_quad_enable() error: uninitialized symbol 'err'.
vim +/err +3434 drivers/mtd/spi-nor/core.c
a33c89db4c3ba8 drivers/mtd/spi-nor/core.c Pratyush Yadav 2020-10-05 3386
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3387 /**
1afc0c89f6a155 drivers/mtd/spi-nor/core.c Yicong Yang 2020-09-04 3388 * spi_nor_quad_enable() - enable Quad I/O if needed.
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3389 * @nor: pointer to a 'struct spi_nor'
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3390 *
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3391 * Return: 0 on success, -errno otherwise.
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3392 */
1afc0c89f6a155 drivers/mtd/spi-nor/core.c Yicong Yang 2020-09-04 3393 static int spi_nor_quad_enable(struct spi_nor *nor)
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3394 {
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3395 struct spi_nor_flash_parameter *params;
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3396 int err, idx;
e0a3141aff2ef7 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3397
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3398 if (nor->flags & SNOR_F_HAS_PARALLEL) {
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3399 params = spi_nor_get_params(nor, 0);
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3400 if (!params->quad_enable)
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3401 return 0;
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3402
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3403 if (!(spi_nor_get_protocol_width(nor->read_proto) == 4 ||
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3404 spi_nor_get_protocol_width(nor->write_proto) == 4))
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3405 return 0;
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3406 /*
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3407 * In parallel mode both chip selects i.e., CS0 &
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3408 * CS1 need to be asserted simulatneously.
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3409 */
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3410 nor->spimem->spi->cs_index_mask = SPI_NOR_ENABLE_MULTI_CS;
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3411 err = params->quad_enable(nor);
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3412 if (err)
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3413 return err;
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3414 } else {
4797f25bec4d73 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3415 for (idx = 0; idx < nor->num_flash; idx++) {
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3416 params = spi_nor_get_params(nor, idx);
e0a3141aff2ef7 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3417 if (!params->quad_enable)
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3418 return 0;
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3419
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3420 if (!(spi_nor_get_protocol_width(nor->read_proto) == 4 ||
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3421 spi_nor_get_protocol_width(nor->write_proto) == 4))
46dde01f6bab35 drivers/mtd/spi-nor/spi-nor.c Kamal Dasu 2017-08-22 3422 return 0;
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3423 /*
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3424 * Set the appropriate CS index before
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3425 * issuing the command.
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3426 */
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3427 nor->spimem->spi->cs_index_mask = 1 << idx;
42f5994724bcbc drivers/mtd/spi-nor/spi-nor.c Tudor Ambarus 2019-08-23 3428
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3429 err = params->quad_enable(nor);
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3430 if (err)
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3431 return err;
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3432 }
4d7a2752a7f124 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 3433 }
1c9ab5adf5dea9 drivers/mtd/spi-nor/core.c Amit Kumar Mahapatra 2024-12-05 @3434 return err;
46dde01f6bab35 drivers/mtd/spi-nor/spi-nor.c Kamal Dasu 2017-08-22 3435 }
46dde01f6bab35 drivers/mtd/spi-nor/spi-nor.c Kamal Dasu 2017-08-22 3436
:::::: The code at line 3434 was first introduced by commit
:::::: 1c9ab5adf5dea9cd33d87918b9ed44df1657a31e mtd: spi-nor: Add stacked memories support in spi-nor
:::::: TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
:::::: CC: Michal Simek <michal.simek@amd.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2025-01-11 15:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-11 15:36 [xilinx-xlnx:lkp_test 419/504] drivers/mtd/spi-nor/core.c:3434 spi_nor_quad_enable() error: uninitialized symbol 'err' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.