* [PATCH -next] kernel/cgroup: Remove the unused variable climit
@ 2025-01-14 6:28 Jiapeng Chong
2025-01-14 15:41 ` Waiman Long
2025-01-15 8:50 ` Maxime Ripard
0 siblings, 2 replies; 5+ messages in thread
From: Jiapeng Chong @ 2025-01-14 6:28 UTC (permalink / raw)
To: tj; +Cc: hannes, mkoutny, cgroups, linux-kernel, Jiapeng Chong,
Abaci Robot
Variable climit is not effectively used, so delete it.
kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13512
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/cgroup/dmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c
index 52736ef0ccf2..78d9361ed521 100644
--- a/kernel/cgroup/dmem.c
+++ b/kernel/cgroup/dmem.c
@@ -299,7 +299,7 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
bool ignore_low, bool *ret_hit_low)
{
struct dmem_cgroup_pool_state *pool = test_pool;
- struct page_counter *climit, *ctest;
+ struct page_counter *ctest;
u64 used, min, low;
/* Can always evict from current pool, despite limits */
@@ -324,7 +324,6 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
{}
}
- climit = &limit_pool->cnt;
ctest = &test_pool->cnt;
dmem_cgroup_calculate_protection(limit_pool, test_pool);
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH -next] kernel/cgroup: Remove the unused variable climit
2025-01-14 6:28 [PATCH -next] kernel/cgroup: Remove the unused variable climit Jiapeng Chong
@ 2025-01-14 15:41 ` Waiman Long
2025-01-14 17:56 ` Maxime Ripard
2025-01-15 8:50 ` Maxime Ripard
1 sibling, 1 reply; 5+ messages in thread
From: Waiman Long @ 2025-01-14 15:41 UTC (permalink / raw)
To: Jiapeng Chong, tj
Cc: hannes, mkoutny, cgroups, linux-kernel, Abaci Robot,
Maxime Ripard, dri-devel
On 1/14/25 1:28 AM, Jiapeng Chong wrote:
> Variable climit is not effectively used, so delete it.
>
> kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13512
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> kernel/cgroup/dmem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c
> index 52736ef0ccf2..78d9361ed521 100644
> --- a/kernel/cgroup/dmem.c
> +++ b/kernel/cgroup/dmem.c
> @@ -299,7 +299,7 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> bool ignore_low, bool *ret_hit_low)
> {
> struct dmem_cgroup_pool_state *pool = test_pool;
> - struct page_counter *climit, *ctest;
> + struct page_counter *ctest;
> u64 used, min, low;
>
> /* Can always evict from current pool, despite limits */
> @@ -324,7 +324,6 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> {}
> }
>
> - climit = &limit_pool->cnt;
> ctest = &test_pool->cnt;
>
> dmem_cgroup_calculate_protection(limit_pool, test_pool);
The dmem controller is actually pulled into the drm tree at the moment.
cc relevant parties on how to handle this fix commit.
Cheers,
Longman
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] kernel/cgroup: Remove the unused variable climit
2025-01-14 15:41 ` Waiman Long
@ 2025-01-14 17:56 ` Maxime Ripard
2025-01-14 20:44 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Maxime Ripard @ 2025-01-14 17:56 UTC (permalink / raw)
To: Waiman Long
Cc: Jiapeng Chong, tj, hannes, mkoutny, cgroups, linux-kernel,
Abaci Robot, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
On Tue, Jan 14, 2025 at 10:41:28AM -0500, Waiman Long wrote:
> On 1/14/25 1:28 AM, Jiapeng Chong wrote:
> > Variable climit is not effectively used, so delete it.
> >
> > kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13512
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> > kernel/cgroup/dmem.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c
> > index 52736ef0ccf2..78d9361ed521 100644
> > --- a/kernel/cgroup/dmem.c
> > +++ b/kernel/cgroup/dmem.c
> > @@ -299,7 +299,7 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> > bool ignore_low, bool *ret_hit_low)
> > {
> > struct dmem_cgroup_pool_state *pool = test_pool;
> > - struct page_counter *climit, *ctest;
> > + struct page_counter *ctest;
> > u64 used, min, low;
> > /* Can always evict from current pool, despite limits */
> > @@ -324,7 +324,6 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> > {}
> > }
> > - climit = &limit_pool->cnt;
> > ctest = &test_pool->cnt;
> > dmem_cgroup_calculate_protection(limit_pool, test_pool);
>
> The dmem controller is actually pulled into the drm tree at the moment.
>
> cc relevant parties on how to handle this fix commit.
We can either take it through drm with one of the cgroup maintainers
ack, or they can merge the PR in their tree and merge the fixes as they
wish through their tree.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] kernel/cgroup: Remove the unused variable climit
2025-01-14 17:56 ` Maxime Ripard
@ 2025-01-14 20:44 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2025-01-14 20:44 UTC (permalink / raw)
To: Maxime Ripard
Cc: Waiman Long, Jiapeng Chong, hannes, mkoutny, cgroups,
linux-kernel, Abaci Robot, dri-devel
On Tue, Jan 14, 2025 at 06:56:38PM +0100, Maxime Ripard wrote:
> On Tue, Jan 14, 2025 at 10:41:28AM -0500, Waiman Long wrote:
> > On 1/14/25 1:28 AM, Jiapeng Chong wrote:
> > > Variable climit is not effectively used, so delete it.
> > >
> > > kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used.
> > >
> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=13512
> > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > > ---
> > > kernel/cgroup/dmem.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/kernel/cgroup/dmem.c b/kernel/cgroup/dmem.c
> > > index 52736ef0ccf2..78d9361ed521 100644
> > > --- a/kernel/cgroup/dmem.c
> > > +++ b/kernel/cgroup/dmem.c
> > > @@ -299,7 +299,7 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> > > bool ignore_low, bool *ret_hit_low)
> > > {
> > > struct dmem_cgroup_pool_state *pool = test_pool;
> > > - struct page_counter *climit, *ctest;
> > > + struct page_counter *ctest;
> > > u64 used, min, low;
> > > /* Can always evict from current pool, despite limits */
> > > @@ -324,7 +324,6 @@ bool dmem_cgroup_state_evict_valuable(struct dmem_cgroup_pool_state *limit_pool,
> > > {}
> > > }
> > > - climit = &limit_pool->cnt;
> > > ctest = &test_pool->cnt;
> > > dmem_cgroup_calculate_protection(limit_pool, test_pool);
> >
> > The dmem controller is actually pulled into the drm tree at the moment.
> >
> > cc relevant parties on how to handle this fix commit.
>
> We can either take it through drm with one of the cgroup maintainers
> ack, or they can merge the PR in their tree and merge the fixes as they
> wish through their tree.
Acked-by: Tejun Heo <tj@kernel.org>
Please route with the rest of dmem changes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] kernel/cgroup: Remove the unused variable climit
2025-01-14 6:28 [PATCH -next] kernel/cgroup: Remove the unused variable climit Jiapeng Chong
2025-01-14 15:41 ` Waiman Long
@ 2025-01-15 8:50 ` Maxime Ripard
1 sibling, 0 replies; 5+ messages in thread
From: Maxime Ripard @ 2025-01-15 8:50 UTC (permalink / raw)
To: tj, Jiapeng Chong
Cc: Maxime Ripard, hannes, mkoutny, cgroups, linux-kernel,
Abaci Robot
On Tue, 14 Jan 2025 14:28:04 +0800, Jiapeng Chong wrote:
> Variable climit is not effectively used, so delete it.
>
> kernel/cgroup/dmem.c:302:23: warning: variable ‘climit’ set but not used.
>
>
Applied to misc/kernel.git (drm-misc-next-fixes).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-01-15 8:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-14 6:28 [PATCH -next] kernel/cgroup: Remove the unused variable climit Jiapeng Chong
2025-01-14 15:41 ` Waiman Long
2025-01-14 17:56 ` Maxime Ripard
2025-01-14 20:44 ` Tejun Heo
2025-01-15 8:50 ` Maxime Ripard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.