From: Yuan Wang <yuanx.wang@intel.com>
To: dev@dpdk.org
Cc: anatoly.burakov@intel.com, vladimir.medvedkin@intel.com,
Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
stable@dpdk.org, Yuan Wang <yuanx.wang@intel.com>
Subject: [PATCH 03/10] net/ixgbe/base: disable 2.5/5G speeds from auto-negotiation for E610
Date: Tue, 14 Jan 2025 18:10:13 +0800 [thread overview]
Message-ID: <20250114101024.159941-4-yuanx.wang@intel.com> (raw)
In-Reply-To: <20250114101024.159941-1-yuanx.wang@intel.com>
From: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
2.5 and 5 Gbps link speeds must be excluded from the auto-negotiation set
used during driver initialization due to compatibility issues with
certain switches. Those issues do not exist in case of E610 2.5G SKU
device (0x57b1).
Fixes: c6cb313da739 (net/ixgbe/base: add link management for E610)
Cc: stable@dpdk.org
Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>
Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
drivers/net/ixgbe/base/ixgbe_e610.c | 35 +++++++++++++++++++----------
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c
index ee8614d3db..a7d642887f 100644
--- a/drivers/net/ixgbe/base/ixgbe_e610.c
+++ b/drivers/net/ixgbe/base/ixgbe_e610.c
@@ -4256,16 +4256,6 @@ s32 ixgbe_identify_phy_E610(struct ixgbe_hw *hw)
pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_1G_SGMII ||
pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_1G_USXGMII)
hw->phy.speeds_supported |= IXGBE_LINK_SPEED_1GB_FULL;
- if (pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_T ||
- pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_X ||
- pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_KX ||
- pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
- pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
- hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
- if (pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_5GBASE_T ||
- pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
- pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
- hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
if (pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_10GBASE_T ||
pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_10G_SFI_DA ||
pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_10GBASE_SR ||
@@ -4276,10 +4266,31 @@ s32 ixgbe_identify_phy_E610(struct ixgbe_hw *hw)
pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_10G_USXGMII)
hw->phy.speeds_supported |= IXGBE_LINK_SPEED_10GB_FULL;
- /* Initialize autoneg speeds */
- if (!hw->phy.autoneg_advertised)
+ /* 2.5 and 5 Gbps link speeds must be excluded from the
+ * auto-negotiation set used during driver initialization due to
+ * compatibility issues with certain switches. Those issues do not
+ * exist in case of E610 2.5G SKU device (0x57b1).
+ */
+ if (!hw->phy.autoneg_advertised &&
+ hw->device_id != IXGBE_DEV_ID_E610_2_5G_T)
hw->phy.autoneg_advertised = hw->phy.speeds_supported;
+ if (pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_T ||
+ pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_X ||
+ pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_2500BASE_KX ||
+ pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_SGMII ||
+ pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_2500M_USXGMII)
+ hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
+
+ if (!hw->phy.autoneg_advertised &&
+ hw->device_id == IXGBE_DEV_ID_E610_2_5G_T)
+ hw->phy.autoneg_advertised = hw->phy.speeds_supported;
+
+ if (pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_5GBASE_T ||
+ pcaps.phy_type_low & IXGBE_PHY_TYPE_LOW_5GBASE_KR ||
+ pcaps.phy_type_high & IXGBE_PHY_TYPE_HIGH_5G_USXGMII)
+ hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
+
/* Set PHY ID */
memcpy(&hw->phy.id, pcaps.phy_id_oui, sizeof(u32));
--
2.43.5
next prev parent reply other threads:[~2025-01-14 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 10:10 [PATCH 00/10] update net/ixgbe base driver Yuan Wang
2025-01-14 10:10 ` [PATCH 01/10] net/ixgbe/base: fix TSAM checking return value Yuan Wang
2025-01-14 10:10 ` [PATCH 02/10] net/ixgbe/base: add interface for LED control on E610 Yuan Wang
2025-01-14 10:10 ` Yuan Wang [this message]
2025-01-14 10:10 ` [PATCH 04/10] net/ixgbe/base: Add PTP by PHY feature for E610 Yuan Wang
2025-01-14 10:10 ` [PATCH 05/10] net/ixgbe/base: add definition of FW temp event " Yuan Wang
2025-01-14 10:10 ` [PATCH 06/10] net/ixgbe/base: Add capability for OROM recovery update Yuan Wang
2025-01-14 10:10 ` [PATCH 07/10] net/ixgbe/base: add max_drift_thresh to get_ptp_by_phy Yuan Wang
2025-01-14 10:10 ` [PATCH 08/10] net/ixgbe/base: update VF HV subsystem device ID constant Yuan Wang
2025-01-14 10:10 ` [PATCH 09/10] net/ixgbe/base: add missing buffer copy Yuan Wang
2025-01-20 15:18 ` Bruce Richardson
2025-01-14 10:10 ` [PATCH 10/10] net/ixgbe: update base driver README Yuan Wang
2025-01-20 15:23 ` [PATCH 00/10] update net/ixgbe base driver Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250114101024.159941-4-yuanx.wang@intel.com \
--to=yuanx.wang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=piotr.kwapulinski@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.