From: "Krzysztof Wilczyński" <kw@linux.com>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
cassel@kernel.org, lpieralisi@kernel.org, heiko@sntech.de,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] PCI: dw-rockchip: remove redundant dev_err
Date: Wed, 15 Jan 2025 20:28:28 +0900 [thread overview]
Message-ID: <20250115112828.GJ4176564@rocinante> (raw)
In-Reply-To: <327718207d3cd72847c079ff9d56eb246744c182.1736126067.git.xiaopei01@kylinos.cn>
Hello,
> dev_err is redundant because platform_get_irq_byname() already prints an
> error.
>
> cocci warnings:
> drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is
> redundant because platform_get_irq() already prints an error
>
> so remove redundant dev_err.
Applied to controller/dwc for v6.14, thank you!
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Pei Xiao <xiaopei01@kylinos.cn>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
cassel@kernel.org, lpieralisi@kernel.org, heiko@sntech.de,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] PCI: dw-rockchip: remove redundant dev_err
Date: Wed, 15 Jan 2025 20:28:28 +0900 [thread overview]
Message-ID: <20250115112828.GJ4176564@rocinante> (raw)
In-Reply-To: <327718207d3cd72847c079ff9d56eb246744c182.1736126067.git.xiaopei01@kylinos.cn>
Hello,
> dev_err is redundant because platform_get_irq_byname() already prints an
> error.
>
> cocci warnings:
> drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is
> redundant because platform_get_irq() already prints an error
>
> so remove redundant dev_err.
Applied to controller/dwc for v6.14, thank you!
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-01-15 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 8:14 [PATCH v2] PCI: dw-rockchip: remove redundant dev_err Pei Xiao
2025-01-06 8:14 ` Pei Xiao
2025-01-06 11:36 ` Niklas Cassel
2025-01-06 11:36 ` Niklas Cassel
2025-01-15 11:28 ` Krzysztof Wilczyński [this message]
2025-01-15 11:28 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115112828.GJ4176564@rocinante \
--to=kw@linux.com \
--cc=cassel@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lkp@intel.com \
--cc=lpieralisi@kernel.org \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.